You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "eric-maynard (Code Review)" <ge...@cloudera.org> on 2016/11/30 22:08:47 UTC
[kudu-CR] Patch for [KUDU-1422]
eric-maynard has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5287
Change subject: Patch for [KUDU-1422]
......................................................................
Patch for [KUDU-1422]
Change-Id: Ia53793c0c8c420df9650b67f8a111b8606a4068c
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/5287/1
--
To view, visit http://gerrit.cloudera.org:8080/5287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia53793c0c8c420df9650b67f8a111b8606a4068c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: eric-maynard <em...@cloudera.com>
[kudu-CR] Patch for [KUDU-1422]
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Patch for [KUDU-1422]
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5287/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:
Line 207: this.errorCollector.setMaxCapacity(size);
oh, now I see that you accidentally split it into two reviews. You should squash this into the other patch using a git rebase -i
I also think that tying this to the mutation buffer space is a mistake, we should add a new public API.
--
To view, visit http://gerrit.cloudera.org:8080/5287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53793c0c8c420df9650b67f8a111b8606a4068c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: eric-maynard <em...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Patch for [KUDU-1422]
Posted by "eric-maynard (Code Review)" <ge...@cloudera.org>.
eric-maynard has abandoned this change.
Change subject: Patch for [KUDU-1422]
......................................................................
Abandoned
Incorporated into 5291
--
To view, visit http://gerrit.cloudera.org:8080/5287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia53793c0c8c420df9650b67f8a111b8606a4068c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: eric-maynard <em...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: eric-maynard <em...@cloudera.com>
[kudu-CR] Patch for [KUDU-1422]
Posted by "eric-maynard (Code Review)" <ge...@cloudera.org>.
eric-maynard has posted comments on this change.
Change subject: Patch for [KUDU-1422]
......................................................................
Patch Set 1:
> (1 comment)
Yeah, my bad. I did two commits without realizing it would create two gerrit changes. A new API is a good idea. I thought that the error queue size and the mutation buffer space were the same size for some reason and wanted to keep them aligned. I'll rebase and close this change.
--
To view, visit http://gerrit.cloudera.org:8080/5287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia53793c0c8c420df9650b67f8a111b8606a4068c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: eric-maynard <em...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: eric-maynard <em...@cloudera.com>
Gerrit-HasComments: No