You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/08 15:23:32 UTC
[GitHub] [iceberg] RussellSpitzer opened a new pull request #2795: Build: Change Spark Versions to Support M1 Processors
RussellSpitzer opened a new pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795
Spark's Snappy native lib support is missing M1 support in
our current build. Upgrading Spark upgrades Snappy to a version
which has these native libs. This has no effect on actual runtime
Spark for end users since we do not include Spark with our
release jars.
Fixes #2794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876533561
Anyone with an M1 could you please try this out :) I don't actually have one @karuppayya or @kbendick I think you have the M1 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer edited a comment on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
RussellSpitzer edited a comment on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876533561
Anyone with an M1 could you please try this out :) I don't actually have one @karuppayya or @kbendick I think you have the M1 right?
We just need someone with an m1 to run through the test suite locally, specifically the Spark related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-877241002
Thats good enough for me! Thanks for testing @KarlManong!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876782285
> Anyone with an M1 could you please try this out :) I don't actually have one @karuppayya or @kbendick I think you have the M1 right?
>
> We just need someone with an m1 to run through the test suite locally, specifically the Spark related tests.
No unfortunately I don't have an M1 @RussellSpitzer. I'll let you know if somebody comes to mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876890765
> [build.log](https://github.com/apache/iceberg/files/6788272/build.log)
> @RussellSpitzer
> Ops! Test failed.
Can you see whether snappy-java-1.1.8.2.jar was successfully included? I checked the contents
```
tar -tvf snappy-java-1.1.8.2.jar | grep -Hsi Mac
(standard input):drwxrwxr-x 0 0 0 0 Nov 28 2020 org/xerial/snappy/native/Mac/
(standard input):drwxrwxr-x 0 0 0 0 Nov 28 2020 org/xerial/snappy/native/Mac/aarch64/
(standard input):-rw-rw-r-- 0 0 0 71184 Nov 28 2020 org/xerial/snappy/native/Mac/aarch64/libsnappyjava.dylib
```
It has the right native lib in the snappy jar
and when I run the suite it uses this jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KarlManong commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
KarlManong commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876953384
> > [build.log](https://github.com/apache/iceberg/files/6788272/build.log)
> > @RussellSpitzer
> > Ops! Test failed.
>
> Can you see whether snappy-java-1.1.8.2.jar was successfully included? I checked the contents
>
> ```
> tar -tvf snappy-java-1.1.8.2.jar | grep -Hsi Mac
> (standard input):drwxrwxr-x 0 0 0 0 Nov 28 2020 org/xerial/snappy/native/Mac/
> (standard input):drwxrwxr-x 0 0 0 0 Nov 28 2020 org/xerial/snappy/native/Mac/aarch64/
> (standard input):-rw-rw-r-- 0 0 0 71184 Nov 28 2020 org/xerial/snappy/native/Mac/aarch64/libsnappyjava.dylib
> ```
>
> It has the right native lib in the snappy jar
>
> and when I run the suite it uses this jar
>
> 
Sorry, I ran on the wrong branch.
The fix works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] karuppayya commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
karuppayya commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876838920
@RussellSpitzer I also dont have M1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KarlManong edited a comment on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
KarlManong edited a comment on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876848846
@RussellSpitzer
Ops! Test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KarlManong commented on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
KarlManong commented on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876848846
@RussellSpitzer
It works. Thank u!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KarlManong edited a comment on pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
KarlManong edited a comment on pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795#issuecomment-876848846
[build.log](https://github.com/apache/iceberg/files/6788272/build.log)
@RussellSpitzer
Ops! Test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer merged pull request #2795: Build: Change Spark Versions to Support M1 Processors
Posted by GitBox <gi...@apache.org>.
RussellSpitzer merged pull request #2795:
URL: https://github.com/apache/iceberg/pull/2795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org