(plc4x) branch develop updated: fix: fixed the build prior to java 19

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new 464f5106d9 fix: fixed the build prior to java 19
464f5106d9 is described below

commit 464f5106d98d0f4bd4ad3dedd203ccb3f9c09556
Author: Christofer Dutz <cd...@apache.org>
AuthorDate: Tue Feb 6 13:30:05 2024 +0100

    fix: fixed the build prior to java 19
---
 .../org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java b/plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
index 2c38a2a9da..d02be979b7 100644
--- a/plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
+++ b/plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
@@ -130,10 +130,11 @@ public class S7ProtocolLogic extends Plc4xProtocolBase<TPKTPacket> {
 
     @Override
     public void close(ConversationContext<TPKTPacket> context) {
-        // TODO Implement Closing on Protocol Level
-        clientExecutorService.close();
+        // TODO: Find out how to close this prior to Java 19
+        //clientExecutorService.close();
         tm.shutdown();
         eventLogic.stop();
+        // TODO Implement Closing on Protocol Level
     }
 
     @Override