You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2013/09/24 00:27:13 UTC

[Bug 55586] New: Do not include windows.h if it is not WIN32

https://issues.apache.org/bugzilla/show_bug.cgi?id=55586

            Bug ID: 55586
           Summary: Do not include windows.h if it is not WIN32
           Product: APR
           Version: HEAD
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: APR
          Assignee: bugs@apr.apache.org
          Reporter: carlo.bramix@libero.it

Created attachment 30875
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30875&action=edit
Fix for this ticket

Compilation of APR 2.0.0 trunk fails in CYGWIN.
It happens that configure script finds windows.h and other include files for
native coding, but they should not be used: they must be included only in a
native environment like MSVC, MINGW or CYGWIN with gcc-3 and -no-cygwin
(deprecated!), so only when WIN32 macro is defined.

Attached patch fixes this bug.

Sincerely,

Carlo Bramini.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55586] Do not include windows.h if it is not WIN32

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55586

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Jeff Trawick <tr...@apache.org> ---
Committed to trunk as r1529521...  I'll check builds of 1.5.x on Cygwin soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55586] Do not include windows.h if it is not WIN32

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55586

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55586] Do not include windows.h if it is not WIN32

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55586

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jeff Trawick <tr...@apache.org> ---
Committed to apr-1.5.x with r1529671.

Thanks!

(Yeah, I don't have a complete fix for building the APR DSOs.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55586] Do not include windows.h if it is not WIN32

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55586

--- Comment #2 from Carlo Bramini <ca...@libero.it> ---
If you are planning to build the latest APR on CYGWIN (1.5.x. or 1.7.x does not
matter, I tried myself right now), I just wanted to write that probably you
won't be able to do that without tricks: perhaps you will be forced to feed
options like --without-sqlite3, --without-odbc, etc, otherwise the build of the
modules will fail because their dependency to libapr (see bug #54291).
For the compatibility with CYGWIN, I also recommend the fixes inside bug #51016
and bug #55587.

Sincerely,

Carlo Bramini.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org