You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/08/18 22:07:00 UTC
mesos git commit: Added a comment in Perf to explain kill correctness.
Repository: mesos
Updated Branches:
refs/heads/master 9f2386f1f -> fdeac61e7
Added a comment in Perf to explain kill correctness.
Review: https://reviews.apache.org/r/37424
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/fdeac61e
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/fdeac61e
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/fdeac61e
Branch: refs/heads/master
Commit: fdeac61e7fac9f3975dff9d0524a67989e3b90fc
Parents: 9f2386f
Author: Paul Brett <pa...@twopensource.com>
Authored: Tue Aug 18 13:05:28 2015 -0700
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Tue Aug 18 13:06:48 2015 -0700
----------------------------------------------------------------------
src/linux/perf.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/fdeac61e/src/linux/perf.cpp
----------------------------------------------------------------------
diff --git a/src/linux/perf.cpp b/src/linux/perf.cpp
index cab6271..cdc5f83 100644
--- a/src/linux/perf.cpp
+++ b/src/linux/perf.cpp
@@ -193,7 +193,9 @@ protected:
virtual void finalize()
{
- // Kill the perf process if it's still running.
+ // Kill the perf process (if it's still running) by sending
+ // SIGTERM to the signal handler which will then SIGKILL the
+ // perf process group created by setupChild.
if (perf.isSome() && perf.get().status().isPending()) {
kill(perf.get().pid(), SIGTERM);
}