You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 17:13:36 UTC

[GitHub] [beam] damccorm opened a new issue, #20398: Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?

damccorm opened a new issue, #20398:
URL: https://github.com/apache/beam/issues/20398

   https://github.com/apache/beam/blob/6fdde4f4eab72b49b10a8bb1cb3be263c5c416b5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L215
   
   Can we remove the "final" modifier here so subclasses have the option to override? I have a subclass implementation that performs best with a different size estimation heuristic. Similar case with the #split method.
   
   Imported from Jira [BEAM-10604](https://issues.apache.org/jira/browse/BEAM-10604). Original Jira may contain additional context.
   Reported by: clairemcginty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org