You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/12 14:07:24 UTC
[GitHub] [cloudstack] sureshanaparti opened a new pull request, #5797: Improve global settings UI to be more intuitive/logical
sureshanaparti opened a new pull request, #5797:
URL: https://github.com/apache/cloudstack/pull/5797
### Description
This PR improve global settings UI to be more intuitive/logical.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### Screenshots (if appropriate):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1094707898
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
utchoang commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097597804
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1101284967
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108539851
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180338748
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398138106
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386625240
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400268954
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1280503023
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386744969
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 5306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398106235
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371894448
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1370618886
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063487422
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/dao/ConfigurationSubGroupDaoImpl.java:
##########
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config.dao;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.function.BiPredicate;
+
+import org.apache.cloudstack.framework.config.impl.ConfigurationSubGroupVO;
+import org.apache.commons.lang3.StringUtils;
+import org.springframework.stereotype.Component;
+
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+public class ConfigurationSubGroupDaoImpl extends GenericDaoBase<ConfigurationSubGroupVO, Long> implements ConfigurationSubGroupDao {
+
+ final SearchBuilder<ConfigurationSubGroupVO> nameSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> groupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> nameAndGroupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> keywordSearch;
+
+ public ConfigurationSubGroupDaoImpl() {
+ super();
+
+ nameSearch = createSearchBuilder();
+ nameSearch.and("name", nameSearch.entity().getName(), SearchCriteria.Op.LIKE);
+ nameSearch.done();
+
+ groupSearch = createSearchBuilder();
+ groupSearch.and("groupId", groupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ groupSearch.done();
+
+ nameAndGroupSearch = createSearchBuilder();
+ nameAndGroupSearch.and("name", nameAndGroupSearch.entity().getName(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.and("groupId", nameAndGroupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.done();
+
+ keywordSearch = createSearchBuilder();
+ keywordSearch.and("keywords", keywordSearch.entity().getKeywords(), SearchCriteria.Op.NNULL);
+ keywordSearch.done();
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByName(String name) {
Review Comment:
`findby`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375095317
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315083333
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180299390
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180362605
<b>Trillian Build Failed (tid-4478)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182794412
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182864295
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097597972
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
utchoang commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097732573
@sureshanaparti With dark view, when hovering over the rows, it looks like below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1373456708
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1373512234
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1381372757
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386681785
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398137668
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386890919
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1401338876
<b>Trillian test result (tid-5958)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51257 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5958-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_disable_oobm_ha_state_ineligible | `Error` | 1513.09 | test_hostha_kvm.py
test_hostha_kvm_host_degraded | `Error` | 7.25 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "davidjumani (via GitHub)" <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400267773
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375095897
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by sonarcloud.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1408489767
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1379806197
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108349174
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
|VirtualMachineManager|110|0|4|0|12|0|
||
|StorageManager|0|217|0|0|0|21|
|ClusteredAgentManagerImpl|2364|0|242|0|537|0|
|ConfigurationGroupsAggregator|131|22|20|0|33|6|
|Upgrade41610to41700|165|12|6|0|46|3|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|KubernetesClusterService|0|84|0|0|0|13|
|PrometheusExporterServer|35|0|0|0|5|0|
||
||
|ApiResponseHelper|12260|0|1280|0|2806|0|
|ConfigurationManagerImpl|18272|0|3066|0|3616|0|
|VirtualNetworkApplianceManager|281|0|0|0|31|0|
|ConfigurationServerImpl|2076|0|176|0|498|0|
|ManagementServerImpl|12287|0|1088|0|2453|0|
|UserVmManagerImpl|20804|0|2566|0|3872|0|
|DiagnosticsServiceImpl|951|0|66|0|169|0|
||
||
||
||
||
|MockConfigurationDaoImpl|636|0|14|0|87|0|
||
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108307149
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108497419
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1253345079
@borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1254150371
<b>Trillian test result (tid-4944)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40860 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t4944-xenserver-71.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 958.21 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1.29 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315092882
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (LL-JID-245)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1198077018
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1198136898
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106806387
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1346058826
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1094897452
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097631925
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102332760
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108552055
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106698262
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1444)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106690770
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106724766
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106807443
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106726001
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182823074
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182798115
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1199193921
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1380558795
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [66 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #5797: Improve global settings UI to be more intuitive/logical
URL: https://github.com/apache/cloudstack/pull/5797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386680255
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1379887709
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398434500
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1373454257
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063259010
##########
api/src/main/java/com/cloud/server/ManagementService.java:
##########
@@ -102,6 +104,13 @@ public interface ManagementService {
*/
Pair<List<? extends Configuration>, Integer> searchForConfigurations(ListCfgsByCmd c);
+ /**
+ * returns the the configuration groups
+ *
+ * @return list of configuration groups
+ */
+ Pair<List<? extends ConfigurationGroup>, Integer> listConfigurationGroups(ListCfgGroupsByCmd cmd);
Review Comment:
Just for consistency across the function definitions in interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1062344189
##########
api/src/main/java/com/cloud/server/ManagementService.java:
##########
@@ -102,6 +104,13 @@ public interface ManagementService {
*/
Pair<List<? extends Configuration>, Integer> searchForConfigurations(ListCfgsByCmd c);
+ /**
+ * returns the the configuration groups
+ *
+ * @return list of configuration groups
+ */
+ Pair<List<? extends ConfigurationGroup>, Integer> listConfigurationGroups(ListCfgGroupsByCmd cmd);
Review Comment:
Any reason this would not suffice?
```suggestion
Pair<List<ConfigurationGroup>, Integer> listConfigurationGroups(ListCfgGroupsByCmd cmd);
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgGroupsByCmd.java:
##########
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.config;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.ConfigurationGroupResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.config.ConfigurationGroup;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.Pair;
+
+@APICommand(name = ListCfgGroupsByCmd.APINAME, description = "Lists all configuration groups (primarily used for UI).", responseObject = ConfigurationGroupResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, since = "4.18.0")
+public class ListCfgGroupsByCmd extends BaseListCmd {
+ public static final Logger s_logger = Logger.getLogger(ListCfgGroupsByCmd.class.getName());
+
+ public static final String APINAME = "listConfigurationGroups";
+
+ // ///////////////////////////////////////////////////
+ // ////////////// API parameters /////////////////////
+ // ///////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.GROUP, type = CommandType.STRING, description = "lists configuration group by group name")
+ private String groupName;
+
+ // ///////////////////////////////////////////////////
+ // ///////////////// Accessors ///////////////////////
+ // ///////////////////////////////////////////////////
+
+ public String getGroupName() {
+ return groupName;
+ }
+
+ // ///////////////////////////////////////////////////
+ // ///////////// API Implementation///////////////////
+ // ///////////////////////////////////////////////////
+
+ @Override
+ public String getCommandName() {
+ return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+ }
+
+ @Override
+ public void execute() {
+ Pair<List<? extends ConfigurationGroup>, Integer> result = _mgr.listConfigurationGroups(this);
Review Comment:
```suggestion
Pair<List<ConfigurationGroup>, Integer> result = _mgr.listConfigurationGroups(this);
```
?
##########
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java:
##########
@@ -136,14 +136,17 @@ public ConfigKey<?>[] getConfigKeys() {
List<ConfigKey<String>> result = new ArrayList<ConfigKey<String>>();
if (orderConfigKey != null && orderConfigKeyObj == null) {
- orderConfigKeyObj = new ConfigKey<String>("Advanced", String.class, orderConfigKey, orderConfigDefault, "The order of precedence for the extensions", false);
+ orderConfigKeyObj = new ConfigKey<String>(String.class, orderConfigKey, "Advanced", orderConfigDefault, "The order of precedence for the extensions", false, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Order, orderConfigDefault);
Review Comment:
```suggestion
orderConfigKeyObj = new ConfigKey<>(String.class, orderConfigKey, "Advanced", orderConfigDefault, "The order of precedence for the extensions", false, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Order, orderConfigDefault);
```
##########
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java:
##########
@@ -136,14 +136,17 @@ public ConfigKey<?>[] getConfigKeys() {
List<ConfigKey<String>> result = new ArrayList<ConfigKey<String>>();
if (orderConfigKey != null && orderConfigKeyObj == null) {
- orderConfigKeyObj = new ConfigKey<String>("Advanced", String.class, orderConfigKey, orderConfigDefault, "The order of precedence for the extensions", false);
+ orderConfigKeyObj = new ConfigKey<String>(String.class, orderConfigKey, "Advanced", orderConfigDefault, "The order of precedence for the extensions", false, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Order, orderConfigDefault);
}
+ // orderConfigKeyObj = new ConfigKey<String>("Advanced", String.class, orderConfigKey, orderConfigDefault, "The order of precedence for the extensions", false, Scope.Global, null, null, null, null, null, null, null);
+
+
if (orderConfigKeyObj != null)
result.add(orderConfigKeyObj);
if (excludeKey != null && excludeKeyObj == null) {
- excludeKeyObj = new ConfigKey<String>("Advanced", String.class, excludeKey, excludeDefault, "Extensions to exclude from being registered", false);
+ excludeKeyObj = new ConfigKey<String>(String.class, excludeKey, "Advanced", excludeDefault, "Extensions to exclude from being registered", false, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.CSV, null);
Review Comment:
```suggestion
excludeKeyObj = new ConfigKey<>(String.class, excludeKey, "Advanced", excludeDefault, "Extensions to exclude from being registered", false, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.CSV, null);
```
##########
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##########
@@ -993,3 +993,246 @@ BEGIN
DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' ADD KEY ') ; SET @ddl = CONCAT(@ddl, ' ', in_index_name); SET @ddl = CONCAT(@ddl, ' ', in_key_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE stmt; END;
CALL `cloud`.`IDEMPOTENT_ADD_KEY`('i_user_ip_address_state','user_ip_address', '(state)');
+--
+-- Update Configuration Groups and Subgroups
+--
Review Comment:
none of the add columns below are idem potent
##########
api/src/main/java/org/apache/cloudstack/ca/CAManager.java:
##########
@@ -46,10 +46,10 @@ public interface CAManager extends CAService, Configurable, PluggableService {
"2048",
"The key size to be used for random certificate keypair generation.", true);
- ConfigKey<String> CertSignatureAlgorithm = new ConfigKey<>("Advanced", String.class,
- "ca.framework.cert.signature.algorithm",
+ ConfigKey<String> CertSignatureAlgorithm = new ConfigKey<String>(String.class,
Review Comment:
```suggestion
ConfigKey<String> CertSignatureAlgorithm = new ConfigKey<>(String.class,
```
##########
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##########
@@ -94,13 +94,13 @@ public interface QueryService {
ConfigKey<Boolean> AllowUserViewDestroyedVM = new ConfigKey<>("Advanced", Boolean.class, "allow.user.view.destroyed.vm", "false",
"Determines whether users can view their destroyed or expunging vm ", true, ConfigKey.Scope.Account);
- static final ConfigKey<String> UserVMDeniedDetails = new ConfigKey<String>("Advanced", String.class,
- "user.vm.denied.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
- "Determines whether users can view certain VM settings. When set to empty, default value used is: rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag.", true);
+ static final ConfigKey<String> UserVMDeniedDetails = new ConfigKey<String>(String.class,
Review Comment:
```suggestion
static final ConfigKey<String> UserVMDeniedDetails = new ConfigKey<>(String.class,
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java:
##########
@@ -145,35 +179,69 @@ public Long getPageSizeVal() {
@Override
public void execute() {
- Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
- ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
- List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
- for (Configuration cfg : result.first()) {
- ConfigurationResponse cfgResponse = _responseGenerator.createConfigurationResponse(cfg);
- cfgResponse.setObjectName("configuration");
- if (getZoneId() != null) {
- cfgResponse.setScope("zone");
- }
- if (getClusterId() != null) {
- cfgResponse.setScope("cluster");
- }
- if (getStoragepoolId() != null) {
- cfgResponse.setScope("storagepool");
+ validateParameters();
+ try {
+ Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
+ ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
+ List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
Review Comment:
```suggestion
ListResponse<ConfigurationResponse> response = new ListResponse<>();
List<ConfigurationResponse> configResponses = new ArrayList<>();
```
##########
api/src/main/java/org/apache/cloudstack/config/ApiServiceConfiguration.java:
##########
@@ -20,15 +20,15 @@
import org.apache.cloudstack.framework.config.Configurable;
public class ApiServiceConfiguration implements Configurable {
- public static final ConfigKey<String> ManagementServerAddresses = new ConfigKey<String>("Advanced", String.class, "host", "localhost", "The ip address of management server. This can also accept comma separated addresses.", true);
+ public static final ConfigKey<String> ManagementServerAddresses = new ConfigKey<String>(String.class, "host", "Advanced", "localhost", "The ip address of management server. This can also accept comma separated addresses.", true, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.CSV, null);
public static final ConfigKey<String> ApiServletPath = new ConfigKey<String>("Advanced", String.class, "endpoint.url", "http://localhost:8080/client/api",
"API end point. Can be used by CS components/services deployed remotely, for sending CS API requests", true);
public static final ConfigKey<Long> DefaultUIPageSize = new ConfigKey<Long>("Advanced", Long.class, "default.ui.page.size", "20",
"The default pagesize to be used by UI and other clients when making list* API calls", true, ConfigKey.Scope.Global);
public static final ConfigKey<Boolean> ApiSourceCidrChecksEnabled = new ConfigKey<>("Advanced", Boolean.class, "api.source.cidr.checks.enabled",
"true", "Are the source checks on API calls enabled (true) or not (false)? See api.allowed.source.cidr.list", true, ConfigKey.Scope.Global);
- public static final ConfigKey<String> ApiAllowedSourceCidrList = new ConfigKey<String>("Advanced", String.class, "api.allowed.source.cidr.list",
- "0.0.0.0/0,::/0", "Comma separated list of IPv4/IPv6 CIDRs from which API calls can be performed. Can be set on Global and Account levels.", true, ConfigKey.Scope.Account);
+ public static final ConfigKey<String> ApiAllowedSourceCidrList = new ConfigKey<String>(String.class, "api.allowed.source.cidr.list", "Advanced",
Review Comment:
```suggestion
public static final ConfigKey<String> ApiAllowedSourceCidrList = new ConfigKey<>(String.class, "api.allowed.source.cidr.list", "Advanced",
```
##########
api/src/main/java/org/apache/cloudstack/config/ApiServiceConfiguration.java:
##########
@@ -20,15 +20,15 @@
import org.apache.cloudstack.framework.config.Configurable;
public class ApiServiceConfiguration implements Configurable {
- public static final ConfigKey<String> ManagementServerAddresses = new ConfigKey<String>("Advanced", String.class, "host", "localhost", "The ip address of management server. This can also accept comma separated addresses.", true);
+ public static final ConfigKey<String> ManagementServerAddresses = new ConfigKey<String>(String.class, "host", "Advanced", "localhost", "The ip address of management server. This can also accept comma separated addresses.", true, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.CSV, null);
Review Comment:
```suggestion
public static final ConfigKey<String> ManagementServerAddresses = new ConfigKey<>(String.class, "host", "Advanced", "localhost", "The ip address of management server. This can also accept comma separated addresses.", true, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.CSV, null);
```
##########
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##########
@@ -94,13 +94,13 @@ public interface QueryService {
ConfigKey<Boolean> AllowUserViewDestroyedVM = new ConfigKey<>("Advanced", Boolean.class, "allow.user.view.destroyed.vm", "false",
"Determines whether users can view their destroyed or expunging vm ", true, ConfigKey.Scope.Account);
- static final ConfigKey<String> UserVMDeniedDetails = new ConfigKey<String>("Advanced", String.class,
- "user.vm.denied.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
- "Determines whether users can view certain VM settings. When set to empty, default value used is: rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag.", true);
+ static final ConfigKey<String> UserVMDeniedDetails = new ConfigKey<String>(String.class,
+ "user.vm.denied.details", "Advanced", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+ "Determines whether users can view certain VM settings. When set to empty, default value used is: rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag.", true, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.CSV, null);
- static final ConfigKey<String> UserVMReadOnlyDetails = new ConfigKey<String>("Advanced", String.class,
- "user.vm.readonly.details", "dataDiskController, rootDiskController",
- "List of read-only VM settings/details as comma separated string", true);
+ static final ConfigKey<String> UserVMReadOnlyDetails = new ConfigKey<String>(String.class,
Review Comment:
```suggestion
static final ConfigKey<String> UserVMReadOnlyDetails = new ConfigKey<>(String.class,
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgGroupsByCmd.java:
##########
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.config;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.ConfigurationGroupResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.config.ConfigurationGroup;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.Pair;
+
+@APICommand(name = ListCfgGroupsByCmd.APINAME, description = "Lists all configuration groups (primarily used for UI).", responseObject = ConfigurationGroupResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, since = "4.18.0")
+public class ListCfgGroupsByCmd extends BaseListCmd {
+ public static final Logger s_logger = Logger.getLogger(ListCfgGroupsByCmd.class.getName());
+
+ public static final String APINAME = "listConfigurationGroups";
+
+ // ///////////////////////////////////////////////////
+ // ////////////// API parameters /////////////////////
+ // ///////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.GROUP, type = CommandType.STRING, description = "lists configuration group by group name")
+ private String groupName;
+
+ // ///////////////////////////////////////////////////
+ // ///////////////// Accessors ///////////////////////
+ // ///////////////////////////////////////////////////
+
+ public String getGroupName() {
+ return groupName;
+ }
+
+ // ///////////////////////////////////////////////////
+ // ///////////// API Implementation///////////////////
+ // ///////////////////////////////////////////////////
+
+ @Override
+ public String getCommandName() {
+ return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+ }
+
+ @Override
+ public void execute() {
+ Pair<List<? extends ConfigurationGroup>, Integer> result = _mgr.listConfigurationGroups(this);
+ ListResponse<ConfigurationGroupResponse> response = new ListResponse<ConfigurationGroupResponse>();
+ List<ConfigurationGroupResponse> configGroupResponses = new ArrayList<ConfigurationGroupResponse>();
Review Comment:
```suggestion
ListResponse<ConfigurationGroupResponse> response = new ListResponse<>();
List<ConfigurationGroupResponse> configGroupResponses = new ArrayList<>();
```
##########
framework/config/src/test/java/org/apache/cloudstack/framework/config/impl/ConfigDepotAdminTest.java:
##########
@@ -36,11 +41,15 @@
import org.apache.cloudstack.framework.config.ScopedConfigStorage;
import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import com.cloud.utils.Pair;
+import com.cloud.utils.Ternary;
import com.cloud.utils.db.EntityManager;
public class ConfigDepotAdminTest extends TestCase {
private final static ConfigKey<Integer> DynamicIntCK = new ConfigKey<Integer>(Integer.class, "dynIntKey", "Advance", "10", "Test Key", true);
private final static ConfigKey<Integer> StaticIntCK = new ConfigKey<Integer>(Integer.class, "statIntKey", "Advance", "10", "Test Key", false);
+ private final static ConfigKey<Integer> TestCK = new ConfigKey<Integer>(Integer.class, "testKey", "Advance", "30", "Test Key", false,
+ ConfigKey.Scope.Global, null, "Test Display Text", null, new Ternary<String, String, Long>("TestGroup", "Test Group", 3L), new Pair<String, Long>("Test SubGroup", 1L));
Review Comment:
```suggestion
ConfigKey.Scope.Global, null, "Test Display Text", null, new Ternary<>("TestGroup", "Test Group", 3L), new Pair<>("Test SubGroup", 1L));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java:
##########
@@ -145,35 +179,69 @@ public Long getPageSizeVal() {
@Override
public void execute() {
- Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
- ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
- List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
- for (Configuration cfg : result.first()) {
- ConfigurationResponse cfgResponse = _responseGenerator.createConfigurationResponse(cfg);
- cfgResponse.setObjectName("configuration");
- if (getZoneId() != null) {
- cfgResponse.setScope("zone");
- }
- if (getClusterId() != null) {
- cfgResponse.setScope("cluster");
- }
- if (getStoragepoolId() != null) {
- cfgResponse.setScope("storagepool");
+ validateParameters();
+ try {
+ Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
+ ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
+ List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
+ for (Configuration cfg : result.first()) {
+ ConfigurationResponse cfgResponse = _responseGenerator.createConfigurationResponse(cfg);
+ if (!matchesConfigurationGroup(cfgResponse)) {
+ continue;
+ }
+ cfgResponse.setObjectName("configuration");
+ if (getZoneId() != null) {
+ cfgResponse.setScope("zone");
+ }
+ if (getClusterId() != null) {
+ cfgResponse.setScope("cluster");
+ }
+ if (getStoragepoolId() != null) {
+ cfgResponse.setScope("storagepool");
+ }
+ if (getAccountId() != null) {
+ cfgResponse.setScope("account");
+ }
+ if (getDomainId() != null) {
+ cfgResponse.setScope("domain");
+ }
+ if (getImageStoreId() != null){
+ cfgResponse.setScope("imagestore");
+ }
+ configResponses.add(cfgResponse);
}
- if (getAccountId() != null) {
- cfgResponse.setScope("account");
+
+ if (StringUtils.isNotEmpty(getGroupName())) {
+ response.setResponses(configResponses, configResponses.size());
+ } else {
+ response.setResponses(configResponses, result.second());
}
- if (getDomainId() != null) {
- cfgResponse.setScope("domain");
+ response.setResponseName(getCommandName());
+ setResponseObject(response);
+ } catch (InvalidParameterValueException e) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, e.getMessage());
+ } catch (CloudRuntimeException e) {
+ throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, e.getMessage());
+ }
+ }
+
+ private void validateParameters() {
+ if (StringUtils.isNotEmpty(getSubGroupName()) && StringUtils.isEmpty(getGroupName())) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Configuration group name must be specified with the subgroup name");
+ }
+ }
+
+ private boolean matchesConfigurationGroup(ConfigurationResponse cfgResponse) {
+ if (StringUtils.isNotEmpty(getGroupName())) {
+ if (!(getGroupName().equalsIgnoreCase(cfgResponse.getGroup()))) {
+ return false;
}
- if (getImageStoreId() != null){
- cfgResponse.setScope("imagestore");
+ if (StringUtils.isNotEmpty(getSubGroupName())) {
+ if (!(getSubGroupName().equalsIgnoreCase(cfgResponse.getSubGroup()))) {
+ return false;
+ }
}
Review Comment:
```suggestion
if (StringUtils.isNotEmpty(getSubGroupName()) &&
! getSubGroupName().equalsIgnoreCase(cfgResponse.getSubGroup())) {
return false;
}
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java:
##########
@@ -145,35 +179,69 @@ public Long getPageSizeVal() {
@Override
public void execute() {
- Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
- ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
- List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
- for (Configuration cfg : result.first()) {
- ConfigurationResponse cfgResponse = _responseGenerator.createConfigurationResponse(cfg);
- cfgResponse.setObjectName("configuration");
- if (getZoneId() != null) {
- cfgResponse.setScope("zone");
- }
- if (getClusterId() != null) {
- cfgResponse.setScope("cluster");
- }
- if (getStoragepoolId() != null) {
- cfgResponse.setScope("storagepool");
+ validateParameters();
+ try {
+ Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
Review Comment:
again consider if
```suggestion
Pair<List<Configuration>, Integer> result = _mgr.searchForConfigurations(this);
```
is good enough
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java:
##########
@@ -145,35 +179,69 @@ public Long getPageSizeVal() {
@Override
public void execute() {
- Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
- ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
- List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
- for (Configuration cfg : result.first()) {
- ConfigurationResponse cfgResponse = _responseGenerator.createConfigurationResponse(cfg);
- cfgResponse.setObjectName("configuration");
- if (getZoneId() != null) {
- cfgResponse.setScope("zone");
- }
- if (getClusterId() != null) {
- cfgResponse.setScope("cluster");
- }
- if (getStoragepoolId() != null) {
- cfgResponse.setScope("storagepool");
+ validateParameters();
+ try {
+ Pair<List<? extends Configuration>, Integer> result = _mgr.searchForConfigurations(this);
+ ListResponse<ConfigurationResponse> response = new ListResponse<ConfigurationResponse>();
+ List<ConfigurationResponse> configResponses = new ArrayList<ConfigurationResponse>();
+ for (Configuration cfg : result.first()) {
+ ConfigurationResponse cfgResponse = _responseGenerator.createConfigurationResponse(cfg);
+ if (!matchesConfigurationGroup(cfgResponse)) {
+ continue;
+ }
+ cfgResponse.setObjectName("configuration");
+ if (getZoneId() != null) {
+ cfgResponse.setScope("zone");
+ }
+ if (getClusterId() != null) {
+ cfgResponse.setScope("cluster");
+ }
+ if (getStoragepoolId() != null) {
+ cfgResponse.setScope("storagepool");
+ }
+ if (getAccountId() != null) {
+ cfgResponse.setScope("account");
+ }
+ if (getDomainId() != null) {
+ cfgResponse.setScope("domain");
+ }
+ if (getImageStoreId() != null){
+ cfgResponse.setScope("imagestore");
+ }
+ configResponses.add(cfgResponse);
}
Review Comment:
can we extract this?
##########
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java:
##########
@@ -136,14 +136,17 @@ public ConfigKey<?>[] getConfigKeys() {
List<ConfigKey<String>> result = new ArrayList<ConfigKey<String>>();
if (orderConfigKey != null && orderConfigKeyObj == null) {
- orderConfigKeyObj = new ConfigKey<String>("Advanced", String.class, orderConfigKey, orderConfigDefault, "The order of precedence for the extensions", false);
+ orderConfigKeyObj = new ConfigKey<String>(String.class, orderConfigKey, "Advanced", orderConfigDefault, "The order of precedence for the extensions", false, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Order, orderConfigDefault);
}
+ // orderConfigKeyObj = new ConfigKey<String>("Advanced", String.class, orderConfigKey, orderConfigDefault, "The order of precedence for the extensions", false, Scope.Global, null, null, null, null, null, null, null);
+
+
Review Comment:
```suggestion
```
code in comment
##########
framework/config/src/test/java/org/apache/cloudstack/framework/config/impl/ConfigDepotAdminTest.java:
##########
@@ -36,11 +41,15 @@
import org.apache.cloudstack.framework.config.ScopedConfigStorage;
import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import com.cloud.utils.Pair;
+import com.cloud.utils.Ternary;
import com.cloud.utils.db.EntityManager;
public class ConfigDepotAdminTest extends TestCase {
private final static ConfigKey<Integer> DynamicIntCK = new ConfigKey<Integer>(Integer.class, "dynIntKey", "Advance", "10", "Test Key", true);
private final static ConfigKey<Integer> StaticIntCK = new ConfigKey<Integer>(Integer.class, "statIntKey", "Advance", "10", "Test Key", false);
+ private final static ConfigKey<Integer> TestCK = new ConfigKey<Integer>(Integer.class, "testKey", "Advance", "30", "Test Key", false,
Review Comment:
```suggestion
private final static ConfigKey<Integer> TestCK = new ConfigKey<>(Integer.class, "testKey", "Advance", "30", "Test Key", false,
```
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java:
##########
@@ -65,8 +65,8 @@ public class ImageStoreProviderManagerImpl implements ImageStoreProviderManager,
Map<String, ImageStoreDriver> driverMaps;
- static final ConfigKey<String> ImageStoreAllocationAlgorithm = new ConfigKey<String>("Advanced", String.class, "image.store.allocation.algorithm", "firstfitleastconsumed",
- "firstfitleastconsumed','random' : Order in which hosts within a cluster will be considered for VM/volume allocation", true, ConfigKey.Scope.Global );
+ static final ConfigKey<String> ImageStoreAllocationAlgorithm = new ConfigKey<String>(String.class, "image.store.allocation.algorithm", "Advanced", "firstfitleastconsumed",
Review Comment:
```suggestion
static final ConfigKey<String> ImageStoreAllocationAlgorithm = new ConfigKey<>(String.class, "image.store.allocation.algorithm", "Advanced", "firstfitleastconsumed",
```
##########
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java:
##########
@@ -61,8 +61,8 @@ public interface SAML2AuthManager extends PluggableAPIAuthenticator, PluggableSe
public static final ConfigKey<String> SAMLDefaultIdentityProviderId = new ConfigKey<String>("Advanced", String.class, "saml2.default.idpid", "https://openidp.feide.no",
"The default IdP entity ID to use only in case of multiple IdPs", true);
- public static final ConfigKey<String> SAMLSignatureAlgorithm = new ConfigKey<String>("Advanced", String.class, "saml2.sigalg", "SHA1",
- "The algorithm to use to when signing a SAML request. Default is SHA1, allowed algorithms: SHA1, SHA256, SHA384, SHA512", true);
+ public static final ConfigKey<String> SAMLSignatureAlgorithm = new ConfigKey<String>(String.class, "saml2.sigalg", "Advanced", "SHA1",
Review Comment:
```suggestion
public static final ConfigKey<String> SAMLSignatureAlgorithm = new ConfigKey<>(String.class, "saml2.sigalg", "Advanced", "SHA1",
```
##########
test/integration/smoke/test_global_settings.py:
##########
@@ -75,3 +75,120 @@ def tearDown(self):
updateConfigurationCmd.scopename = "zone"
updateConfigurationCmd.scopeid = 1
self.apiClient.updateConfiguration(updateConfigurationCmd)
+
+class TestListConfigurations(cloudstackTestCase):
+ """
+ Test to list configurations (global settings)
+ """
+ @classmethod
+ def setUpClass(cls):
+ cls.apiclient = cls.testClient.getApiClient()
+ cls._cleanup = []
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
Review Comment:
```suggestion
def tearDownClass(cls):
super(TestListConfigurations, cls).tearDownClass()
```
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -559,19 +563,58 @@ public ServiceOfferingResponse createServiceOfferingResponse(ServiceOffering off
public ConfigurationResponse createConfigurationResponse(Configuration cfg) {
ConfigurationResponse cfgResponse = new ConfigurationResponse();
cfgResponse.setCategory(cfg.getCategory());
+ Pair<String, String> configGroupAndSubGroup = _configMgr.getConfigurationGroupAndSubGroup(cfg.getName());
+ cfgResponse.setGroup(configGroupAndSubGroup.first());
+ cfgResponse.setSubGroup(configGroupAndSubGroup.second());
cfgResponse.setDescription(cfg.getDescription());
cfgResponse.setName(cfg.getName());
if (cfg.isEncrypted()) {
cfgResponse.setValue(DBEncryptionUtil.encrypt(cfg.getValue()));
} else {
cfgResponse.setValue(cfg.getValue());
}
+ cfgResponse.setDefaultValue(cfg.getDefaultValue());
cfgResponse.setIsDynamic(cfg.isDynamic());
+ cfgResponse.setComponent(cfg.getComponent());
+ if (cfg.getParent() != null) {
+ cfgResponse.setParent(cfg.getParent());
+ }
+ cfgResponse.setDisplayText(cfg.getDisplayText());
+ cfgResponse.setType(_configMgr.getConfigurationType(cfg.getName()));
+ if (cfg.getOptions() != null) {
+ cfgResponse.setOptions(cfg.getOptions());
+ }
cfgResponse.setObjectName("configuration");
return cfgResponse;
}
+ @Override
+ public ConfigurationGroupResponse createConfigurationGroupResponse(ConfigurationGroup cfgGroup) {
+ ConfigurationGroupResponse cfgGroupResponse = new ConfigurationGroupResponse();
+ cfgGroupResponse.setGroupName(cfgGroup.getName());
+ cfgGroupResponse.setDescription(cfgGroup.getDescription());
+ cfgGroupResponse.setPrecedence(cfgGroup.getPrecedence());
+
+ List<? extends ConfigurationSubGroup> subgroups = _configMgr.getConfigurationSubGroups(cfgGroup.getId());
Review Comment:
if possible
```suggestion
List<ConfigurationSubGroup> subgroups = _configMgr.getConfigurationSubGroups(cfgGroup.getId());
```
##########
test/integration/smoke/test_global_settings.py:
##########
@@ -75,3 +75,120 @@ def tearDown(self):
updateConfigurationCmd.scopename = "zone"
updateConfigurationCmd.scopeid = 1
self.apiClient.updateConfiguration(updateConfigurationCmd)
+
+class TestListConfigurations(cloudstackTestCase):
+ """
+ Test to list configurations (global settings)
+ """
+ @classmethod
+ def setUpClass(cls):
+ cls.apiclient = cls.testClient.getApiClient()
+ cls._cleanup = []
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ def setUp(self):
+ self.apiClient = self.testClient.getApiClient()
+ self.cleanup = []
+
+ def tearDown(self):
+ """
+ Revert any configuration changes
+ """
+ try:
+ cleanup_resources(self.apiclient, self.cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
Review Comment:
```suggestion
super(TestListConfigurations, self).tearDown()
```
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2214,6 +2250,20 @@ public Pair<List<? extends Configuration>, Integer> searchForConfigurations(fina
return new Pair<List<? extends Configuration>, Integer>(result.first(), result.second());
}
+ @Override
+ public Pair<List<? extends ConfigurationGroup>, Integer> listConfigurationGroups(ListCfgGroupsByCmd cmd) {
+ final Filter searchFilter = new Filter(ConfigurationGroupVO.class, "precedence", true, null, null);
+ final SearchCriteria<ConfigurationGroupVO> sc = _configGroupDao.createSearchCriteria();
+
+ final String groupName = cmd.getGroupName();
+ if (StringUtils.isNotBlank(groupName)) {
+ sc.addAnd("name", SearchCriteria.Op.EQ, groupName);
+ }
+
+ final Pair<List<ConfigurationGroupVO>, Integer> result = _configGroupDao.searchAndCount(sc, searchFilter);
+ return new Pair<List<? extends ConfigurationGroup>, Integer>(result.first(), result.second());
Review Comment:
```suggestion
return new Pair<List<ConfigurationGroup>, Integer>(result.first(), result.second());
```
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2214,6 +2250,20 @@ public Pair<List<? extends Configuration>, Integer> searchForConfigurations(fina
return new Pair<List<? extends Configuration>, Integer>(result.first(), result.second());
}
+ @Override
+ public Pair<List<? extends ConfigurationGroup>, Integer> listConfigurationGroups(ListCfgGroupsByCmd cmd) {
Review Comment:
```suggestion
public Pair<List<ConfigurationGroup>, Integer> listConfigurationGroups(ListCfgGroupsByCmd cmd) {
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1345908880
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180308682
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1939)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1314958507
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1314955257
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180300294
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1272246144
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1272246292
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1272290476
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182823788
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180626655
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1346925018
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063488449
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/dao/ConfigurationSubGroupDaoImpl.java:
##########
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config.dao;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.function.BiPredicate;
+
+import org.apache.cloudstack.framework.config.impl.ConfigurationSubGroupVO;
+import org.apache.commons.lang3.StringUtils;
+import org.springframework.stereotype.Component;
+
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+public class ConfigurationSubGroupDaoImpl extends GenericDaoBase<ConfigurationSubGroupVO, Long> implements ConfigurationSubGroupDao {
+
+ final SearchBuilder<ConfigurationSubGroupVO> nameSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> groupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> nameAndGroupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> keywordSearch;
+
+ public ConfigurationSubGroupDaoImpl() {
+ super();
+
+ nameSearch = createSearchBuilder();
+ nameSearch.and("name", nameSearch.entity().getName(), SearchCriteria.Op.LIKE);
+ nameSearch.done();
+
+ groupSearch = createSearchBuilder();
+ groupSearch.and("groupId", groupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ groupSearch.done();
+
+ nameAndGroupSearch = createSearchBuilder();
+ nameAndGroupSearch.and("name", nameAndGroupSearch.entity().getName(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.and("groupId", nameAndGroupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.done();
+
+ keywordSearch = createSearchBuilder();
+ keywordSearch.and("keywords", keywordSearch.entity().getKeywords(), SearchCriteria.Op.NNULL);
+ keywordSearch.done();
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name);
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ @Override
+ public ConfigurationSubGroupVO startsWithName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name + "%");
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ private ConfigurationSubGroupVO matchKeywordBy(BiPredicate<String, String> matcher, List<ConfigurationSubGroupVO> configurationSubGroups, String keyword) {
+ for (ConfigurationSubGroupVO configurationSubGroup : configurationSubGroups) {
+ if (StringUtils.isBlank(configurationSubGroup.getKeywords())) {
+ continue;
+ }
+
+ String[] configKeywords = configurationSubGroup.getKeywords().split(",");
+ if (configKeywords.length <= 0) {
+ continue;
+ }
+
+ List<String> keywords = Arrays.asList(configKeywords);
+ for (String configKeyword : keywords) {
+ if (StringUtils.isNotBlank(configKeyword)) {
+ configKeyword = configKeyword.strip().toLowerCase();
+ if (matcher.test(keyword, configKeyword)) {
+ return configurationSubGroup;
+ }
+ }
+ }
+ }
+ return null;
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByKeyword(String keyword) {
Review Comment:
`findBy` again, too bad; `findAnywhere` as alternative
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/dao/ConfigurationSubGroupDaoImpl.java:
##########
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config.dao;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.function.BiPredicate;
+
+import org.apache.cloudstack.framework.config.impl.ConfigurationSubGroupVO;
+import org.apache.commons.lang3.StringUtils;
+import org.springframework.stereotype.Component;
+
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+public class ConfigurationSubGroupDaoImpl extends GenericDaoBase<ConfigurationSubGroupVO, Long> implements ConfigurationSubGroupDao {
+
+ final SearchBuilder<ConfigurationSubGroupVO> nameSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> groupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> nameAndGroupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> keywordSearch;
+
+ public ConfigurationSubGroupDaoImpl() {
+ super();
+
+ nameSearch = createSearchBuilder();
+ nameSearch.and("name", nameSearch.entity().getName(), SearchCriteria.Op.LIKE);
+ nameSearch.done();
+
+ groupSearch = createSearchBuilder();
+ groupSearch.and("groupId", groupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ groupSearch.done();
+
+ nameAndGroupSearch = createSearchBuilder();
+ nameAndGroupSearch.and("name", nameAndGroupSearch.entity().getName(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.and("groupId", nameAndGroupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.done();
+
+ keywordSearch = createSearchBuilder();
+ keywordSearch.and("keywords", keywordSearch.entity().getKeywords(), SearchCriteria.Op.NNULL);
+ keywordSearch.done();
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name);
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ @Override
+ public ConfigurationSubGroupVO startsWithName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name + "%");
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ private ConfigurationSubGroupVO matchKeywordBy(BiPredicate<String, String> matcher, List<ConfigurationSubGroupVO> configurationSubGroups, String keyword) {
+ for (ConfigurationSubGroupVO configurationSubGroup : configurationSubGroups) {
+ if (StringUtils.isBlank(configurationSubGroup.getKeywords())) {
+ continue;
+ }
+
+ String[] configKeywords = configurationSubGroup.getKeywords().split(",");
+ if (configKeywords.length <= 0) {
+ continue;
+ }
+
+ List<String> keywords = Arrays.asList(configKeywords);
+ for (String configKeyword : keywords) {
+ if (StringUtils.isNotBlank(configKeyword)) {
+ configKeyword = configKeyword.strip().toLowerCase();
+ if (matcher.test(keyword, configKeyword)) {
+ return configurationSubGroup;
+ }
+ }
+ }
+ }
+ return null;
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByKeyword(String keyword) {
Review Comment:
`findBy` again, too bad; `findAnywhere` as alternative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063482195
##########
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##########
@@ -993,3 +993,246 @@ BEGIN
DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' ADD KEY ') ; SET @ddl = CONCAT(@ddl, ' ', in_index_name); SET @ddl = CONCAT(@ddl, ' ', in_key_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE stmt; END;
CALL `cloud`.`IDEMPOTENT_ADD_KEY`('i_user_ip_address_state','user_ip_address', '(state)');
+--
+-- Update Configuration Groups and Subgroups
+--
Review Comment:
there is, `IDEMPOTENT_ADD_COLUMN` , but soit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1373455002
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1396207202
<b>Trillian test result (tid-5893)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40857 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5893-kvm-centos7.zip
Smoke tests completed. 102 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.66 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.14 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.28 | test_primary_storage.py
test_01_non_strict_host_anti_affinity | `Failure` | 113.93 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 80.15 | test_nonstrict_affinity_group.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 52.75 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3.32 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 4.25 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 6.32 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 45.20 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 4.27 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 4.27 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 4.28 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 3.21 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 98.60 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 156.30 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 268.00 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 136.68 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.78 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.83 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398273954
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: debian. SL-JID 5343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1378312277
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1379806646
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1408483436
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1101261290
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106717834
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|VirtualMachineGuru|12|0|2|0|4|0|
|NetworkOrchestrationService|0|101|0|0|0|10|
|ConnectedAgentAttache|149|0|20|0|40|0|
|VirtualMachineManagerImpl|15610|0|1498|0|3072|0|
|NetworkOrchestrator|9722|0|1198|0|1914|0|
||
|HostDaoImpl|4946|0|180|0|797|0|
|SystemVmTemplateRegistration|1773|0|86|0|376|0|
|Upgrade41520to41600|262|17|16|0|62|5|
|Upgrade41610to41700|324|7|30|0|93|2|
|DomainRouterVO|109|50|0|0|38|14|
|ConsoleProxyDaoImpl|635|0|20|0|144|0|
||
|DomainRouterDaoImpl|1604|0|22|0|228|0|
||
||
||
||
||
||
|CloudStackContextLoaderListener|71|0|2|0|19|0|
|LibvirtComputingResource|8927|1961|1096|140|1992|444|
|LibvirtStartCommandWrapper|35|276|15|21|8|68|
||
|VmwareResource|20060|0|2242|0|4330|0|
|CitrixResourceBase|14566|557|1452|34|3160|122|
|CitrixCheckSshCommandWrapper|15|50|3|3|3|14|
|CitrixNetworkElementCommandWrapper|0|10|0|0|0|3|
|CitrixRebootRouterCommandWrapper|27|25|3|1|5|7|
|CitrixStartCommandWrapper|585|62|71|1|96|16|
|KubernetesClusterManagerImpl|4724|0|480|0|760|0|
|KubernetesClusterActionWorker|1540|0|114|0|281|0|
|KubernetesClusterResourceModifierActionWorker|1843|0|140|0|325|0|
||
|MetricsServiceImpl|1673|0|98|0|337|0|
|ClusterMetricsResponse|523|0|132|0|60|0|
|VmMetricsResponse|142|0|22|0|25|0|
|VolumeMetricsResponse|69|0|8|0|10|0|
|ZoneMetricsResponse|501|0|126|0|56|0|
||
||
||
|DomainChecker|1131|0|282|0|226|0|
|ApiDBUtils|2367|0|210|0|590|0|
|ApiServer|2863|112|346|0|672|14|
|ResponseObjectTypeAdapter|150|8|12|0|35|2|
|QueryManagerImpl|14153|0|1242|0|2389|0|
|DomainRouterJoinDaoImpl|761|0|72|0|184|0|
|DomainRouterJoinVO|234|0|0|0|79|0|
|ConsoleProxyManagerImpl|3667|0|423|0|720|0|
|LibvirtServerDiscoverer|988|0|116|0|218|0|
|NetworkServiceImpl|13372|0|1862|0|2548|0|
||
|NetworkHelperImpl|2019|0|264|0|428|0|
|VirtualNetworkApplianceManagerImpl|7564|0|778|0|1517|0|
|VpcManagerImpl|6870|0|758|0|1311|0|
|ConfigurationServerImpl|2075|0|178|0|499|0|
||
|ManagementServerImpl|11947|0|1064|0|2386|0|
|StatsCollector|1875|0|104|0|308|0|
|StorageManagerImpl|8547|0|974|0|1704|0|
|UserVmManagerImpl|20798|0|2566|0|3869|0|
|CAManagerImpl|611|0|72|0|125|0|
||
||
|MockNetworkManagerImpl|485|0|22|0|83|0|
||
|SecondaryStorageManagerImpl|3494|149|343|11|623|32|
||
||
||
||
||
||
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106811175
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1445)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106689669
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108737987
<b>Trillian test result (tid-4019)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44957 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t4019-kvm-centos7.zip
Smoke tests completed. 93 look OK, 3 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.65 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.15 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.27 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 30.99 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 73.18 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 38.20 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 79.55 | test_kubernetes_clusters.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.96 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097579432
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097601322
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1370)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108009659
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1345910454
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r842784512
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgGroupsByCmd.java:
##########
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.config;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.ConfigurationGroupResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.config.ConfigurationGroup;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.Pair;
+
+@APICommand(name = ListCfgGroupsByCmd.APINAME, description = "Lists all configuration groups (primarily used for UI).", responseObject = ConfigurationGroupResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, since = "4.17.0")
+public class ListCfgGroupsByCmd extends BaseListCmd {
+ public static final Logger s_logger = Logger.getLogger(ListCfgGroupsByCmd.class.getName());
+
+ public static final String APINAME = "listConfigurationGroups";
+
+ // ///////////////////////////////////////////////////
+ // ////////////// API parameters /////////////////////
+ // ///////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.GROUP, type = CommandType.STRING, description = "lists configuration group by group name")
+ private String groupName;
+
+ // ///////////////////////////////////////////////////
+ // ///////////////// Accessors ///////////////////////
+ // ///////////////////////////////////////////////////
+
+ public String getGroupName() {
+ return groupName;
+ }
+
+ // ///////////////////////////////////////////////////
+ // ///////////// API Implementation///////////////////
+ // ///////////////////////////////////////////////////
+
+ @Override
+ public String getCommandName() {
+ return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+ }
+
+ @Override
+ public void execute() {
+ Pair<List<? extends ConfigurationGroup>, Integer> result = _mgr.listConfigurationGroups(this);
+ ListResponse<ConfigurationGroupResponse> response = new ListResponse<ConfigurationGroupResponse>();
+ List<ConfigurationGroupResponse> configGroupResponses = new ArrayList<ConfigurationGroupResponse>();
+ for (ConfigurationGroup cfgGroup : result.first()) {
+ ConfigurationGroupResponse cfgGroupResponse = _responseGenerator.createConfigurationGroupResponse(cfgGroup);
+ cfgGroupResponse.setObjectName("configurationgroup");
Review Comment:
Can include this into the `createConfigurationGroupResponse` method
##########
api/src/main/java/org/apache/cloudstack/api/response/ConfigurationResponse.java:
##########
@@ -52,6 +60,22 @@
@Param(description = "true if the configuration is dynamic")
private boolean isDynamic;
+ @SerializedName(ApiConstants.COMPONENT)
+ @Param(description = "the component of the configuration", since = "4.17.0")
+ private String component;
+
+ @SerializedName("parent")
Review Comment:
```suggestion
@SerializedName(ApiConstants.PARENT)
```
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/simulator/dao/MockConfigurationSubGroupDaoImpl.java:
##########
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.simulator.dao;
+
+import java.util.List;
+
+import org.springframework.stereotype.Component;
+
+import com.cloud.simulator.MockConfigurationSubGroupVO;
+import com.cloud.utils.db.GenericDaoBase;
+
+@Component
+public class MockConfigurationSubGroupDaoImpl extends GenericDaoBase<MockConfigurationSubGroupVO, Long> implements MockConfigurationSubGroupDao {
Review Comment:
And here
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/simulator/MockConfigurationGroupVO.java:
##########
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.simulator;
+
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.Table;
+
+import org.apache.cloudstack.api.InternalIdentity;
+
+@Entity
+@Table(name = "mockconfigurationgroup")
Review Comment:
Also here
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -7311,6 +7319,82 @@ public String getConfigComponentName() {
};
}
+ @Override
+ public String getConfigurationType(final String configName) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg == null) {
+ s_logger.error("Configuration " + configName + " not found");
+ return Configuration.ValueType.String.name();
+ }
+
+ if (weightBasedParametersForValidation.contains(configName)) {
+ return Configuration.ValueType.Range.name();
+ }
+
+ Class<?> type = null;
+ final Config c = Config.getConfig(configName);
+ if (c == null) {
+ s_logger.warn("Configuration " + configName + " no found. Perhaps moved to ConfigDepot");
+ final ConfigKey<?> configKey = _configDepot.get(configName);
+ if (configKey == null) {
+ s_logger.warn("Couldn't find configuration " + configName + " in ConfigDepot too.");
+ return null;
+ }
+ type = configKey.type();
+ } else {
+ type = c.getType();
+ }
+
+ return getInputType(type);
+ }
+
+ private String getInputType(Class<?> type) {
+ if (type == null) {
+ return Configuration.ValueType.String.name();
+ }
+
+ if (type == String.class || type == Character.class) {
+ return Configuration.ValueType.String.name();
+ } else if (type == Integer.class || type == Long.class || type == Short.class) {
+ return Configuration.ValueType.Number.name();
+ } else if (type == Float.class || type == Double.class) {
+ return Configuration.ValueType.Decimal.name();
+ } else if (type == Boolean.class) {
+ return Configuration.ValueType.Boolean.name();
+ //} else if (type == Date.class) {
Review Comment:
Can be removed
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java:
##########
@@ -83,4 +92,99 @@ public void updateSystemVmTemplates(Connection conn) {
throw new CloudRuntimeException("Failed to find / register SystemVM template(s)");
}
}
+
+ private void updateConfigurationGroups(Connection conn) {
+ LOG.debug("Updating configuration groups");
+ try {
+ String stmt = "SELECT name FROM `cloud`.`configuration`";
+ PreparedStatement pstmt = conn.prepareStatement(stmt);
+ ResultSet rs = pstmt.executeQuery();
+
+ while (rs.next()) {
+ String configName = rs.getString(1);
+ if (StringUtils.isBlank(configName)) {
+ continue;
+ }
+
+ // Get words from the dot notation in the configuration
+ String[] nameWords = configName.split("\\.");
+ if (nameWords.length <= 0) {
+ continue;
+ }
+
+ for (int index = 0; index < nameWords.length; index++) {
+ Pair<Long, Long> configGroupAndSubGroup = getConfigurationGroupAndSubGroup(conn, nameWords[index]);
+ if (configGroupAndSubGroup.first() != 1 && configGroupAndSubGroup.second() != 1) {
+ stmt = "UPDATE `cloud`.`configuration` SET group_id = ?, subgroup_id = ? WHERE name = ?";
+ pstmt = conn.prepareStatement(stmt);
+ pstmt.setLong(1, configGroupAndSubGroup.first());
Review Comment:
Can maybe add an NPE check before setting these parameters?
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java:
##########
@@ -83,4 +92,99 @@ public void updateSystemVmTemplates(Connection conn) {
throw new CloudRuntimeException("Failed to find / register SystemVM template(s)");
}
}
+
+ private void updateConfigurationGroups(Connection conn) {
+ LOG.debug("Updating configuration groups");
+ try {
+ String stmt = "SELECT name FROM `cloud`.`configuration`";
+ PreparedStatement pstmt = conn.prepareStatement(stmt);
+ ResultSet rs = pstmt.executeQuery();
+
+ while (rs.next()) {
+ String configName = rs.getString(1);
+ if (StringUtils.isBlank(configName)) {
+ continue;
+ }
+
+ // Get words from the dot notation in the configuration
+ String[] nameWords = configName.split("\\.");
+ if (nameWords.length <= 0) {
+ continue;
+ }
+
+ for (int index = 0; index < nameWords.length; index++) {
+ Pair<Long, Long> configGroupAndSubGroup = getConfigurationGroupAndSubGroup(conn, nameWords[index]);
+ if (configGroupAndSubGroup.first() != 1 && configGroupAndSubGroup.second() != 1) {
+ stmt = "UPDATE `cloud`.`configuration` SET group_id = ?, subgroup_id = ? WHERE name = ?";
+ pstmt = conn.prepareStatement(stmt);
+ pstmt.setLong(1, configGroupAndSubGroup.first());
+ pstmt.setLong(2, configGroupAndSubGroup.second());
+ pstmt.setString(3, configName);
+ pstmt.executeUpdate();
+ break;
+ }
+ }
+ }
+
+ rs.close();
+ pstmt.close();
+ LOG.debug("Successfully updated configuration groups.");
+ } catch (SQLException e) {
+ String errorMsg = "Failed to update configuration groups due to " + e.getMessage();
+ LOG.error(errorMsg, e);
+ throw new CloudRuntimeException(errorMsg, e);
+ }
+ }
+
+ private Pair<Long, Long> getConfigurationGroupAndSubGroup(Connection conn, String name) {
+ Long subGroupId = 1L;
+ Long groupId = 1L;
+ try {
+ String stmt = "SELECT id, group_id FROM `cloud`.`configuration_subgroup` WHERE name = ?";
+ PreparedStatement pstmt = conn.prepareStatement(stmt);
+ pstmt.setString(1, name);
+ ResultSet rs = pstmt.executeQuery();
+ if (rs.next()) {
+ subGroupId = rs.getLong(1);
+ groupId = rs.getLong(2);
+ } else {
+ // Try with keywords in the configuration subgroup
+ stmt = "SELECT id, group_id, keywords FROM `cloud`.`configuration_subgroup` WHERE keywords IS NOT NULL";
+ pstmt = conn.prepareStatement(stmt);
+ ResultSet rsConfigurationSubGroups = pstmt.executeQuery();
+ while (rsConfigurationSubGroups.next()) {
+ Long keywordsSubGroupId = rsConfigurationSubGroups.getLong(1);
+ Long keywordsGroupId = rsConfigurationSubGroups.getLong(2);
+ String keywords = rsConfigurationSubGroups.getString(3);
+ if(StringUtils.isBlank(keywords)) {
+ continue;
+ }
+
+ String[] configKeywords = keywords.split(",");
+ if (configKeywords.length <= 0) {
+ continue;
+ }
+
+ List<String> keywordsList = Arrays.asList(configKeywords);
+ for (String configKeyword : keywordsList) {
+ if (StringUtils.isNotBlank(configKeyword)) {
+ configKeyword = configKeyword.strip();
+ if (configKeyword.equalsIgnoreCase(name)) {
+ subGroupId = keywordsSubGroupId;
+ groupId = keywordsGroupId;
+ return new Pair<Long, Long>(groupId, subGroupId);
+ }
+ }
+ }
+ }
+ rsConfigurationSubGroups.close();
+ }
+ rs.close();
+ pstmt.close();
+ } catch (SQLException e) {
+ LOG.error("Failed to get configuration subgroup due to " + e.getMessage(), e);
Review Comment:
Should we do something else in case or errors apart from logging? What would be the consequences of having incorrect configurations (do not have group or/and subgroup correctly set)?
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/simulator/dao/MockConfigurationSubGroupDao.java:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.simulator.dao;
+
+import java.util.List;
+
+import com.cloud.simulator.MockConfigurationSubGroupVO;
+import com.cloud.utils.db.GenericDao;
+
+public interface MockConfigurationSubGroupDao extends GenericDao<MockConfigurationSubGroupVO, Long> {
Review Comment:
Same here, then your VO mock classes won't be needed
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/simulator/dao/MockConfigurationGroupDaoImpl.java:
##########
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.simulator.dao;
+
+import org.springframework.stereotype.Component;
+
+import com.cloud.simulator.MockConfigurationGroupVO;
+import com.cloud.utils.db.GenericDaoBase;
+
+@Component
+public class MockConfigurationGroupDaoImpl extends GenericDaoBase<MockConfigurationGroupVO, Long> implements MockConfigurationGroupDao {
Review Comment:
```suggestion
public class MockConfigurationGroupDaoImpl extends GenericDaoBase<ConfigurationGroupVO, Long> implements MockConfigurationGroupDao {
```
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/simulator/MockConfigurationSubGroupVO.java:
##########
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.simulator;
+
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.Table;
+
+import org.apache.cloudstack.api.InternalIdentity;
+
+@Entity
+@Table(name = "mockconfigurationsubgroup")
+public class MockConfigurationSubGroupVO implements InternalIdentity {
Review Comment:
This will create a new table for a mock? Won't needed IMO
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -7311,6 +7319,82 @@ public String getConfigComponentName() {
};
}
+ @Override
+ public String getConfigurationType(final String configName) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg == null) {
+ s_logger.error("Configuration " + configName + " not found");
+ return Configuration.ValueType.String.name();
+ }
+
+ if (weightBasedParametersForValidation.contains(configName)) {
+ return Configuration.ValueType.Range.name();
+ }
+
+ Class<?> type = null;
+ final Config c = Config.getConfig(configName);
+ if (c == null) {
+ s_logger.warn("Configuration " + configName + " no found. Perhaps moved to ConfigDepot");
+ final ConfigKey<?> configKey = _configDepot.get(configName);
+ if (configKey == null) {
+ s_logger.warn("Couldn't find configuration " + configName + " in ConfigDepot too.");
+ return null;
+ }
+ type = configKey.type();
+ } else {
+ type = c.getType();
+ }
+
+ return getInputType(type);
+ }
+
+ private String getInputType(Class<?> type) {
+ if (type == null) {
+ return Configuration.ValueType.String.name();
+ }
+
+ if (type == String.class || type == Character.class) {
+ return Configuration.ValueType.String.name();
+ } else if (type == Integer.class || type == Long.class || type == Short.class) {
+ return Configuration.ValueType.Number.name();
+ } else if (type == Float.class || type == Double.class) {
+ return Configuration.ValueType.Decimal.name();
+ } else if (type == Boolean.class) {
+ return Configuration.ValueType.Boolean.name();
+ //} else if (type == Date.class) {
+ // return Configuration.InputType.Date.name();
+ } else {
+ return Configuration.ValueType.String.name();
+ }
+ }
+
+ @Override
+ public Pair<String, String> getConfigurationGroupAndSubGroup(final String configName) {
+ if (StringUtils.isNotBlank(configName)) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg != null) {
+ ConfigurationSubGroupVO configSubGroup = _configSubGroupDao.findById(cfg.getSubGroupId());
+ if (configSubGroup != null) {
+ String subGroupName = configSubGroup.getName();
+ ConfigurationGroupVO configGroup = _configGroupDao.findById(configSubGroup.getGroupId());
+ String groupName = configGroup != null ? configGroup.getName() : "Miscellaneous";
+ return new Pair<String, String>(groupName, subGroupName);
+ }
+ } else {
+ s_logger.warn("Configuration " + configName + " not found");
+ }
+ }
+
+ s_logger.debug("Returning default configuration group for config: " + configName);
Review Comment:
What about the case configName is null or empty? Should this still return a pair or fail?
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -7311,6 +7319,82 @@ public String getConfigComponentName() {
};
}
+ @Override
+ public String getConfigurationType(final String configName) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg == null) {
+ s_logger.error("Configuration " + configName + " not found");
+ return Configuration.ValueType.String.name();
+ }
+
+ if (weightBasedParametersForValidation.contains(configName)) {
+ return Configuration.ValueType.Range.name();
+ }
+
+ Class<?> type = null;
+ final Config c = Config.getConfig(configName);
+ if (c == null) {
+ s_logger.warn("Configuration " + configName + " no found. Perhaps moved to ConfigDepot");
+ final ConfigKey<?> configKey = _configDepot.get(configName);
+ if (configKey == null) {
+ s_logger.warn("Couldn't find configuration " + configName + " in ConfigDepot too.");
+ return null;
Review Comment:
Not sure why in this case null is returned, but when cfg == null then ValueType.String is returned, can maybe add a javadoc to this method?
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -655,3 +653,107 @@ INSERT INTO `cloud`.`user_vm_details`(`vm_id`, `name`, `value`)
ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN `security_group_id` bigint unsigned DEFAULT NULL,
ADD CONSTRAINT `fk_kubernetes_cluster__security_group_id` FOREIGN KEY `fk_kubernetes_cluster__security_group_id`(`security_group_id`) REFERENCES `security_group`(`id`) ON DELETE CASCADE;
+ALTER TABLE `cloud`.`configuration` ADD COLUMN `group_id` bigint(20) unsigned DEFAULT '1' COMMENT 'group id this configuration belongs to';
+ALTER TABLE `cloud`.`configuration` ADD COLUMN `subgroup_id` bigint(20) unsigned DEFAULT '1' COMMENT 'subgroup id this configuration belongs to';
+ALTER TABLE `cloud`.`configuration` ADD COLUMN `parent` VARCHAR(255) DEFAULT NULL COMMENT 'name of the parent configuration if this depends on it';
+ALTER TABLE `cloud`.`configuration` ADD COLUMN `display_text` VARCHAR(255) DEFAULT NULL COMMENT 'Short text about configuration to display to the users';
+
+CREATE TABLE `cloud`.`configuration_group` (
+ `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+ `name` varchar(255) NOT NULL COMMENT 'name of the configuration group',
+ `description` varchar(1024) DEFAULT NULL COMMENT 'description of the configuration group',
+ `precedence` bigint(20) unsigned DEFAULT '999' COMMENT 'precedence for the configuration group',
+ PRIMARY KEY (`id`),
+ UNIQUE KEY (`name`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+CREATE TABLE `cloud`.`configuration_subgroup` (
+ `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+ `name` varchar(255) NOT NULL COMMENT 'name of the configuration subgroup',
+ `keywords` varchar(4096) DEFAULT NULL COMMENT 'comma-separated keywords for the configuration subgroup',
+ `precedence` bigint(20) unsigned DEFAULT '999' COMMENT 'precedence for the configuration subgroup',
+ `group_id` bigint(20) unsigned NOT NULL COMMENT 'configuration group id',
+ PRIMARY KEY (`id`),
+ UNIQUE KEY (`name`, `group_id`),
+ CONSTRAINT `fk_configuration_subgroup__group_id` FOREIGN KEY (`group_id`) REFERENCES `configuration_group` (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`configuration_group` AUTO_INCREMENT=1;
+
+INSERT INTO `cloud`.`configuration_group` (`name`, `description`, `precedence`) VALUES ('Miscellaneous', 'Miscellaneous configuration', 999);
Review Comment:
Should we consider idempotent changes on these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r847073231
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -7311,6 +7319,82 @@ public String getConfigComponentName() {
};
}
+ @Override
+ public String getConfigurationType(final String configName) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg == null) {
+ s_logger.error("Configuration " + configName + " not found");
+ return Configuration.ValueType.String.name();
+ }
+
+ if (weightBasedParametersForValidation.contains(configName)) {
+ return Configuration.ValueType.Range.name();
+ }
+
+ Class<?> type = null;
+ final Config c = Config.getConfig(configName);
+ if (c == null) {
+ s_logger.warn("Configuration " + configName + " no found. Perhaps moved to ConfigDepot");
+ final ConfigKey<?> configKey = _configDepot.get(configName);
+ if (configKey == null) {
+ s_logger.warn("Couldn't find configuration " + configName + " in ConfigDepot too.");
+ return null;
Review Comment:
default is String, update the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1094898034
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1094797371
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182871472
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1948)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182905242
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180303745
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180302725
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106831280
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106693487
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1198139710
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [21.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1207648539
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 3927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315084498
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1346919632
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1369619488
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [61 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [21.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "davidjumani (via GitHub)" <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1408696825
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371859987
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371895033
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371796912
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1383931868
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1381328460
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1399143682
<b>Trillian test result (tid-5927)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5927-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1094708175
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097635794
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1371)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
utchoang commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r850037119
##########
ui/src/views/setting/AllConfigurationsTab.vue:
##########
@@ -0,0 +1,280 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div>
+ <div class="config-row-element">
+ <a-table
+ class="config-list-view"
+ size="small"
+ style="max-height: 700px; overflow-y: auto"
+ :loading="loading || tabLoading"
+ :columns="columns"
+ :items="items"
+ :dataSource="items"
+ :columnKeys="columnKeys"
+ :rowKey="record => record.name"
+ @refresh="this.fetchData">
+ <template #description="{ record }">
+ {{ record.description }}
+ </template>
+ <template #value="{ record }">
+ <ConfigurationValue :configrecord="record" :loading="loading" />
+ </template>
+ </a-table>
+ <a-pagination
+ class="config-row-element"
+ style="margin-top: 10px"
+ size="small"
+ :current="page"
+ :pageSize="pageSize"
+ :total="itemCount"
+ :showTotal="total => `${$t('label.showing')} ${Math.min(total, 1+((page-1)*pageSize))}-${Math.min(page*pageSize, total)} ${$t('label.of')} ${total} ${$t('label.items')}`"
+ :pageSizeOptions="pageSizeOptions"
+ @change="changePage"
+ @showSizeChange="changePageSize"
+ showSizeChanger
+ showQuickJumper>
+ <template #buildOptionText="props">
+ <span>{{ props.value }} / {{ $t('label.page') }}</span>
+ </template>
+ </a-pagination>
+ </div>
+ </div>
+</template>
+
+<script>
+import { api } from '@/api'
+import { genericCompare } from '@/utils/sort.js'
+import ListView from '@/components/view/ListView'
+import TooltipButton from '@/components/widgets/TooltipButton'
+import ConfigurationValue from './ConfigurationValue'
+
+export default {
+ components: {
+ ListView,
+ TooltipButton,
+ ConfigurationValue
+ },
+ name: 'AllConfigurationsTab',
+ props: {
+ loading: {
+ type: Boolean,
+ required: true
+ }
+ },
+ data () {
+ return {
+ apiName: 'listConfigurations',
+ columns: [
+ {
+ title: 'Name',
+ dataIndex: 'name',
+ slots: { customRender: 'name' },
+ sorter: function (a, b) { return genericCompare(a[this.dataIndex] || '', b[this.dataIndex] || '') }
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ slots: { customRender: 'description' },
+ sorter: function (a, b) { return genericCompare(a[this.dataIndex] || '', b[this.dataIndex] || '') },
+ width: '35%'
+ },
+ {
+ title: 'Category',
+ dataIndex: 'category',
+ slots: { customRender: 'category' },
+ sorter: function (a, b) { return genericCompare(a[this.dataIndex] || '', b[this.dataIndex] || '') }
+ },
+ {
+ title: 'Value',
+ dataIndex: 'value',
+ slots: { customRender: 'value' }
+ }
+ ],
+ columnKeys: this.columns,
+ items: [],
+ itemCount: 0,
+ page: 1,
+ pageSize: this.$store.getters.defaultListViewPageSize,
+ editableValueKey: null,
+ editableValue: '',
+ tabLoading: false,
+ filter: ''
+ }
+ },
+ created () {
+ this.fetchData()
+ },
+ watch: {
+ '$route' (to, from) {
+ if (to.fullPath !== from.fullPath && !to.fullPath.includes('action/')) {
+ if ('page' in to.query) {
+ this.page = Number(to.query.page)
+ this.pageSize = Number(to.query.pagesize)
+ } else {
+ this.page = 1
+ }
+ this.itemCount = 0
+ this.fetchData()
+ }
+ },
+ '$i18n.locale' (to, from) {
+ if (to !== from) {
+ this.fetchData()
+ }
+ }
+ },
+ computed: {
+ pageSizeOptions () {
+ var sizes = [20, 50, 100, 200, this.$store.getters.defaultListViewPageSize]
+ return [...new Set(sizes)].sort(function (a, b) {
+ return a - b
+ }).map(String)
+ }
+ },
+ methods: {
+ fetchData (callback) {
+ this.tabLoading = true
+ const params = {
+ listAll: true
+ }
+ if (Object.keys(this.$route.query).length > 0) {
+ if ('page' in this.$route.query) {
+ this.page = Number(this.$route.query.page)
+ }
+ if ('pagesize' in this.$route.query) {
+ this.pagesize = Number(this.$route.query.pagesize)
+ }
+ Object.assign(params, this.$route.query)
+ }
+ if (this.filter) {
+ params.keyword = this.filter
+ }
+ this.columnKeys = [...new Set(this.columnKeys)]
+ this.columnKeys.sort(function (a, b) {
+ if (a === 'name' && b !== 'name') { return -1 }
+ if (a < b) { return -1 }
+ if (a > b) { return 1 }
+ return 0
+ })
+ if ('listview' in this.$refs && this.$refs.listview) {
+ this.$refs.listview.resetSelection()
+ }
+ params.page = this.page
+ params.pagesize = this.pageSize
+ api('listConfigurations', params).then(response => {
+ this.items = response.listconfigurationsresponse.configuration
+ if (!this.items || this.items.length === 0) {
+ this.items = []
+ }
+ this.itemCount = response.listconfigurationsresponse.count
+ }).catch(error => {
+ console.error(error)
+ this.$message.error(this.$t('message.error.loading.setting'))
+ }).finally(() => {
+ this.tabLoading = false
+ if (!callback) return
+ callback()
+ })
+ },
+ changePage (page, pageSize) {
+ const query = Object.assign({}, this.$route.query)
+ query.page = page
+ query.pagesize = pageSize
+ this.$router.push({ query })
+ },
+ changePageSize (currentPage, pageSize) {
+ const query = Object.assign({}, this.$route.query)
+ query.page = currentPage
+ query.pagesize = pageSize
+ this.$router.push({ query })
+ }
+ }
+}
+</script>
+
+<style scoped lang="scss">
+ .list {
+ clear:both;
+ }
+ .editable-value {
+
+ @media (min-width: 760px) {
+ text-align: right;
+ margin-left: 40px;
+ margin-right: -40px;
+ }
+
+ }
+ .item {
+ display: flex;
+ flex-direction: column;
+ align-items: stretch;
+
+ @media (min-width: 760px) {
+ flex-direction: row;
+ }
+
+ &__content {
+ width: 100%;
+ display: block;
+ word-break: break-all;
+
+ @media (min-width: 760px) {
+ width: auto;
+ }
+
+ }
+
+ }
+ .action {
+ margin-top: 20px;
+ margin-left: -12px;
+
+ @media (min-width: 480px) {
+ margin-left: -24px;
+ }
+
+ @media (min-width: 760px) {
+ margin-top: 0;
+ margin-left: 0;
+ }
+
+ }
+
+ .value {
+ margin-top: 20px;
+
+ @media (min-width: 760px) {
+ margin-top: 0;
+ }
+
+ }
+
+ .config-row-element {
+ margin-bottom: 10px;
Review Comment:
```suggestion
margin-bottom: 10px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102112129
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102928157
<b>Trillian test result (tid-3932)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30858 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t3932-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106833102
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106694220
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106691298
UI build: :heavy_multiplication_x:
(SL-JID-1443)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108305795
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180346072
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180305500
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182847238
<b>Trillian Build Failed (tid-4501)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182862679
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1198139606
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315085613
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375123050
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1373513432
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1198076853
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1251914770
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1251950869
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1252934713
<b>Trillian test result (tid-4933)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43900 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t4933-kvm-centos7.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1259073986
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1380866390
<b>Trillian test result (tid-5806)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5806-kvm-centos7.zip
Smoke tests completed. 102 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.70 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.16 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.28 | test_primary_storage.py
test_01_non_strict_host_anti_affinity | `Failure` | 111.85 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 81.10 | test_nonstrict_affinity_group.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 35.02 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 60.49 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 42.03 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 37.98 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 125.21 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 163.94 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 273.88 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 144.15 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 44.97 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.88 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398202844
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400152793
@davidjumani can you have a look at this conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1379836021
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180345434
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [51 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [22.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182863603
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
utchoang commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r975142044
##########
ui/src/views/setting/ConfigurationTab.vue:
##########
@@ -0,0 +1,142 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-back-top />
+ <a-spin :spinning="tabLoading">
+ <a-table
+ size="small"
+ :showHeader="false"
+ :columns="columns"
+ :dataSource="configdata.filter(config => !config.parent)"
+ :rowKey="record => record.name"
+ :pagination="false"
+ :rowClassName="getRowClassName"
+ style="overflow-y: auto; margin-left: 10px" >
+
+ <template #displaytext="{ record }">
+ <ConfigurationRow :config="configdata" :configrecord="record" :loading="tabLoading" />
+ </template>
+ </a-table>
+ </a-spin>
+</template>
+
+<script>
+import { api } from '@/api'
+import ConfigurationRow from './ConfigurationRow'
+
+export default {
+ name: 'ConfigurationTab',
+ components: {
+ ConfigurationRow
+ },
+ props: {
+ group: {
+ type: String,
+ required: true
+ },
+ subgroup: {
+ type: String,
+ required: false
+ },
+ parent: {
+ type: String,
+ required: false
+ },
+ loading: {
+ type: Boolean,
+ default: false
+ }
+ },
+ data () {
+ return {
+ tabLoading: this.loading,
+ columns: [
+ {
+ title: 'Display Text',
+ dataIndex: 'displaytext',
+ slots: { customRender: 'displaytext' }
+ }
+ ],
+ apiName: 'listConfigurations',
+ configdata: []
+ }
+ },
+ created () {
+ this.fetchConfigurationDataByGroup({ group: this.group, subgroup: this.subgroup })
+ },
+ watch: {
+ group: {
+ deep: true,
+ handler (newItem, oldItem) {
+ if (!newItem) {
+ return
+ }
+ this.fetchConfigurationDataByGroup({ group: this.group, subgroup: this.subgroup })
+ }
+ },
+ subgroup: {
+ deep: true,
+ handler (newItem, oldItem) {
+ if (!newItem) {
+ return
+ }
+ this.fetchConfigurationDataByGroup({ group: this.group, subgroup: this.subgroup })
+ }
+ },
+ '$route' (to, from) {
+ if (to.fullPath !== from.fullPath && !to.fullPath.includes('action/')) {
+ if ('name' in to.query) {
+ this.fetchConfigurationDataByGroup({ group: this.group, subgroup: this.subgroup, name: to.query.name })
+ } else {
+ this.fetchConfigurationDataByGroup({ group: this.group, subgroup: this.subgroup })
+ }
+ }
+ },
+ '$i18n.locale' (to, from) {
+ if (to !== from) {
+ this.fetchConfigurationDataByGroup({ group: this.group, subgroup: this.subgroup })
+ }
+ }
+ },
+ methods: {
+ fetchConfigurationDataByGroup (params = {}) {
+ this.tabLoading = true
+ params.pagesize = -1
+ console.log('group name: ' + this.group)
+ api('listConfigurations', params).then(response => {
+ this.configdata = response.listconfigurationsresponse.configuration
+ if (!this.configdata || this.configdata.length === 0) {
Review Comment:
Similar `this.configdata = response?.listconfigurationsresponse?.configuration || []`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1199194140
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182795288
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182794880
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182819728
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1207450874
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106738170
<b>Trillian Build Failed (tid-3999)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108302602
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1458)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108293901
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108347247
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1280676969
@DaanHoogland there are still some minor bits to fix on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1314955969
@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1314983212
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315910941
<b>Trillian test result (tid-84)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40974 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t84-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 403.67 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 745.88 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 1280.15 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 545.21 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1096468506
> Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?
@sureshanaparti ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1373514370
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386753153
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by github-actions.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1399998707
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398434261
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1408697685
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1346918636
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1369560071
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1369469126
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [61 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [21.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371907294
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [77 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [18.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108295448
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1108010001
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
utchoang commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r858149968
##########
ui/src/views/setting/AllConfigurationsTab.vue:
##########
@@ -0,0 +1,290 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="tabLoading">
+ <div class="config-row-element">
+ <a-table
+ class="config-list-view"
+ size="small"
+ :pagination="false"
+ :loading="tabLoading"
+ :columns="columns"
+ :items="items"
+ :dataSource="items"
+ :columnKeys="columnKeys"
+ :rowKey="record => record.name"
+ :rowClassName="getRowClassName"
+ @refresh="this.fetchConfigData">
+
+ <template #name="{ record }">
+ <b> {{record.displaytext }} </b> {{ ' (' + record.name + ')' }} <br/> {{ record.description }}
+ </template>
+ <template #value="{ record }">
+ <ConfigurationValue :configrecord="record" :loading="tabLoading" />
+ </template>
+ </a-table>
+ <a-pagination
+ class="config-row-element"
+ style="margin-top: 10px"
+ size="small"
+ :current="page"
+ :pageSize="pageSize"
+ :total="itemCount"
+ :showTotal="total => `${$t('label.showing')} ${Math.min(total, 1+((page-1)*pageSize))}-${Math.min(page*pageSize, total)} ${$t('label.of')} ${total} ${$t('label.items')}`"
+ :pageSizeOptions="pageSizeOptions"
+ @change="changePage"
+ @showSizeChange="changePageSize"
+ showSizeChanger
+ showQuickJumper>
+ <template #buildOptionText="props">
+ <span>{{ props.value }} / {{ $t('label.page') }}</span>
+ </template>
+ </a-pagination>
+ </div>
+ </a-spin>
+</template>
+
+<script>
+import { api } from '@/api'
+import { genericCompare } from '@/utils/sort.js'
+import ListView from '@/components/view/ListView'
+import TooltipButton from '@/components/widgets/TooltipButton'
+import ConfigurationValue from './ConfigurationValue'
+
+export default {
+ components: {
+ ListView,
+ TooltipButton,
+ ConfigurationValue
+ },
+ name: 'AllConfigurationsTab',
+ props: {
+ loading: {
+ type: Boolean,
+ required: true
+ }
+ },
+ data () {
+ return {
+ apiName: 'listConfigurations',
+ columns: [
+ {
+ title: 'Name',
Review Comment:
```suggestion
title: this.$t('label.name'),
```
##########
ui/src/views/setting/AllConfigurationsTab.vue:
##########
@@ -0,0 +1,290 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="tabLoading">
+ <div class="config-row-element">
+ <a-table
+ class="config-list-view"
+ size="small"
+ :pagination="false"
+ :loading="tabLoading"
+ :columns="columns"
+ :items="items"
+ :dataSource="items"
+ :columnKeys="columnKeys"
+ :rowKey="record => record.name"
+ :rowClassName="getRowClassName"
+ @refresh="this.fetchConfigData">
+
+ <template #name="{ record }">
+ <b> {{record.displaytext }} </b> {{ ' (' + record.name + ')' }} <br/> {{ record.description }}
+ </template>
+ <template #value="{ record }">
+ <ConfigurationValue :configrecord="record" :loading="tabLoading" />
+ </template>
+ </a-table>
+ <a-pagination
+ class="config-row-element"
+ style="margin-top: 10px"
+ size="small"
+ :current="page"
+ :pageSize="pageSize"
+ :total="itemCount"
+ :showTotal="total => `${$t('label.showing')} ${Math.min(total, 1+((page-1)*pageSize))}-${Math.min(page*pageSize, total)} ${$t('label.of')} ${total} ${$t('label.items')}`"
+ :pageSizeOptions="pageSizeOptions"
+ @change="changePage"
+ @showSizeChange="changePageSize"
+ showSizeChanger
+ showQuickJumper>
+ <template #buildOptionText="props">
+ <span>{{ props.value }} / {{ $t('label.page') }}</span>
+ </template>
+ </a-pagination>
+ </div>
+ </a-spin>
+</template>
+
+<script>
+import { api } from '@/api'
+import { genericCompare } from '@/utils/sort.js'
+import ListView from '@/components/view/ListView'
+import TooltipButton from '@/components/widgets/TooltipButton'
+import ConfigurationValue from './ConfigurationValue'
+
+export default {
+ components: {
+ ListView,
+ TooltipButton,
+ ConfigurationValue
+ },
+ name: 'AllConfigurationsTab',
+ props: {
+ loading: {
+ type: Boolean,
+ required: true
+ }
+ },
+ data () {
+ return {
+ apiName: 'listConfigurations',
+ columns: [
+ {
+ title: 'Name',
+ dataIndex: 'name',
+ slots: { customRender: 'name' },
+ sorter: function (a, b) { return genericCompare(a[this.dataIndex] || '', b[this.dataIndex] || '') },
+ width: '60%'
+ },
+ {
+ title: 'Category',
Review Comment:
```suggestion
title: this.$t('label.category'),
```
##########
ui/src/views/setting/GlobalConfiguration.vue:
##########
@@ -0,0 +1,364 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="configLoading" style="background-color: #fff;">
+ <a-affix :offsetTop="78">
+ <a-card class="breadcrumb-card" style="z-index: 10">
+ <a-row>
+ <a-col :span="device === 'mobile' ? 24 : 12" style="padding-left: 12px">
+ <breadcrumb>
+ <template #end>
+ <a-button
+ :loading="configLoading"
+ style="margin-bottom: 5px"
+ shape="round"
+ size="small"
+ @click="refreshConfigurationData()">
+ <template #icon><reload-outlined /></template>
+ {{ $t('label.refresh') }}
+ </a-button>
+ </template>
+ </breadcrumb>
+ </a-col>
+ <a-col
+ :span="device === 'mobile' ? 24 : 12"
+ :style="device === 'mobile' ? { float: 'right', 'margin-top': '12px', 'margin-bottom': '-6px', display: 'table' } : { float: 'right', display: 'table', 'margin-bottom': '-6px' }" >
+ <slot name="action"></slot>
+ <search-view
+ :searchFilters="searchFilters"
+ :searchParams="searchParams"
+ :apiName="apiName"
+ @search="onSearch"
+ @change-filter="changeFilter"/>
+ </a-col>
+ </a-row>
+ </a-card>
+ </a-affix>
+ <a-tabs
+ tabPosition="left"
+ :animated="false"
+ @change="handleChangeConfigGroupTab" >
+ <a-tab-pane
+ key=''
+ tab='All Settings' >
Review Comment:
Please add a new translation key
##########
ui/src/views/setting/ConfigurationRow.vue:
##########
@@ -0,0 +1,164 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="rowLoading">
+ <a-table
+ size="small"
+ :columns="innerColumns"
+ :showHeader="false"
+ :dataSource="configrecords"
+ :pagination="false"
+ :bordered="false"
+ :defaultExpandAllRows="true"
+ :rowKey="record => record.name">
+ <template #name="{ record }">
+ <b> {{record.displaytext }} </b> {{ ' (' + record.name + ')' }} <br/> {{ record.description }}
+ </template>
+
+ <template #value="{ record }">
+ <ConfigurationValue :configrecord="record" :loading="rowLoading" :configDisabled="configDisabled" @change-config="onChangeConfig" />
+ </template>
+
+ <template #expandedRowRender="{}" v-if="childrenConfigData.length > 0">
+ <a-table
+ size="small"
+ :showHeader="false"
+ :columns="childrenColumns"
+ :dataSource="this.childrenConfigData"
Review Comment:
```suggestion
:dataSource="childrenConfigData"
```
##########
ui/src/views/setting/ConfigurationTab.vue:
##########
@@ -0,0 +1,153 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="tabLoading">
+ <a-table
+ size="small"
+ :showHeader="false"
+ :columns="columns"
+ :dataSource="this.configdata.filter(config => !config.parent)"
Review Comment:
```suggestion
:dataSource="configdata.filter(config => !config.parent)"
```
##########
ui/src/views/setting/AllConfigurationsTab.vue:
##########
@@ -0,0 +1,290 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="tabLoading">
+ <div class="config-row-element">
+ <a-table
+ class="config-list-view"
+ size="small"
+ :pagination="false"
+ :loading="tabLoading"
+ :columns="columns"
+ :items="items"
+ :dataSource="items"
+ :columnKeys="columnKeys"
+ :rowKey="record => record.name"
+ :rowClassName="getRowClassName"
+ @refresh="this.fetchConfigData">
Review Comment:
```suggestion
@refresh="fetchConfigData">
```
##########
ui/src/views/setting/AllConfigurationsTab.vue:
##########
@@ -0,0 +1,290 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="tabLoading">
+ <div class="config-row-element">
+ <a-table
+ class="config-list-view"
+ size="small"
+ :pagination="false"
+ :loading="tabLoading"
+ :columns="columns"
+ :items="items"
+ :dataSource="items"
+ :columnKeys="columnKeys"
+ :rowKey="record => record.name"
+ :rowClassName="getRowClassName"
+ @refresh="this.fetchConfigData">
+
+ <template #name="{ record }">
+ <b> {{record.displaytext }} </b> {{ ' (' + record.name + ')' }} <br/> {{ record.description }}
+ </template>
+ <template #value="{ record }">
+ <ConfigurationValue :configrecord="record" :loading="tabLoading" />
+ </template>
+ </a-table>
+ <a-pagination
+ class="config-row-element"
+ style="margin-top: 10px"
+ size="small"
+ :current="page"
+ :pageSize="pageSize"
+ :total="itemCount"
+ :showTotal="total => `${$t('label.showing')} ${Math.min(total, 1+((page-1)*pageSize))}-${Math.min(page*pageSize, total)} ${$t('label.of')} ${total} ${$t('label.items')}`"
+ :pageSizeOptions="pageSizeOptions"
+ @change="changePage"
+ @showSizeChange="changePageSize"
+ showSizeChanger
+ showQuickJumper>
+ <template #buildOptionText="props">
+ <span>{{ props.value }} / {{ $t('label.page') }}</span>
+ </template>
+ </a-pagination>
+ </div>
+ </a-spin>
+</template>
+
+<script>
+import { api } from '@/api'
+import { genericCompare } from '@/utils/sort.js'
+import ListView from '@/components/view/ListView'
+import TooltipButton from '@/components/widgets/TooltipButton'
+import ConfigurationValue from './ConfigurationValue'
+
+export default {
+ components: {
+ ListView,
+ TooltipButton,
+ ConfigurationValue
+ },
+ name: 'AllConfigurationsTab',
+ props: {
+ loading: {
+ type: Boolean,
+ required: true
+ }
+ },
+ data () {
+ return {
+ apiName: 'listConfigurations',
+ columns: [
+ {
+ title: 'Name',
+ dataIndex: 'name',
+ slots: { customRender: 'name' },
+ sorter: function (a, b) { return genericCompare(a[this.dataIndex] || '', b[this.dataIndex] || '') },
+ width: '60%'
+ },
+ {
+ title: 'Category',
+ dataIndex: 'category',
+ slots: { customRender: 'category' },
+ sorter: function (a, b) { return genericCompare(a[this.dataIndex] || '', b[this.dataIndex] || '') }
+ },
+ {
+ title: 'Value',
Review Comment:
```suggestion
title: this.$t('label.value'),
```
##########
ui/src/views/setting/ConfigurationTab.vue:
##########
@@ -0,0 +1,153 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="tabLoading">
+ <a-table
+ size="small"
+ :showHeader="false"
+ :columns="columns"
+ :dataSource="this.configdata.filter(config => !config.parent)"
+ :rowKey="record => record.name"
+ :pagination="true"
+ :rowClassName="getRowClassName"
+ style="overflow-y: auto; margin-left: 10px" >
+
+ <template #displaytext="{ record }">
+ <ConfigurationRow :config="this.configdata" :configrecord="record" :loading="tabLoading" />
Review Comment:
```suggestion
<ConfigurationRow :config="configdata" :configrecord="record" :loading="tabLoading" />
```
##########
ui/src/views/setting/GlobalConfiguration.vue:
##########
@@ -0,0 +1,364 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="configLoading" style="background-color: #fff;">
+ <a-affix :offsetTop="78">
+ <a-card class="breadcrumb-card" style="z-index: 10">
+ <a-row>
+ <a-col :span="device === 'mobile' ? 24 : 12" style="padding-left: 12px">
+ <breadcrumb>
+ <template #end>
+ <a-button
+ :loading="configLoading"
+ style="margin-bottom: 5px"
+ shape="round"
+ size="small"
+ @click="refreshConfigurationData()">
+ <template #icon><reload-outlined /></template>
+ {{ $t('label.refresh') }}
+ </a-button>
+ </template>
+ </breadcrumb>
+ </a-col>
+ <a-col
+ :span="device === 'mobile' ? 24 : 12"
+ :style="device === 'mobile' ? { float: 'right', 'margin-top': '12px', 'margin-bottom': '-6px', display: 'table' } : { float: 'right', display: 'table', 'margin-bottom': '-6px' }" >
+ <slot name="action"></slot>
+ <search-view
+ :searchFilters="searchFilters"
+ :searchParams="searchParams"
+ :apiName="apiName"
+ @search="onSearch"
+ @change-filter="changeFilter"/>
+ </a-col>
+ </a-row>
+ </a-card>
+ </a-affix>
+ <a-tabs
+ tabPosition="left"
+ :animated="false"
+ @change="handleChangeConfigGroupTab" >
+ <a-tab-pane
+ key=''
+ tab='All Settings' >
+ <AllConfigurationsTab :loading="configLoading" />
+ </a-tab-pane>
+ <a-tab-pane
+ v-for="(group) in groups"
+ :key="group.name"
+ :tab="group.name" >
+
+ <a-tabs
+ :animated="false"
+ @change="handleChangeConfigSubGroupTab" >
+ <a-tab-pane
+ v-for="(subgroup) in group.subgroup"
+ :key="subgroup.name"
+ :tab="subgroup.name" >
+ <ConfigurationTab :group="group.name" :subgroup="subgroup.name" :loading="configLoading" />
+ </a-tab-pane>
+ </a-tabs>
+ </a-tab-pane>
+ </a-tabs>
+ </a-spin>
+</template>
+
+<script>
+import { api } from '@/api'
+import { mixin, mixinDevice } from '@/utils/mixin.js'
+import Breadcrumb from '@/components/widgets/Breadcrumb'
+import Console from '@/components/widgets/Console'
+import OsLogo from '@/components/widgets/OsLogo'
+import Status from '@/components/widgets/Status'
+import ActionButton from '@/components/view/ActionButton'
+import InfoCard from '@/components/view/InfoCard'
+import QuickView from '@/components/view/QuickView'
+import TooltipButton from '@/components/widgets/TooltipButton'
+import SearchView from '@/components/view/SearchView'
+import ConfigurationTab from './ConfigurationTab'
+import AllConfigurationsTab from './AllConfigurationsTab'
+
+export default {
+ name: 'GlobalConfiguration',
+ components: {
+ Breadcrumb,
+ Console,
+ OsLogo,
+ Status,
+ ActionButton,
+ InfoCard,
+ QuickView,
+ TooltipButton,
+ SearchView,
+ ConfigurationTab,
+ AllConfigurationsTab
+ },
+ mixins: [mixin, mixinDevice],
+ props: {
+ loading: {
+ type: Boolean,
+ default: false
+ },
+ actions: {
+ type: Array,
+ default: () => []
+ }
+ },
+ data () {
+ return {
+ groups: [],
+ config: [],
+ configLoading: this.loading,
+ configGroup: '',
+ configSubGroup: '',
+ dataView: true,
+ searchView: true,
+ searchFilters: [],
+ searchParams: {},
+ filter: '',
+ apiName: 'listConfigurations'
+ }
+ },
+ created () {
+ this.fetchConfigurationGroups()
+ },
+ watch: {
+ // configGroup: {
Review Comment:
Please remove these comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1345954981
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1372664025
<b>Trillian test result (tid-5753)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41234 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5753-kvm-centos7.zip
Smoke tests completed. 101 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.78 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.15 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | test_primary_storage.py
test_01_non_strict_host_anti_affinity | `Failure` | 114.00 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 81.23 | test_nonstrict_affinity_group.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 35.13 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 58.64 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 41.16 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 36.06 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 120.03 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 158.76 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 268.32 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 136.88 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.94 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.86 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063280080
##########
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##########
@@ -993,3 +993,246 @@ BEGIN
DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' ADD KEY ') ; SET @ddl = CONCAT(@ddl, ' ', in_index_name); SET @ddl = CONCAT(@ddl, ' ', in_key_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE stmt; END;
CALL `cloud`.`IDEMPOTENT_ADD_KEY`('i_user_ip_address_state','user_ip_address', '(state)');
+--
+-- Update Configuration Groups and Subgroups
+--
Review Comment:
Adding a column in an idempotent way is not supported our of the box :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375122134
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375122582
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1379886792
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1251915195
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1252046648
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1253344562
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1409632108
<b>Trillian test result (tid-6030)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41092 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t6030-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097629420
> 
> Please fix so that the margin of the breadcrumb is similar to that of other pages for reference below:
> 
@utchoang Fixed the margin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r847072779
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/simulator/dao/MockConfigurationSubGroupDao.java:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.simulator.dao;
+
+import java.util.List;
+
+import com.cloud.simulator.MockConfigurationSubGroupVO;
+import com.cloud.utils.db.GenericDao;
+
+public interface MockConfigurationSubGroupDao extends GenericDao<MockConfigurationSubGroupVO, Long> {
Review Comment:
removed the mock classes, not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1095563875
<b>Trillian test result (tid-3850)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35611 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t3850-kvm-centos7.zip
Smoke tests completed. 89 look OK, 4 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.58 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
test_01_secure_vm_migration | `Error` | 163.94 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 308.29 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 149.20 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.74 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.59 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.59 | test_snapshots.py
test_hostha_kvm_host_degraded | `Error` | 702.38 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 684.34 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097600092
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102109311
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106832446
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106809371
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1370615223
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1370614637
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371861095
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1371894296
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1372053766
> SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
>
> [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [77 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
>
> [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [18.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Dupli
cation](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
Can you look at these @davidjumani ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1362438315
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [61 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [22.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.8% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "davidjumani (via GitHub)" <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400165217
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1272897303
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180305166
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180662452
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182861971
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1291631658
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1314983516
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180304836
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5797 (SL-JID-1938)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180362355
<b>Trillian Build Failed (tid-4477)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182921464
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [77 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [21.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182839917
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [77 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [21.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1198076371
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106836819
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
|VirtualMachineManager|110|0|4|0|12|0|
||
|StorageManager|0|217|0|0|0|21|
|ClusteredAgentManagerImpl|2364|0|242|0|537|0|
|ConfigurationGroupsAggregator|131|22|20|0|33|6|
|Upgrade41610to41700|165|12|6|0|46|3|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|KubernetesClusterService|0|84|0|0|0|13|
|PrometheusExporterServer|35|0|0|0|5|0|
||
||
|ApiResponseHelper|12257|0|1278|0|2806|0|
|ConfigurationManagerImpl|18272|0|3066|0|3616|0|
|VirtualNetworkApplianceManager|281|0|0|0|31|0|
|ManagementServerImpl|12287|0|1088|0|2453|0|
|UserVmManagerImpl|20804|0|2566|0|3872|0|
|DiagnosticsServiceImpl|951|0|66|0|169|0|
||
||
||
||
||
|MockConfigurationDaoImpl|636|0|14|0|87|0|
||
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106696312
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1106721828
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
|VirtualMachineManager|110|0|4|0|12|0|
||
|StorageManager|0|217|0|0|0|21|
|ClusteredAgentManagerImpl|2364|0|242|0|537|0|
|ConfigurationGroupsAggregator|131|22|20|0|33|6|
|Upgrade41610to41700|165|12|6|0|46|3|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|KubernetesClusterService|0|84|0|0|0|13|
|PrometheusExporterServer|35|0|0|0|5|0|
||
||
|ApiResponseHelper|12257|0|1278|0|2806|0|
|ConfigurationManagerImpl|18272|0|3066|0|3616|0|
|VirtualNetworkApplianceManager|281|0|0|0|31|0|
|ManagementServerImpl|12287|0|1088|0|2453|0|
|UserVmManagerImpl|20804|0|2566|0|3872|0|
|DiagnosticsServiceImpl|951|0|66|0|169|0|
||
||
||
||
||
|MockConfigurationDaoImpl|636|0|14|0|87|0|
||
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102109070
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102108102
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1102138760
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
|Upgrade41610to41700|324|7|30|0|93|2|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|SAMLUtils|202|465|41|11|53|108|
|ApiResponseHelper|11991|0|1246|0|2738|0|
|ConfigurationManagerImpl|18260|0|3076|0|3615|0|
|ManagementServerImpl|11892|0|1060|0|2374|0|
||
||
||
||
|MockConfigurationDaoImpl|636|0|14|0|87|0|
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r847071594
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java:
##########
@@ -83,4 +92,99 @@ public void updateSystemVmTemplates(Connection conn) {
throw new CloudRuntimeException("Failed to find / register SystemVM template(s)");
}
}
+
+ private void updateConfigurationGroups(Connection conn) {
+ LOG.debug("Updating configuration groups");
+ try {
+ String stmt = "SELECT name FROM `cloud`.`configuration`";
+ PreparedStatement pstmt = conn.prepareStatement(stmt);
+ ResultSet rs = pstmt.executeQuery();
+
+ while (rs.next()) {
+ String configName = rs.getString(1);
+ if (StringUtils.isBlank(configName)) {
+ continue;
+ }
+
+ // Get words from the dot notation in the configuration
+ String[] nameWords = configName.split("\\.");
+ if (nameWords.length <= 0) {
+ continue;
+ }
+
+ for (int index = 0; index < nameWords.length; index++) {
+ Pair<Long, Long> configGroupAndSubGroup = getConfigurationGroupAndSubGroup(conn, nameWords[index]);
+ if (configGroupAndSubGroup.first() != 1 && configGroupAndSubGroup.second() != 1) {
+ stmt = "UPDATE `cloud`.`configuration` SET group_id = ?, subgroup_id = ? WHERE name = ?";
+ pstmt = conn.prepareStatement(stmt);
+ pstmt.setLong(1, configGroupAndSubGroup.first());
+ pstmt.setLong(2, configGroupAndSubGroup.second());
+ pstmt.setString(3, configName);
+ pstmt.executeUpdate();
+ break;
+ }
+ }
+ }
+
+ rs.close();
+ pstmt.close();
+ LOG.debug("Successfully updated configuration groups.");
+ } catch (SQLException e) {
+ String errorMsg = "Failed to update configuration groups due to " + e.getMessage();
+ LOG.error(errorMsg, e);
+ throw new CloudRuntimeException(errorMsg, e);
+ }
+ }
+
+ private Pair<Long, Long> getConfigurationGroupAndSubGroup(Connection conn, String name) {
+ Long subGroupId = 1L;
+ Long groupId = 1L;
+ try {
+ String stmt = "SELECT id, group_id FROM `cloud`.`configuration_subgroup` WHERE name = ?";
+ PreparedStatement pstmt = conn.prepareStatement(stmt);
+ pstmt.setString(1, name);
+ ResultSet rs = pstmt.executeQuery();
+ if (rs.next()) {
+ subGroupId = rs.getLong(1);
+ groupId = rs.getLong(2);
+ } else {
+ // Try with keywords in the configuration subgroup
+ stmt = "SELECT id, group_id, keywords FROM `cloud`.`configuration_subgroup` WHERE keywords IS NOT NULL";
+ pstmt = conn.prepareStatement(stmt);
+ ResultSet rsConfigurationSubGroups = pstmt.executeQuery();
+ while (rsConfigurationSubGroups.next()) {
+ Long keywordsSubGroupId = rsConfigurationSubGroups.getLong(1);
+ Long keywordsGroupId = rsConfigurationSubGroups.getLong(2);
+ String keywords = rsConfigurationSubGroups.getString(3);
+ if(StringUtils.isBlank(keywords)) {
+ continue;
+ }
+
+ String[] configKeywords = keywords.split(",");
+ if (configKeywords.length <= 0) {
+ continue;
+ }
+
+ List<String> keywordsList = Arrays.asList(configKeywords);
+ for (String configKeyword : keywordsList) {
+ if (StringUtils.isNotBlank(configKeyword)) {
+ configKeyword = configKeyword.strip();
+ if (configKeyword.equalsIgnoreCase(name)) {
+ subGroupId = keywordsSubGroupId;
+ groupId = keywordsGroupId;
+ return new Pair<Long, Long>(groupId, subGroupId);
+ }
+ }
+ }
+ }
+ rsConfigurationSubGroups.close();
+ }
+ rs.close();
+ pstmt.close();
+ } catch (SQLException e) {
+ LOG.error("Failed to get configuration subgroup due to " + e.getMessage(), e);
Review Comment:
set to default group / subgroup if any issues. throwing any error might block upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r847070357
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java:
##########
@@ -83,4 +92,99 @@ public void updateSystemVmTemplates(Connection conn) {
throw new CloudRuntimeException("Failed to find / register SystemVM template(s)");
}
}
+
+ private void updateConfigurationGroups(Connection conn) {
+ LOG.debug("Updating configuration groups");
+ try {
+ String stmt = "SELECT name FROM `cloud`.`configuration`";
+ PreparedStatement pstmt = conn.prepareStatement(stmt);
+ ResultSet rs = pstmt.executeQuery();
+
+ while (rs.next()) {
+ String configName = rs.getString(1);
+ if (StringUtils.isBlank(configName)) {
+ continue;
+ }
+
+ // Get words from the dot notation in the configuration
+ String[] nameWords = configName.split("\\.");
+ if (nameWords.length <= 0) {
+ continue;
+ }
+
+ for (int index = 0; index < nameWords.length; index++) {
+ Pair<Long, Long> configGroupAndSubGroup = getConfigurationGroupAndSubGroup(conn, nameWords[index]);
+ if (configGroupAndSubGroup.first() != 1 && configGroupAndSubGroup.second() != 1) {
+ stmt = "UPDATE `cloud`.`configuration` SET group_id = ?, subgroup_id = ? WHERE name = ?";
+ pstmt = conn.prepareStatement(stmt);
+ pstmt.setLong(1, configGroupAndSubGroup.first());
Review Comment:
_configGroupAndSubGroup_ is not null at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r847074543
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -7311,6 +7319,82 @@ public String getConfigComponentName() {
};
}
+ @Override
+ public String getConfigurationType(final String configName) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg == null) {
+ s_logger.error("Configuration " + configName + " not found");
+ return Configuration.ValueType.String.name();
+ }
+
+ if (weightBasedParametersForValidation.contains(configName)) {
+ return Configuration.ValueType.Range.name();
+ }
+
+ Class<?> type = null;
+ final Config c = Config.getConfig(configName);
+ if (c == null) {
+ s_logger.warn("Configuration " + configName + " no found. Perhaps moved to ConfigDepot");
+ final ConfigKey<?> configKey = _configDepot.get(configName);
+ if (configKey == null) {
+ s_logger.warn("Couldn't find configuration " + configName + " in ConfigDepot too.");
+ return null;
+ }
+ type = configKey.type();
+ } else {
+ type = c.getType();
+ }
+
+ return getInputType(type);
+ }
+
+ private String getInputType(Class<?> type) {
+ if (type == null) {
+ return Configuration.ValueType.String.name();
+ }
+
+ if (type == String.class || type == Character.class) {
+ return Configuration.ValueType.String.name();
+ } else if (type == Integer.class || type == Long.class || type == Short.class) {
+ return Configuration.ValueType.Number.name();
+ } else if (type == Float.class || type == Double.class) {
+ return Configuration.ValueType.Decimal.name();
+ } else if (type == Boolean.class) {
+ return Configuration.ValueType.Boolean.name();
+ //} else if (type == Date.class) {
+ // return Configuration.InputType.Date.name();
+ } else {
+ return Configuration.ValueType.String.name();
+ }
+ }
+
+ @Override
+ public Pair<String, String> getConfigurationGroupAndSubGroup(final String configName) {
+ if (StringUtils.isNotBlank(configName)) {
+ final ConfigurationVO cfg = _configDao.findByName(configName);
+ if (cfg != null) {
+ ConfigurationSubGroupVO configSubGroup = _configSubGroupDao.findById(cfg.getSubGroupId());
+ if (configSubGroup != null) {
+ String subGroupName = configSubGroup.getName();
+ ConfigurationGroupVO configGroup = _configGroupDao.findById(configSubGroup.getGroupId());
+ String groupName = configGroup != null ? configGroup.getName() : "Miscellaneous";
+ return new Pair<String, String>(groupName, subGroupName);
+ }
+ } else {
+ s_logger.warn("Configuration " + configName + " not found");
+ }
+ }
+
+ s_logger.debug("Returning default configuration group for config: " + configName);
Review Comment:
keeping default group for now, not to fail the response. will check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375121520
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1375999709
<b>Trillian test result (tid-5761)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42541 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5761-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 552.09 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1374272675
<b>Trillian test result (tid-5758)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42779 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5758-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063486666
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/dao/ConfigurationSubGroupDaoImpl.java:
##########
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config.dao;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.function.BiPredicate;
+
+import org.apache.cloudstack.framework.config.impl.ConfigurationSubGroupVO;
+import org.apache.commons.lang3.StringUtils;
+import org.springframework.stereotype.Component;
+
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+public class ConfigurationSubGroupDaoImpl extends GenericDaoBase<ConfigurationSubGroupVO, Long> implements ConfigurationSubGroupDao {
+
+ final SearchBuilder<ConfigurationSubGroupVO> nameSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> groupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> nameAndGroupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> keywordSearch;
+
+ public ConfigurationSubGroupDaoImpl() {
+ super();
+
+ nameSearch = createSearchBuilder();
+ nameSearch.and("name", nameSearch.entity().getName(), SearchCriteria.Op.LIKE);
+ nameSearch.done();
+
+ groupSearch = createSearchBuilder();
+ groupSearch.and("groupId", groupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ groupSearch.done();
+
+ nameAndGroupSearch = createSearchBuilder();
+ nameAndGroupSearch.and("name", nameAndGroupSearch.entity().getName(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.and("groupId", nameAndGroupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.done();
+
+ keywordSearch = createSearchBuilder();
+ keywordSearch.and("keywords", keywordSearch.entity().getKeywords(), SearchCriteria.Op.NNULL);
+ keywordSearch.done();
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name);
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ @Override
+ public ConfigurationSubGroupVO startsWithName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name + "%");
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ private ConfigurationSubGroupVO matchKeywordBy(BiPredicate<String, String> matcher, List<ConfigurationSubGroupVO> configurationSubGroups, String keyword) {
Review Comment:
`matchBy` as a name would have said enough about the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1063487208
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/dao/ConfigurationSubGroupDaoImpl.java:
##########
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config.dao;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.function.BiPredicate;
+
+import org.apache.cloudstack.framework.config.impl.ConfigurationSubGroupVO;
+import org.apache.commons.lang3.StringUtils;
+import org.springframework.stereotype.Component;
+
+import com.cloud.utils.db.Filter;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+public class ConfigurationSubGroupDaoImpl extends GenericDaoBase<ConfigurationSubGroupVO, Long> implements ConfigurationSubGroupDao {
+
+ final SearchBuilder<ConfigurationSubGroupVO> nameSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> groupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> nameAndGroupSearch;
+ final SearchBuilder<ConfigurationSubGroupVO> keywordSearch;
+
+ public ConfigurationSubGroupDaoImpl() {
+ super();
+
+ nameSearch = createSearchBuilder();
+ nameSearch.and("name", nameSearch.entity().getName(), SearchCriteria.Op.LIKE);
+ nameSearch.done();
+
+ groupSearch = createSearchBuilder();
+ groupSearch.and("groupId", groupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ groupSearch.done();
+
+ nameAndGroupSearch = createSearchBuilder();
+ nameAndGroupSearch.and("name", nameAndGroupSearch.entity().getName(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.and("groupId", nameAndGroupSearch.entity().getGroupId(), SearchCriteria.Op.EQ);
+ nameAndGroupSearch.done();
+
+ keywordSearch = createSearchBuilder();
+ keywordSearch.and("keywords", keywordSearch.entity().getKeywords(), SearchCriteria.Op.NNULL);
+ keywordSearch.done();
+ }
+
+ @Override
+ public ConfigurationSubGroupVO findByName(String name) {
+ SearchCriteria<ConfigurationSubGroupVO> sc = nameSearch.create();
+ sc.setParameters("name", name);
+ return findOneIncludingRemovedBy(sc);
+ }
+
+ @Override
+ public ConfigurationSubGroupVO startsWithName(String name) {
Review Comment:
`startsWith` is descriptive enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400166285
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #5797: Improve global settings UI to be more intuitive/logical
URL: https://github.com/apache/cloudstack/pull/5797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1252033822
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/5797?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5797](https://codecov.io/gh/apache/cloudstack/pull/5797?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1887691) into [main](https://codecov.io/gh/apache/cloudstack/commit/bbc126057674a6cda047c2ea941d09af5c0e14a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bbc1260) will **increase** coverage by `0.01%`.
> The diff coverage is `24.88%`.
```diff
@@ Coverage Diff @@
## main #5797 +/- ##
============================================
+ Coverage 10.42% 10.43% +0.01%
- Complexity 6701 6705 +4
============================================
Files 2458 2459 +1
Lines 243246 243458 +212
Branches 38067 38100 +33
============================================
+ Hits 25358 25410 +52
- Misses 214714 214874 +160
Partials 3174 3174
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/5797?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cloud/agent/manager/ClusteredAgentManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvbWFuYWdlci9DbHVzdGVyZWRBZ2VudE1hbmFnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ava/com/cloud/upgrade/dao/Upgrade41610to41700.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE2MTB0bzQxNzAwLmphdmE=) | `4.44% <ø> (ø)` | |
| [...e/cloudstack/metrics/PrometheusExporterServer.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMvcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9tZXRyaWNzL1Byb21ldGhldXNFeHBvcnRlclNlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...src/main/java/com/cloud/api/ApiResponseHelper.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlSZXNwb25zZUhlbHBlci5qYXZh) | `2.42% <0.00%> (-0.04%)` | :arrow_down: |
| [...java/com/cloud/server/ConfigurationServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9Db25maWd1cmF0aW9uU2VydmVySW1wbC5qYXZh) | `2.36% <0.00%> (-0.01%)` | :arrow_down: |
| [...in/java/com/cloud/server/ManagementServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | `2.45% <0.00%> (-0.03%)` | :arrow_down: |
| [...m/cloud/upgrade/ConfigurationGroupsAggregator.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL0NvbmZpZ3VyYXRpb25Hcm91cHNBZ2dyZWdhdG9yLmphdmE=) | `15.38% <15.38%> (ø)` | |
| [...ava/com/cloud/upgrade/dao/Upgrade41710to41800.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE3MTB0bzQxODAwLmphdmE=) | `10.34% <25.00%> (+2.34%)` | :arrow_up: |
| [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `11.56% <29.57%> (+0.32%)` | :arrow_up: |
| [.../main/java/com/cloud/vm/VirtualMachineManager.java](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9WaXJ0dWFsTWFjaGluZU1hbmFnZXIuamF2YQ==) | `91.66% <100.00%> (+0.75%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/cloudstack/pull/5797/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1274876984
@rohityadavcloud @nvazquez @utchoang @sureshanaparti is this ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1273747950
<b>Trillian test result (tid-5095)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42860 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5095-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 485.96 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1252045681
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1254165034
<b>Trillian test result (tid-4945)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41519 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t4945-kvm-centos7.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1254225028
<b>Trillian test result (tid-4946)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45718 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t4946-vmware-65u2.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1272898833
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "davidjumani (via GitHub)" <gi...@apache.org>.
davidjumani commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1408402899
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
utchoang commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r975140030
##########
ui/src/views/setting/ConfigurationRow.vue:
##########
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-spin :spinning="rowLoading">
+ <a-table
+ size="small"
+ :columns="innerColumns"
+ :showHeader="false"
+ :dataSource="configrecords"
+ :pagination="false"
+ :bordered="false"
+ :defaultExpandAllRows="true"
+ :rowKey="record => record.name"
+ :rowClassName="getRowClassName">
+ <template #name="{ record }">
+ <b> {{record.displaytext }} </b> {{ ' (' + record.name + ')' }} <br/> {{ record.description }}
+ </template>
+
+ <template #value="{ record }">
+ <ConfigurationValue :configrecord="record" :loading="rowLoading" :configDisabled="configDisabled" @change-config="onChangeConfig" />
+ </template>
+
+ <template #expandedRowRender="{}" v-if="childrenConfigData.length > 0">
+ <a-table
+ size="small"
+ :showHeader="false"
+ :columns="childrenColumns"
+ :dataSource="childrenConfigData"
+ :rowKey="record => record.name"
+ :pagination="false"
+ :rowClassName="getRowClassName"
+ style="overflow-y: auto; margin-left: 10px" >
+
+ <template #displaytext="{ record }">
+ <ConfigurationRow :config="this.childrenConfigData" :configrecord="record" :loading="rowLoading" :configDisabled="!childrenConfigEnabled" />
+ </template>
+ </a-table>
+ </template>
+ </a-table>
+ </a-spin>
+</template>
+<script>
+import { api } from '@/api'
+import ConfigurationValue from './ConfigurationValue'
+
+export default {
+ name: 'ConfigurationRow',
+ components: {
+ ConfigurationValue
+ },
+ props: {
+ config: {
+ type: Object,
+ required: true
+ },
+ configrecord: {
+ type: Object,
+ required: true
+ },
+ loading: {
+ type: Boolean,
+ default: false
+ },
+ configDisabled: {
+ type: Boolean,
+ default: false
+ }
+ },
+ data () {
+ return {
+ rowLoading: this.loading,
+ innerColumns: [
+ {
+ title: 'name',
+ dataIndex: 'name',
+ slots: { customRender: 'name' }
+ },
+ {
+ title: 'value',
+ dataIndex: 'value',
+ slots: { customRender: 'value' },
+ width: '25%'
+ }
+ ],
+ childrenColumns: [
+ {
+ title: 'Display Text',
+ dataIndex: 'displaytext',
+ slots: { customRender: 'displaytext' }
+ }
+ ],
+ childrenConfigData: [],
+ childrenConfigEnabled: true,
+ configrecords: [
+ this.configrecord
+ ]
+ }
+ },
+ created () {
+ this.fetchChildrenConfigData()
+ },
+ watch: {
+ },
+ methods: {
+ fetchChildrenConfigData () {
+ if (!this.isBooleanValue()) {
+ this.rowLoading = false
+ return
+ }
+ this.rowLoading = true
+ this.childrenConfigEnabled = (this.configrecord.value === 'true')
+ const params = {
+ parent: this.configrecord.name,
+ listAll: true
+ }
+ api('listConfigurations', params).then(response => {
+ this.childrenConfigData = response.listconfigurationsresponse.configuration
+ if (!this.childrenConfigData || this.childrenConfigData.length === 0) {
Review Comment:
I don't know what this paragraph is for. I think you can replace it like this `this.childrenConfigData = response?.listconfigurationsresponse?.configuration || []`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1379844522
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [64 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398194833
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1398335227
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386890352
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by sonarcloud.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400231680
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1400230204
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1347909487
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1199206221
<b>Trillian Build Failed (tid-4568)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180303233
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180362782
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=5797)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=5797&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL) [51 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=5797&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list) [22.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=5797&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182835340
<b>Trillian Build Failed (tid-4500)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180627712
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1180345508
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1182794739
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1207450933
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1314958944
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315029548
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1315084783
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1208060117
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1101261042
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1097579852
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org