You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@uima.apache.org by sc...@apache.org on 2016/10/26 14:04:24 UTC

svn commit: r1766686 - /uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java

Author: schor
Date: Wed Oct 26 14:04:24 2016
New Revision: 1766686

URL: http://svn.apache.org/viewvc?rev=1766686&view=rev
Log:
no Jira - add check for overflow when incrementing id

Modified:
    uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java

Modified: uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java
URL: http://svn.apache.org/viewvc/uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java?rev=1766686&r1=1766685&r2=1766686&view=diff
==============================================================================
--- uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java (original)
+++ uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java Wed Oct 26 14:04:24 2016
@@ -4435,7 +4435,12 @@ public class CASImpl extends AbstractCas
 //      System.out.println("debug out of sync id generator and id2fs size");
 //    }
 //    assert(l.size() == (2 + svd.fsIdGenerator));
-    return ++ svd.fsIdGenerator;
+    int p = svd.fsIdGenerator;
+    int r = ++ svd.fsIdGenerator;
+    if (r < p) { 
+      throw new RuntimeException("UIMA Cas Internal id value overflowed maximum int value");
+    }
+    return r;
   }
   
   /**