You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ng Tsz Sum (Jira)" <ji...@apache.org> on 2023/04/16 06:27:00 UTC
[jira] [Updated] (COLLECTIONS-839) migrate BulkTest to junit 5

     [ https://issues.apache.org/jira/browse/COLLECTIONS-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ng Tsz Sum updated COLLECTIONS-839:
-----------------------------------
    Description: 
BulkTest.java is the base class of most test of the test classes.

And this class extends TestCase.java

To fully migrate to Junit 5, this class should not extend TestCase.java

Since most of the assertXXX method in the test is using 
TestCase#assertEquals, directly remove the `extends TestCase` will cause tons of compile errors. So better to do it by batch


 # Migrate all assertion api to use Junit 5 Assertions for XXXMapTest
 # Migrate all assertion api to use Junit 5 Assertions for XXXListTest
 # Migrate all assertion api to use Junit 5 Assertions for XXXSetTest
 # BulkTest not extend TestCase

Acceptance Criteria
 * no. of tests should not change

  was:
BulkTest.java is the base class of most test of the test classes.

And this class extends TestCase.java

To fully migrate to Junit 5, this class should not extend TestCase.java

Since most of the assertXXX method in the test is using 
TestCase#assertEquals, directly remove the `extends TestCase` will cause tons of compile errors. So better to do it by batch


> migrate BulkTest to junit 5
> ---------------------------
>
>                 Key: COLLECTIONS-839
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-839
>             Project: Commons Collections
>          Issue Type: Sub-task
>            Reporter: Ng Tsz Sum
>            Priority: Major
>
> BulkTest.java is the base class of most test of the test classes.
> And this class extends TestCase.java
> To fully migrate to Junit 5, this class should not extend TestCase.java
> Since most of the assertXXX method in the test is using 
> TestCase#assertEquals, directly remove the `extends TestCase` will cause tons of compile errors. So better to do it by batch
>  # Migrate all assertion api to use Junit 5 Assertions for XXXMapTest
>  # Migrate all assertion api to use Junit 5 Assertions for XXXListTest
>  # Migrate all assertion api to use Junit 5 Assertions for XXXSetTest
>  # BulkTest not extend TestCase
> Acceptance Criteria
>  * no. of tests should not change



--
This message was sent by Atlassian Jira
(v8.20.10#820010)