You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ed Korthof <ed...@organic.com> on 1997/07/10 22:55:03 UTC
[PATCH] mod_rewrite fix
I'm not sure if this should go to Ralf or the Apache group, so I've sent
it to both. Basically, mod_rewrite currently only observes forced
response codes with local redirects; it should do so with non-local
redirects as well.
-- Ed Korthof | Web Server Engineer --
-- ed@organic.com | Organic Online, Inc --
-- (415) 278-5676 | Fax: (415) 284-6891 --
----------
*** mod_rewrite.c.orig Thu Jul 10 13:46:30 1997
--- mod_rewrite.c Thu Jul 10 13:46:38 1997
***************
*** 1662,1665 ****
--- 1662,1668 ----
r->status = p->forced_responsecode;
return 1;
+ } else { /* we should still apply p->forced_responsecode
+ XXX should we check the contents? we don't up above. */
+ r->status = p->forced_responsecode;
}
}
----------
Re: [PATCH] mod_rewrite fix
Posted by Ed Korthof <ed...@organic.com>.
Uh, d'oh -- looks like the latest version of mod_rewrite fixes this.
Should have checked engelschall first, but I hadn't realized
dev.apache.org doesn't have the latest source till I read a bit more of
the list...
-- Ed Korthof | Web Server Engineer --
-- ed@organic.com | Organic Online, Inc --
-- (415) 278-5676 | Fax: (415) 284-6891 --
Re: [PATCH] mod_rewrite fix
Posted by Marc Slemko <ma...@worldgate.com>.
On Thu, 10 Jul 1997, Ed Korthof wrote:
> I'm not sure if this should go to Ralf or the Apache group, so I've sent
> it to both. Basically, mod_rewrite currently only observes forced
> response codes with local redirects; it should do so with non-local
> redirects as well.
Been there, done that. This looks like the same thing I did a patch for
the other week. I think it is in Ralf's latest mod_rewrite update too.
Isn't applied to the repository yet though.