You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/26 12:29:14 UTC

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11285: broker gc log

gaozhangmin commented on a change in pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#discussion_r716197064



##########
File path: bin/pulsar
##########
@@ -287,6 +288,9 @@ PULSAR_LOG_APPENDER=${PULSAR_LOG_APPENDER:-"RoutingAppender"}
 PULSAR_LOG_ROOT_LEVEL=${PULSAR_LOG_ROOT_LEVEL:-"info"}
 PULSAR_LOG_LEVEL=${PULSAR_LOG_LEVEL:-"info"}
 PULSAR_ROUTING_APPENDER_DEFAULT=${PULSAR_ROUTING_APPENDER_DEFAULT:-"Console"}
+if [ ! -d "$PULSAR_LOG_DIR" ]; then
+  mkdir -p "$PULSAR_LOG_DIR"

Review comment:
       Here, We should also create log dir if it doesn't exists, not only try create log dir in `pulsar-daemon.sh`,
   Such as, If We try to `pulsar-current/bin/pulsar initialize-cluster-metadata`, we would fail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org