[GitHub] [arrow] nealrichardson commented on a change in pull request #9423: ARROW-9856: [R] Add bindings for string compute functions

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #9423:
URL: https://github.com/apache/arrow/pull/9423#discussion_r574675049



##########
File path: r/tests/testthat/test-dplyr.R
##########
@@ -256,6 +262,29 @@ test_that("filter() with %in%", {
   )
 })
 
+test_that("filter() with string ops", {
+  expect_dplyr_equal(
+    input %>%
+      filter(dbl > 2, toupper(chr) %in% c("D", "F")) %>%
+      collect(),
+    tbl
+  )

Review comment:
       It's tricky with the R string functions like this that start with 
   
   ```
       if (!is.character(x)) 
           x <- as.character(x)
   ```
   
   Maybe we can test that by defining `as.character <- function(...) stop("🙅")` in the test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org