You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/22 01:41:59 UTC

[GitHub] [lucene] dnhatn opened a new pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

dnhatn opened a new pull request #222:
URL: https://github.com/apache/lucene/pull/222


   These maps are no longer useful after [LUCENE-8505](https://issues.apache.org/jira/browse/LUCENE-8505).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dnhatn commented on a change in pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

Posted by GitBox <gi...@apache.org>.
dnhatn commented on a change in pull request #222:
URL: https://github.com/apache/lucene/pull/222#discussion_r674773365



##########
File path: lucene/core/src/java/org/apache/lucene/index/MergeState.java
##########
@@ -227,19 +222,7 @@ public int get(int docID) {
   }
 
   private List<CodecReader> maybeSortReaders(

Review comment:
       ++, I pushed https://github.com/apache/lucene/pull/222/commits/707f4f982fc831f56d51db1288e1ff468025eee0




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] jpountz commented on a change in pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #222:
URL: https://github.com/apache/lucene/pull/222#discussion_r674713006



##########
File path: lucene/core/src/java/org/apache/lucene/index/MergeState.java
##########
@@ -227,19 +222,7 @@ public int get(int docID) {
   }
 
   private List<CodecReader> maybeSortReaders(

Review comment:
       maybe should rename and make it void now that it only seems to perform validation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dnhatn merged pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

Posted by GitBox <gi...@apache.org>.
dnhatn merged pull request #222:
URL: https://github.com/apache/lucene/pull/222


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] dnhatn commented on pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #222:
URL: https://github.com/apache/lucene/pull/222#issuecomment-889075808


   Thanks Adrien!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org