You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Avinash Gautam <av...@citrix.com> on 2015/03/19 06:08:19 UTC
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for
filter feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27611/
-----------------------------------------------------------
(Updated March 19, 2015, 5:08 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Modified the tests and incorporated the review comments.
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282 - Added automated tests for filter feature
Diffs (updated)
-----
test/integration/component/test_escalations_ipaddresses.py c60c5b6
test/integration/component/test_escalations_isos.py 4e818a5
test/integration/component/test_escalations_networks.py fb2196c
test/integration/component/test_escalations_volumes.py 58f5845
test/integration/component/test_escalations_vpncustomergateways.py b09930a
Diff: https://reviews.apache.org/r/27611/diff/
Testing
-------
Tested all the files to which tests are added and atatched are the result files
File Attachments
----------------
IPAddressresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt
ISOresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt
Networksresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt
SecurityGroupsresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt
Snapshotresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt
Templatesresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt
Volumeresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt
VPNCustomerGatewaysresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt
Thanks,
Avinash Gautam
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for
filter feature
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27611/#review77013
-----------------------------------------------------------
Please close the fixed issues.
- Gaurav Aradhye
On March 19, 2015, 10:38 a.m., Avinash Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27611/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:38 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 - Added automated tests for filter feature
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_ipaddresses.py c60c5b6
> test/integration/component/test_escalations_isos.py 4e818a5
> test/integration/component/test_escalations_networks.py fb2196c
> test/integration/component/test_escalations_volumes.py 58f5845
> test/integration/component/test_escalations_vpncustomergateways.py b09930a
>
> Diff: https://reviews.apache.org/r/27611/diff/
>
>
> Testing
> -------
>
> Tested all the files to which tests are added and atatched are the result files
>
>
> File Attachments
> ----------------
>
> IPAddressresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt
> ISOresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt
> Networksresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt
> SecurityGroupsresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt
> Snapshotresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt
> Templatesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt
> Volumeresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt
> VPNCustomerGatewaysresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt
>
>
> Thanks,
>
> Avinash Gautam
>
>
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for
filter feature
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27611/#review77011
-----------------------------------------------------------
test/integration/component/test_escalations_ipaddresses.py
<https://reviews.apache.org/r/27611/#comment124768>
Please remove white-spaces.
test/integration/component/test_escalations_vpncustomergateways.py
<https://reviews.apache.org/r/27611/#comment124772>
Please fix pep8 issues
- Gaurav Aradhye
On March 19, 2015, 10:38 a.m., Avinash Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27611/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:38 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 - Added automated tests for filter feature
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_ipaddresses.py c60c5b6
> test/integration/component/test_escalations_isos.py 4e818a5
> test/integration/component/test_escalations_networks.py fb2196c
> test/integration/component/test_escalations_volumes.py 58f5845
> test/integration/component/test_escalations_vpncustomergateways.py b09930a
>
> Diff: https://reviews.apache.org/r/27611/diff/
>
>
> Testing
> -------
>
> Tested all the files to which tests are added and atatched are the result files
>
>
> File Attachments
> ----------------
>
> IPAddressresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt
> ISOresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt
> Networksresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt
> SecurityGroupsresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt
> Snapshotresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt
> Templatesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt
> Volumeresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt
> VPNCustomerGatewaysresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt
>
>
> Thanks,
>
> Avinash Gautam
>
>
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for
filter feature
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27611/#review78977
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On March 19, 2015, 5:52 a.m., Avinash Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27611/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:52 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 - Added automated tests for filter feature
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_ipaddresses.py c60c5b6
> test/integration/component/test_escalations_vpncustomergateways.py b09930a
>
> Diff: https://reviews.apache.org/r/27611/diff/
>
>
> Testing
> -------
>
> Tested all the files to which tests are added and atatched are the result files
>
>
> File Attachments
> ----------------
>
> IPAddressresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt
> ISOresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt
> Networksresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt
> SecurityGroupsresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt
> Snapshotresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt
> Templatesresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt
> Volumeresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt
> VPNCustomerGatewaysresults.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt
>
>
> Thanks,
>
> Avinash Gautam
>
>
Re: Review Request 27611: CLOUDSTACK-6282 - Added automated tests for
filter feature
Posted by Avinash Gautam <av...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27611/
-----------------------------------------------------------
(Updated March 19, 2015, 5:52 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Modified tests and incorporated changes.
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282 - Added automated tests for filter feature
Diffs (updated)
-----
test/integration/component/test_escalations_ipaddresses.py c60c5b6
test/integration/component/test_escalations_vpncustomergateways.py b09930a
Diff: https://reviews.apache.org/r/27611/diff/
Testing
-------
Tested all the files to which tests are added and atatched are the result files
File Attachments
----------------
IPAddressresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/3b21a80f-2917-4650-a9ca-3e213afb26fc__IPAddressresults.txt
ISOresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/2cd44d83-e7e5-47be-9c80-03d9a2f4f710__ISOresults.txt
Networksresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/7661c962-f561-4e83-8b37-bc6676bc6808__Networksresults.txt
SecurityGroupsresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/2a2d8465-2f58-4049-ad93-f878c33d5faa__SecurityGroupsresults.txt
Snapshotresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/63ba74be-bc72-4419-8b7b-1fa788275be2__Snapshotresults.txt
Templatesresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/c51e1861-7137-4186-82c8-7e3c85a31905__Templatesresults.txt
Volumeresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/f1a11419-aa10-48e0-8291-ceb762d4a734__Volumeresults.txt
VPNCustomerGatewaysresults.txt
https://reviews.apache.org/media/uploaded/files/2014/11/05/4c8d2447-016e-49c0-9db2-b255625cd33f__VPNCustomerGatewaysresults.txt
Thanks,
Avinash Gautam