[GitHub] incubator-weex pull request #1015: [Android] Fix WebSocket operation on main...

[misakuo <gi...@git.apache.org>]

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/1015

    [Android] Fix WebSocket operation on main thread

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-bugfix-ws-callback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1015
    
----
commit 592c3405bcaecc1c9fc08ea4c3df3e61cf04f382
Author: misakuo <mi...@...>
Date:   2017-12-26T03:10:07Z

    * [android] bind ws callback to it's event listener

commit 78a6e67659fca8d83eb6d8e2fad5e13bd8a36a1a
Author: misakuo <mi...@...>
Date:   2017-12-28T07:27:32Z

    * [android] moving network operating to async thread

----


---

[GitHub] incubator-weex issue #1015: [Android] Fix WebSocket operation on main thread

[weex-bot <gi...@git.apache.org>]

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1015
  
    
    <!--
      0 failure: 
      2 warning:  No Changelog chan..., Potential BREAK C...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/appfram/websocket/WebSocketModule.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1015: [Android] Fix WebSocket operation on main...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1015


---