You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/15 12:33:54 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7324: [AIRFLOW-6704] Copy common TaskInstance attributes from Task

nuclearpinguin commented on a change in pull request #7324: [AIRFLOW-6704] Copy common TaskInstance attributes from Task
URL: https://github.com/apache/airflow/pull/7324#discussion_r379829017
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -888,13 +899,11 @@ def _run_raw_task(
         from airflow.sensors.base_sensor_operator import BaseSensorOperator
 
         task = self.task
-        self.pool = pool or task.pool
-        self.pool_slots = task.pool_slots
         self.test_mode = test_mode
+        self.refresh_from_task(task, pool_override=pool)
 
 Review comment:
   Is it needed here if we call `self.refresh_from_db` immediately? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services