You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/15 21:17:01 UTC
[GitHub] [accumulo] keith-turner opened a new issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
keith-turner opened a new issue #2272:
URL: https://github.com/apache/accumulo/issues/2272
**Describe the bug**
The property `manager.fate.threadpool.size`is listed as ZK mutable in the documentation implying that changes to it should cause changes in a running system. However looking at the following code that creates the thread pool, I can not find a place in the code that changes the thread pool size after its created.
https://github.com/apache/accumulo/blob/ba83d8fa26a8adc92ca0249780b1ddf9d7135d7a/core/src/main/java/org/apache/accumulo/fate/Fate.java#L228-L234
**Expected behavior**
The thread pool should dynamically resize or the documentation should be updated to indicate its not ZK mutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
Posted by GitBox <gi...@apache.org>.
keith-turner commented on issue #2272:
URL: https://github.com/apache/accumulo/issues/2272#issuecomment-922117892
@dlmarion there is still some work do to for this, so reopening it. The code does the following after it creates the thread pool, it executes a number of transactionrunner task equal to the pool size. Need to make this dynamic somehow also.
```java
for (int i = 0; i < numThreads; i++) {
executor.execute(new TransactionRunner());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #2272:
URL: https://github.com/apache/accumulo/issues/2272#issuecomment-923264015
@keith-turner - https://github.com/apache/accumulo/pull/2278 should include your latest comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion closed issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
Posted by GitBox <gi...@apache.org>.
dlmarion closed issue #2272:
URL: https://github.com/apache/accumulo/issues/2272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
Posted by GitBox <gi...@apache.org>.
keith-turner commented on issue #2272:
URL: https://github.com/apache/accumulo/issues/2272#issuecomment-922119524
Not sure how well this work work, was thinking of possibly doing the following to make the thread pool more dynamic.
* Modify TransactionRunner.run() removing the outer `while (keepRunning.get())` loop. So that when it runs, it only runs a single repo.
* Create the ThreadPool with a Queue that supplies an endless number of transactionrunners. So when a thread in the pool becomes idle and request a the next thing from the queue, it always returns a new transactionrunner object. This should respond more nicely to the number of threads changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion closed issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
Posted by GitBox <gi...@apache.org>.
dlmarion closed issue #2272:
URL: https://github.com/apache/accumulo/issues/2272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #2272: Fate thread pool property listed as ZK mutable but does not dynamically resize.
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #2272:
URL: https://github.com/apache/accumulo/issues/2272#issuecomment-922147529
I can look at this more on Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org