You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/12/11 20:17:54 UTC
Review Request 64505: Made the agent check for offer operation update
retries.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Local resource providers send all offer operation status updates
using the reosurce provider API. This patch makes the agent's
resource provider message handler skip operation updates when an
update is a retry.
Diffs
-----
src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235
Diff: https://reviews.apache.org/r/64505/diff/1/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/#review193463
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64504', '64505']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64505
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64505/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2316 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2338 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2248 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2270 ms total)
[----------] Global test environment tear-down
[==========] 825 tests from 84 test cases ran. (302671 ms total)
[ PASSED ] 815 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 204 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64505/logs/mesos-tests-stderr.log):
```
I1211 22:27:37.053275 6268 exec.cpp:237] Executor registered on agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0
I1211 22:27:37.056277 6424 executor.cpp:171] Received SUBSCRIBED event
I1211 22:27:37.060281 6424 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1211 22:27:37.060281 6424 executor.cpp:171] Received LAUNCH event
I1211 22:27:37.064281 6424 executor.cpp:637] Starting task f8f4f7fb-d1d9-4560-8eca-3048ab94455c
I1211 22:27:37.137276 6424 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1211 22:27:37.651247 6424 executor.cpp:650] Forked command at 692
I1211 22:27:37.678280 3592 exec.cpp:435] Executor asked to shutdown
I1211 22:27:37.679245 1392 executor.cpp:171] Received SHUTDOWN event
I1211 22:27:37.679245 1392 executor.cpp:747] Shutting down
I1211 22:27:37.679245 1392 executor.cpp:854] Sending SIGTERM to process tree at pid 69a739b4cb8-0000
I1211 22:27:37.677247 5132 master.cpp:10103] Updating the state of task f8f4f7fb-d1d9-4560-8eca-3048ab94455c of framework 7349bd91-4165-4e53-8e9d-592a739b4cb8-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1211 22:27:37.677247 7484 slave.cpp:3400] Shutting down framework 7349bd91-4165-4e53-8e9d-592a739b4cb8-0000
I1211 22:27:37.677247 7484 slave.cpp:6091] Shutting down executor 'f8f4f7fb-d1d9-4560-8eca-3048ab94455c' of framework 7349bd91-4165-4e53-8e9d-592a739b4cb8-0000 at executor(1)@10.3.1.5:63434
I1211 22:27:37.678280 7544 slave.cpp:909] Agent terminating
W1211 22:27:37.678280 7544 slave.cpp:3396] Ignoring shutdown framework 7349bd91-4165-4e53-8e9d-592a739b4cb8-0000 because it is terminating
I1211 22:27:37.679245 5132 master.cpp:10209] Removing task f8f4f7fb-d1d9-4560-8eca-3048ab94455c with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7349bd91-4165-4e53-8e9d-592a739b4cb8-0000 on agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0 at slave(326)@10.3.1.5:63413 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 22:27:37.681247 2424 containerizer.cpp:2328] Destroying container a5cfcaf1-87e2-4bbe-87bf-fbdc2f70ee49 in RUNNING state
I1211 22:27:37.681247 2424 containerizer.cpp:2930] Transitioning the state of container a5cfcaf1-87e2-4bbe-87bf-fbdc2f70ee49 from RUNNING to DESTROYING
I1211 22:27:37.682246 5132 master.cpp:1310] Agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0 at slave(326)@10.3.1.5:63413 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1211 22:27:37.682246 5132 master.cpp:3369] Disconnecting agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0 at slave(326)@10.3.1.5:63413 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 22:27:37.682246 5132 master.cpp:3388] Deactivating agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0 at slave(326)@10.3.1.5:63413 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 22:27:37.682246 2424 launcher.cpp:156] Asked to destroy container a5cfcaf1-87e2-4bbe-87bf-fbdc2f70ee49
I1211 22:27:37.683248 7272 hierarchical.cpp:344] Removed framework 7349bd91-4165-4e53-8e9d-592a739b4cb8-0000
I1211 22:27:37.683248 7272 hierarchical.cpp:762] Agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0 deactivated
I1211 22:27:37.707832 7484 containerizer.cpp:2779] Container a5cfcaf1-87e2-4bbe-87bf-fbdc2f70ee49 has exited
I1211 22:27:37.736832 7544 master.cpp:1152] Master terminating
I1211 22:27:37.738818 7484 hierarchical.cpp:605] Removed agent 7349bd91-4165-4e53-8e9d-592a739b4cb8-S0
I1211 22:27:38.039849 8292 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 11, 2017, 8:17 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64505/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 8:17 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Local resource providers send all offer operation status updates
> using the reosurce provider API. This patch makes the agent's
> resource provider message handler skip operation updates when an
> update is a retry.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235
>
>
> Diff: https://reviews.apache.org/r/64505/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 12, 2017, 1:08 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 7296-7298 (patched)
> > <https://reviews.apache.org/r/64505/diff/1/?file=1912670#file1912670line7296>
> >
> > Wondering if we should do this check in `updateOfferOperation`?
> >
> > What's the equality check for `OfferOperationStatus`? does the order in `Resources` matter?
> >
> > Also, wondering what we do for Tasks in this situation?
Yea I considered putting this in `updateOfferOperation` instead. In the absence of other motivations, I opted for what seems like better readability: the function `updateOfferOperation` is used to update the agent's representation of an offer operation, and if we don't need to update, then we don't call it at all. LMK what you think.
Regarding equality, I can update the patch to just check the `status_uuid`.
Regarding tasks, I'll quote here from our offline discussion:
"in the task case, the `Slave::forward` function is only responsible for sending the update, not updating the agent’s internal task state - the agent’s state is updated in the `statusUpdate` code path (which also calls `taskStatusUpdateManager->update()`).
in the offer operation case, the LRP’s forwarding function submits an agent call, and then the agent’s handler is responsible for _both_ sending the update message and updating the agent’s internal state.
thus, in the task case we don’t have this issue - the `statusUpdate` code path is only executed once for each update, whereas for offer operations the code path which updates the agent’s state is executed every time we forward an update, including retries."
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/#review193476
-----------------------------------------------------------
On Dec. 11, 2017, 8:17 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64505/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 8:17 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Local resource providers send all offer operation status updates
> using the reosurce provider API. This patch makes the agent's
> resource provider message handler skip operation updates when an
> update is a retry.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235
>
>
> Diff: https://reviews.apache.org/r/64505/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/#review193476
-----------------------------------------------------------
src/slave/slave.cpp
Lines 7296-7298 (patched)
<https://reviews.apache.org/r/64505/#comment272033>
Wondering if we should do this check in `updateOfferOperation`?
What's the equality check for `OfferOperationStatus`? does the order in `Resources` matter?
Also, wondering what we do for Tasks in this situation?
- Jie Yu
On Dec. 11, 2017, 8:17 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64505/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 8:17 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Local resource providers send all offer operation status updates
> using the reosurce provider API. This patch makes the agent's
> resource provider message handler skip operation updates when an
> update is a retry.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235
>
>
> Diff: https://reviews.apache.org/r/64505/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/#review193613
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64504', '64505']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64505
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64505/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2271 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2293 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2264 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2286 ms total)
[----------] Global test environment tear-down
[==========] 829 tests from 84 test cases ran. (307997 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 204 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64505/logs/mesos-tests-stderr.log):
```
I1212 22:17:18.174181 7592 executor.cpp:171] Received SUBSCRIBED event
I1212 22:17:18.178182 7592 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1212 22:17:18.179183 7592 executor.cpp:171] Received LAUNCH event
I1212 22:17:18.182238 7592 executor.cpp:637] Starting task f6154322-8991-4748-aa62-3077933118d2
I1212 22:17:18.255249 7592 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1212 22:17:18.778175 7592 executor.cpp:650] Forked command at 4108
I1212 22:17:18.803174 4760 exec.cpp:435] Executor asked to shutdown
I1212 22:17:18.804172 2264 executor.cpp:171] Received SHUTDOWN event
I1212 22:17:18.804172 2264 executor.cpp:747] Shutting down
I1212 22:17:18.804172 2264 executor.cpp:854] Sending SIGTERM to process tree at pid 41172 1536 master.cpp:3327] Deactivating framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000 (default) at scheduler-6e9f27ea-7c29-4ead-80e1-71cce262173a@10.3.1.5:50490
I1212 22:17:18.802269 7016 hierarchical.cpp:405] Deactivated framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000
I1212 22:17:18.802269 1536 master.cpp:10146] Updating the state of task f6154322-8991-4748-aa62-3077933118d2 of framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1212 22:17:18.802269 8568 slave.cpp:3400] Shutting down framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000
I1212 22:17:18.802269 8568 slave.cpp:6091] Shutting down executor 'f6154322-8991-4748-aa62-3077933118d2' of framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000 at executor(1)@10.3.1.5:50512
I1212 22:17:18.803174 6636 slave.cpp:909] Agent terminating
W1212 22:17:18.803174 6636 slave.cpp:3396] Ignoring shutdown framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000 because it is terminating
I1212 22:17:18.804172 1536 master.cpp:10252] Removing task f6154322-8991-4748-aa62-3077933118d2 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000 on agent c037d5f3-ab72-4df4-b368-8a2ad739ba7d-S0 at slave(326)@10.3.1.5:50490 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 22:17:18.806172 444 containerizer.cpp:2328] Destroying container 20fe4ee8-e897-43c6-b64f-0e5ee570cb1d in RUNNING state
I1212 22:17:18.806172 444 containerizer.cpp:2930] Transitioning the state of container 20fe4ee8-e897-43c6-b64f-0e5ee570cb1d from RUNNING to DESTROYING
I1212 22:17:18.807173 1536 master.cpp:1305] Agent c037d5f3-ab72-4df4-b368-8a2ad739ba7d-S0 at slave(326)@10.3.1.5:50490 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1212 22:17:18.807173 1536 master.cpp:3364] Disconnecting agent c037d5f3-ab72-4df4-b368-8a2ad739ba7d-S0 at slave(326)@10.3.1.5:50490 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 22:17:18.807173 444 launcher.cpp:156] Asked to destroy container 20fe4ee8-e897-43c6-b64f-0e5ee570cb1d
I1212 22:17:18.808172 5984 hierarchical.cpp:344] Removed framework c037d5f3-ab72-4df4-b368-8a2ad739ba7d-0000
I1212 22:17:18.808172 1536 master.cpp:3383] Deactivating agent c037d5f3-ab72-4df4-b368-8a2ad739ba7d-S0 at slave(326)@10.3.1.5:50490 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 22:17:18.808172 3948 hierarchical.cpp:766] Agent c037d5f3-ab72-4df4-b368-8a2ad739ba7d-S0 deactivated
I1212 22:17:18.832271 1536 containerizer.cpp:2779] Container 20fe4ee8-e897-43c6-b64f-0e5ee570cb1d has exited
I1212 22:17:18.860319 6636 master.cpp:1147] Master terminating
I1212 22:17:18.862324 96 hierarchical.cpp:609] Removed agent c037d5f3-ab72-4df4-b368-8a2ad739ba7d-S0
I1212 22:17:19.173296 8012 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 12, 2017, 9:22 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64505/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 9:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Local resource providers send all offer operation status updates
> using the reosurce provider API. This patch makes the agent's
> resource provider message handler skip operation updates when an
> update is a retry.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 5869e73ca1c14c99e580da9d7375181da2073ec5
>
>
> Diff: https://reviews.apache.org/r/64505/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/#review193750
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 14, 2017, 1:31 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64505/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:31 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Local resource providers send all offer operation status updates
> using the reosurce provider API. This patch makes the agent's
> resource provider message handler skip operation updates when an
> update is a retry.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
>
>
> Diff: https://reviews.apache.org/r/64505/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/
-----------------------------------------------------------
(Updated Dec. 14, 2017, 1:31 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Local resource providers send all offer operation status updates
using the reosurce provider API. This patch makes the agent's
resource provider message handler skip operation updates when an
update is a retry.
Diffs (updated)
-----
src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
Diff: https://reviews.apache.org/r/64505/diff/3/
Changes: https://reviews.apache.org/r/64505/diff/2-3/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 64505: Made the agent check for offer operation
update retries.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/
-----------------------------------------------------------
(Updated Dec. 12, 2017, 9:22 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Local resource providers send all offer operation status updates
using the reosurce provider API. This patch makes the agent's
resource provider message handler skip operation updates when an
update is a retry.
Diffs (updated)
-----
src/slave/slave.cpp 5869e73ca1c14c99e580da9d7375181da2073ec5
Diff: https://reviews.apache.org/r/64505/diff/2/
Changes: https://reviews.apache.org/r/64505/diff/1-2/
Testing
-------
make check
Thanks,
Greg Mann