You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "mks2183 (via GitHub)" <gi...@apache.org> on 2023/07/15 21:01:26 UTC
[GitHub] [nuttx] mks2183 opened a new pull request, #9838: driver/audio: remove unnecessary switch in switch
mks2183 opened a new pull request, #9838:
URL: https://github.com/apache/nuttx/pull/9838
## Summary
There is unnecessary switch inside switch which is making code not too readable.
## Impact
There is no impact as it's just a minor cleanup.
## Testing
There is no testing conducted for this test so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9838: driver/audio: remove unnecessary switch in switch
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9838:
URL: https://github.com/apache/nuttx/pull/9838#issuecomment-1636890705
Thank you @mks2183 ! Please include the message you wrote in the Summary in the commit message log, you can use git amend and then git push -f to update your branch and this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9838: driver/audio: remove unnecessary switch in switch
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9838:
URL: https://github.com/apache/nuttx/pull/9838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] mks2183 commented on pull request #9838: driver/audio: remove unnecessary switch in switch
Posted by "mks2183 (via GitHub)" <gi...@apache.org>.
mks2183 commented on PR #9838:
URL: https://github.com/apache/nuttx/pull/9838#issuecomment-1637063685
Thanks Sir @acassis @xiaoxiang781216 @mu578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] mks2183 commented on pull request #9838: driver/audio: remove unnecessary switch in switch
Posted by "mks2183 (via GitHub)" <gi...@apache.org>.
mks2183 commented on PR #9838:
URL: https://github.com/apache/nuttx/pull/9838#issuecomment-1636892020
Sir Alan @acassis,
Since, the length of the summary is too long and breaching column limit, so I added in subsection.
Regards,
Manish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] mu578 commented on pull request #9838: driver/audio: remove unnecessary switch in switch
Posted by "mu578 (via GitHub)" <gi...@apache.org>.
mu578 commented on PR #9838:
URL: https://github.com/apache/nuttx/pull/9838#issuecomment-1636948279
A little code styling trick (works with colons two doesn't cost and you immediately regain human readability)
```c
caps->ac_controls.hw[0] = (
AUDIO_SAMP_RATE_8K
| AUDIO_SAMP_RATE_11K
| AUDIO_SAMP_RATE_16K
| AUDIO_SAMP_RATE_22K
| AUDIO_SAMP_RATE_32K
| AUDIO_SAMP_RATE_44K
| AUDIO_SAMP_RATE_48K
| AUDIO_SAMP_RATE_96K
| AUDIO_SAMP_RATE_128K
| UDIO_SAMP_RATE_160K
| AUDIO_SAMP_RATE_172K
| AUDIO_SAMP_RATE_192K
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org