You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nikam14 (via GitHub)" <gi...@apache.org> on 2023/04/12 10:29:04 UTC
[GitHub] [eventmesh] nikam14 opened a new pull request, #3704: fixes #3246
nikam14 opened a new pull request, #3704:
URL: https://github.com/apache/eventmesh/pull/3704
made the changes mentioned in the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] nikam14 commented on pull request #3704: fixes #3246
Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 commented on PR #3704:
URL: https://github.com/apache/eventmesh/pull/3704#issuecomment-1505045157
It fixes #3646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3704: fixes #3246
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3704:
URL: https://github.com/apache/eventmesh/pull/3704#discussion_r1165055509
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/EventMeshCloudEventWriter.java:
##########
@@ -25,14 +25,14 @@
public class EventMeshCloudEventWriter implements CloudEventContextWriter {
- private Map<String, Object> extensionMap = null;
+ private Map<String, Object> extensionMap;
public EventMeshCloudEventWriter() {
extensionMap = new HashMap<String, Object>();
}
@Override
- public CloudEventContextWriter withContextAttribute(String key, String value)
+ public CloudEventContextWriter withContextAttribute(@Nullable String key, @Nullable String value)
Review Comment:
Missing import:
import javax.annotation.Nullable;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] nikam14 commented on a diff in pull request #3704: fixes #3246
Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 commented on code in PR #3704:
URL: https://github.com/apache/eventmesh/pull/3704#discussion_r1166342627
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/EventMeshCloudEventWriter.java:
##########
@@ -25,14 +25,14 @@
public class EventMeshCloudEventWriter implements CloudEventContextWriter {
- private Map<String, Object> extensionMap = null;
+ private Map<String, Object> extensionMap;
public EventMeshCloudEventWriter() {
extensionMap = new HashMap<String, Object>();
}
@Override
- public CloudEventContextWriter withContextAttribute(String key, String value)
+ public CloudEventContextWriter withContextAttribute(@Nullable String key, @Nullable String value)
Review Comment:
thank you for help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3704: fixes #3246
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3704:
URL: https://github.com/apache/eventmesh/pull/3704#discussion_r1172233791
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/EventMeshCloudEventWriter.java:
##########
@@ -25,14 +25,14 @@
public class EventMeshCloudEventWriter implements CloudEventContextWriter {
- private Map<String, Object> extensionMap = null;
+ private Map<String, Object> extensionMap;
public EventMeshCloudEventWriter() {
extensionMap = new HashMap<String, Object>();
}
@Override
- public CloudEventContextWriter withContextAttribute(String key, String value)
+ public CloudEventContextWriter withContextAttribute(@Nullable String key, @Nullable String value)
Review Comment:
Sorry, I made a mistake here, it should read `@Nonnull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] nikam14 closed pull request #3704: fixes #3246
Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 closed pull request #3704: fixes #3246
URL: https://github.com/apache/eventmesh/pull/3704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org