You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/16 02:20:35 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages

clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-614375921
 
 
   I was thinking about... I need this as part of this release.
   
   the change you made here wouldn't break the compatibility if released now... but it would break if released later.
   
   up till now we didn't have any other type of large messages...
   so if we release now, the byte(2) on PagedMessages would make a lot of sense...
   
   
   if we released later, we would have to deal with previous versions where you may have AMQPLargeMessage with byte(1), while this PR is expecting byte(2).
   
   so, I am merging this now.
   
   
   Besides I have a full pass on this PR as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services