[jira] [Commented] (YARN-9129) Ensure flush after printing to stderr plus additional cleanup

["Jason Lowe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723124#comment-16723124 ] 

Jason Lowe commented on YARN-9129:
----------------------------------

bq. we added several fprintf(stderr calls, but the convention in container-executor.c appears to be fprintf(ERRORFILE followed by fflush(ERRORFILE).

stderr is unbuffered, so the fflush calls seem unnecessary to me.


> Ensure flush after printing to stderr plus additional cleanup
> -------------------------------------------------------------
>
>                 Key: YARN-9129
>                 URL: https://issues.apache.org/jira/browse/YARN-9129
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Priority: Major
>             Fix For: 3.3.0
>
>
> Following up on findings in YARN-8962, I noticed the following issues in container-executor and main.c:
> - There seem to be some vars that are not cleaned up in container_executor:
> In run_docker else: free docker_binary
> In exec_container:
>   before return INVALID_COMMAND_FILE: free docker_binary
>   3x return DOCKER_EXEC_FAILED: set exit code and goto cleanup instead
>   cleanup needed before exit calls?
> - In YARN-8777 we added several fprintf(stderr calls, but the convention in container-executor.c appears to be fprintf(ERRORFILE followed by fflush(ERRORFILE).
> - There are leaks in TestDockerUtil_test_add_ports_mapping_to_command_Test.
> - There are additional places where flush is not performed after writing to stderr, including main.c display_feature_disabled_message. This can result in the client not receiving the error message if the connection is closed too quickly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org