You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "24kpure (via GitHub)" <gi...@apache.org> on 2023/05/29 09:08:14 UTC

[GitHub] [dubbo] 24kpure commented on issue #12350: org.apache.dubbo.config.spring.util.DubboAnnotationUtils#convertParameters中当参数列表未空时,直接返回了不可修改的Collections.emptyMap(),我认为不合适

24kpure commented on issue #12350:
URL: https://github.com/apache/dubbo/issues/12350#issuecomment-1566803252

   抱歉给您带来的困扰,我是这段代码的作者,聊聊个人想法
   1.空Map倾向于使用Collections.emptyMap(),更优雅,性能的角度也更好,潜在缺点是不可编辑。这个场景是解析注解的参数,所以返回不可编辑的map也可以被认为是合理的。
   2.您的业务场景是什么?如果需要修改parameter属性,建议在配置中心加载前处理,尽可能前置,在流程中改注解配置可能会带来其它意想不到的问题?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org