You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by sb...@apache.org on 2019/06/22 21:58:19 UTC

[arrow] branch master updated: ARROW-5693: [Go] skip IPC integration tests for Decimal128

This is an automated email from the ASF dual-hosted git repository.

sbinet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 3533213  ARROW-5693: [Go] skip IPC integration tests for Decimal128
3533213 is described below

commit 3533213cd57cf09b96dbc862db8d18dc1fbd1ad4
Author: Sebastien Binet <bi...@cern.ch>
AuthorDate: Sat Jun 22 23:58:07 2019 +0200

    ARROW-5693: [Go] skip IPC integration tests for Decimal128
    
    Author: Sebastien Binet <bi...@cern.ch>
    
    Closes #4659 from sbinet/issue-5693 and squashes the following commits:
    
    4f206d07f <Sebastien Binet> ARROW-5693:  skip IPC integration tests for Decimal128
---
 go/arrow/internal/arrjson/arrjson_test.go                 | 3 +++
 go/arrow/ipc/cmd/arrow-json-integration-test/main_test.go | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/go/arrow/internal/arrjson/arrjson_test.go b/go/arrow/internal/arrjson/arrjson_test.go
index 61dfd53..53a0cf4 100644
--- a/go/arrow/internal/arrjson/arrjson_test.go
+++ b/go/arrow/internal/arrjson/arrjson_test.go
@@ -30,6 +30,9 @@ import (
 func TestReadWrite(t *testing.T) {
 	for name, recs := range arrdata.Records {
 		t.Run(name, func(t *testing.T) {
+			if name == "decimal128" {
+				t.Skip() // FIXME(sbinet): implement full decimal128 support
+			}
 			mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
 			defer mem.AssertSize(t, 0)
 
diff --git a/go/arrow/ipc/cmd/arrow-json-integration-test/main_test.go b/go/arrow/ipc/cmd/arrow-json-integration-test/main_test.go
index a7604a8..559f6db 100644
--- a/go/arrow/ipc/cmd/arrow-json-integration-test/main_test.go
+++ b/go/arrow/ipc/cmd/arrow-json-integration-test/main_test.go
@@ -29,6 +29,9 @@ func TestIntegration(t *testing.T) {
 	const verbose = true
 	for name, recs := range arrdata.Records {
 		t.Run(name, func(t *testing.T) {
+			if name == "decimal128" {
+				t.Skip() // FIXME(sbinet): implement full decimal128 support
+			}
 			mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
 			defer mem.AssertSize(t, 0)