You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/08 12:18:09 UTC

[GitHub] [cloudstack] soreana opened a new pull request #4253: Fix sed command failure in Mac OS.

soreana opened a new pull request #4253:
URL: https://github.com/apache/cloudstack/pull/4253


   ## Description
   
   apidoc build failed in Mac OS because of sed in-place command. It is a minor change that fixed this issue. More information  [here](https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux?answertab=active#tab-top)
   
   Fixes: #3247
   Fixes: #3312
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   I tested this feature in Mac and Ubuntu
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4253: Fix sed command failure in Mac OS.

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4253:
URL: https://github.com/apache/cloudstack/pull/4253


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4253: Fix sed command failure in Mac OS.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4253:
URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671189647


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4253: Fix sed command failure in Mac OS.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4253:
URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671208788


   LGTM travis and build (on Linux) passes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4253: Fix sed command failure in Mac OS.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4253:
URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671189204


   @blueorangutan package 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4253: Fix sed command failure in Mac OS.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4253:
URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671199939


   Packaging result: ✔centos7 ✔debian. JID-1690


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org