[GitHub] [druid] clintropolis commented on a change in pull request #11376: define superuser permissions set in druid-server instead of druid-basic-auth extension

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11376:
URL: https://github.com/apache/druid/pull/11376#discussion_r656522356



##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -359,6 +359,51 @@ public static Access authorizeAllResourceActions(
     return filteredResources;
   }
 
+  public static List<ResourceAction> makeSuperUserPermissions()
+  {
+    ResourceAction datasourceR = new ResourceAction(
+        new Resource(".*", ResourceType.DATASOURCE),

Review comment:
       I thought about that, but anything I could think to name it would be more characters than the pattern, and the pattern seems unlikely to change for this use case, so ended up leaving it like it was. I don't feel very strongly about it though so can change it too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org