You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 08:05:15 UTC

[GitHub] [flink] dawidwys commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible

dawidwys commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible
URL: https://github.com/apache/flink/pull/10829#issuecomment-573548100
 
 
   Hi @xintongsong,
   I am positive that in the docs we should always print only the exact value.
   
   I don't have enough expertise in other places, but personally I am a bit sceptical if it is a good idea to print approximated values. I am fine adjusting my PR so that this logic is used only in the docs, if the approximation is prefferred for the `toString` method.
   
   @azagrebin @tillrohrmann What is your opinion?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services