[jira] [Commented] (METRON-1589) '/api/v1/search/search' fails when 'Solr Zookeeper Urls' has comma separated multiple zookeeper urls

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496525#comment-16496525 ] 

ASF GitHub Bot commented on METRON-1589:
----------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1040

    METRON-1589: '/api/v1/search/search' fails when 'Solr Zookeeper Urls' has comma separated multiple zookeeper urls

    ## Contributor Comments
    Refactored `SolrDao` to kill `getZkHost` and made it `getZkHosts` and return a `List`. `getSolrClient` now takes a `List<String>`, and passes it down.
    
    I also added a `getSolrClient` method that's just blank, and defers to the `getZkHosts` method.  Our calls to `getSolrClient` are generally `solrDao.getSolrClient(solrDao.getZkHosts)`, which seems unnecessary. I did not however, change everything to use that, but I could definitely be persuaded to as part of this.
    
    Additionally, `SolrColumnMetadataDao` now takes a` SolrClient` instead of a Zookeeper host string, to make it consistent with the other DAOs.
    
    There's one catch however: I haven't integration tested this, because I'd need multiple Zk nodes and we don't really have a clean way to get it (neither the `SolrComponent` or `ZkComponent` really let you do it).  I'm not sure if we want or need those tests, or if alternatively we want to spin up a multinode environment and manually test, or if we're fine just assuming things line up (given that it's really testing if the underlying method works as expected at this point). There are unit tests agains the methods to ensure splitting is handled properly in the methods.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron commaSeparatedZK

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1040
    
----
commit f2dcec68269db86f9e53f931e4e5e000a1626432
Author: justinjleet <ju...@...>
Date:   2018-05-25T13:40:10Z

    Initial change

----


> '/api/v1/search/search' fails when 'Solr Zookeeper Urls' has comma separated multiple zookeeper urls
> ----------------------------------------------------------------------------------------------------
>
>                 Key: METRON-1589
>                 URL: https://issues.apache.org/jira/browse/METRON-1589
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> http://metronnode:8082/api/v1/search/search with below payload fails with internal server error when 'Solr Zookeeper Urls' has comma separated multiple zookeeper urls
> {code:java}
> {
>  "indices": [],
>  "facetFields": [],
>  "query": "*",
>  "from": 0,
>  "size": 25
> }
> {code}
> {code:java}
> {"responseCode":500,"message":"Cannot connect to cluster at ctr-e138-1518143905142-328005-01-000006.hwx.site:2181/solr,ctr-e138-1518143905142-328005-01-000005.hwx.site:2181/solr: cluster not found/not ready","fullMessage":"SolrException: Cannot connect to cluster at ctr-e138-1518143905142-328005-01-000006.hwx.site:2181/solr,ctr-e138-1518143905142-328005-01-000005.hwx.site:2181/solr: cluster not found/not ready"}
> {code}
>  
> This appears to result from here [SolrDao.java#L137-L144|https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrDao.java#L137-L144]
> In `getSolrClient`, `withZkHost` should be called multiple times after splitting the comma delimited string, per [CloudSolrClient.Builder#withZkHost|https://lucene.apache.org/solr/6_5_0/solr-solrj/org/apache/solr/client/solrj/impl/CloudSolrClient.Builder.html#withZkHost-java.lang.String-].
> Overall, this could probably be done a couple ways, either to just split the String directly, or rearrange the methods to pass around Lists and have `getZkHost` be changed to `getZkHosts` and take care of it in a more contained manner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)