You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "josh-fell (via GitHub)" <gi...@apache.org> on 2023/02/17 15:54:54 UTC
[GitHub] [airflow] josh-fell commented on a diff in pull request #29586: fix template_fields in the decorator `task.docker`
josh-fell commented on code in PR #29586:
URL: https://github.com/apache/airflow/pull/29586#discussion_r1110006502
##########
airflow/providers/docker/decorators/docker.py:
##########
@@ -77,7 +77,7 @@ class _DockerDecoratedOperator(DecoratedOperator, DockerOperator):
custom_operator_name = "@task.docker"
- template_fields: Sequence[str] = ("op_args", "op_kwargs")
+ template_fields: Sequence[str] = tuple({"op_args", "op_kwargs"} | set(DockerOperator.template_fields))
Review Comment:
```suggestion
template_fields: Sequence[str] = (*DockerOperator.template_fields, "op_args", "op_kwargs")
```
Small optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org