You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/03/28 00:54:43 UTC

[GitHub] [incubator-openwhisk-client-go] masnnuller opened a new pull request #121: Add omit tag to ErrorResponse.Response field

masnnuller opened a new pull request #121: Add omit tag to ErrorResponse.Response field
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/121
 
 
   In the following code, `resp` is overwritten by `activation.response` field when called `d.Decode(&errorResponse)`. So `resp.StatusCode` is changed to activation's status code, not HTTP response status code. This causes `parseApplicationError` never calls when parsing action developer error activation.
   
   https://github.com/apache/incubator-openwhisk-client-go/blob/4286a8212a74c40d8950ee76681a67e12c9bf1a0/whisk/client.go#L557-L569
   
   This PR changes to ignore `ErrorResponse.Response` field on parsing.
   
   - [x] I have signed a CLA

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services