You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/17 20:32:56 UTC
[GitHub] [nifi] markap14 commented on a diff in pull request #6310: NIFI-10366: Make Default Run Duration configurable
markap14 commented on code in PR #6310:
URL: https://github.com/apache/nifi/pull/6310#discussion_r948385921
##########
nifi-api/src/main/java/org/apache/nifi/annotation/behavior/SupportsBatching.java:
##########
@@ -47,5 +47,5 @@
@Retention(RetentionPolicy.RUNTIME)
@Inherited
public @interface SupportsBatching {
-
+ RunDuration duration() default RunDuration.ZERO_MILLIS;
Review Comment:
We should probably call this `defaultDuration` or `defaultRunDuration`, rather than just `duration`. Can we also add some JavaDocs here to explain exactly what happens when this value is set?
##########
nifi-api/src/main/java/org/apache/nifi/annotation/behavior/RunDuration.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.annotation.behavior;
+
+public enum RunDuration {
+ ZERO_MILLIS(0),
Review Comment:
Perhaps it makes sense to call this `NO_BATCHING`? Will leave it up to you, if you think `ZERO_MILLIS` works better than `NO_BATCHING` that's fine, just wanted to make the suggestion
##########
nifi-api/src/main/java/org/apache/nifi/annotation/behavior/RunDuration.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.annotation.behavior;
+
+public enum RunDuration {
+ ZERO_MILLIS(0),
+ TWENTY_FIVE_MILLIS(25),
+ FIFTY_MILLIS(50),
+ ONE_HUNDRED_MILLIS(100),
+ TWO_HUNDRED_FIFTY_MILLIS(250),
+ FIVE_HUNDRED_MILLIS(500),
+ ONE_SECONDS(1000),
Review Comment:
Should probably use `ONE_SECOND` rather than `ONE_SECONDS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org