[GitHub] [arrow] 9prady9 commented on pull request #12080: ARROW-15118: [C++] Avoid bitmap buffer if all inputs are all valid for Scalar Kernels

[GitBox <gi...@apache.org>]

9prady9 commented on pull request #12080:
URL: https://github.com/apache/arrow/pull/12080#issuecomment-1049507634


   I have been able to successfully avoid bitmap allocation for the case where null handling is `INTERSECTION` and all input Datums have all valid values. One simple test case has been added for cast kernel, I would think adding such tests for all compute functions would be prudent.
   
   I did however encounter one unexpected error when in an existing unit test `TestCallScalarFunction.PreallocationCases`. At this moment, I am not sure why a modified context would change Datum kind. Please see the error message of test failure 
   ```
   /home/pradeep/gitroot/ArrowWorkspace/worktrees/15118/cpp/src/arrow/datum.cc:71:  
   Check failed: (Datum::ARRAY) == (this->kind()) 
   ```
   This is triggered from line 789 of `exec_test.cc`. There is an identical test just few lines above where context argument isn't passed along and that runs fine.
   
   Any hints at what I am missing here is appreciated. Thank you!
   
   Command to run the specific test to see the problem on my branch is given below:
   
   ```
   ./debug/arrow-compute-internals-test --gtest_filter=TestCallScalarFunction.PreallocationCases
   ```
   assuming build type is `debug`
   
   @lidavidm  @edponce 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org