You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by "Robert S. Sfeir" <ro...@codepuccino.com> on 2003/12/04 00:23:09 UTC
Patches?
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi all,
I haven't seen anything come across to tell me my suggested and
submitted patches have been implemented. Kind of discouraging. I know
it takes time, but I was hoping that someone would be able to implement
some of them so I can feel like I am contributing. It would kind of
suck to spend a lot of time implementing changes and cleanups without
getting someone to commit them. :-\
Thanks
R
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE/znBd+cV9vuB27SARAsIwAKCv38fRoSqMa/2Pi/7OevM6ApUfVgCgp8eI
7d5i7dV034+qDOQGq4m0d3g=
=13r+
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Patches?
Posted by "Robert S. Sfeir" <ro...@codepuccino.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thomas I used WinCVS to generate the patches perhaps I need to use
cvs.exe to do it. Sorry it's a mess and thanks for looking at it.
Will re generate later and repost. This is a rookie thing :-)
R
Thomas Mahler wrote:
| Hi Robert,
|
| I had a look at your two patches.
| The first regarding println and usage of Boolean.
| And the second patch to DBUtility.
|
| I'd like to apply your patches, but unfortunately the patch format
| you've used does not work for me :-(
|
| I've tried to apply the patch with eclipse, but eclipse tells that your
| stuff is not a valid patch format.
|
| Then I've tried to use the commanline tool "patch".
| I get errors like:
| patch: **** '>' expected at line 12 of patch
|
| or
|
| Hunk #1 FAILED at 128.
| ...
| 3 out of 3 hunks FAILED -- saving rejected to file ...
|
| which tool did you use to generate the patches?
| would you mind to use eclipse to regenerate the patch and to resubmit
them?
| to speed up thinngs you can also post the patches directly to my
| thma@apache.org account.
|
| cu,
| thomas
|
|
| Robert S. Sfeir wrote:
|
|> Hi all,
|>
|> I haven't seen anything come across to tell me my suggested and
|> submitted patches have been implemented. Kind of discouraging. I know
|> it takes time, but I was hoping that someone would be able to implement
|> some of them so I can feel like I am contributing. It would kind of
|> suck to spend a lot of time implementing changes and cleanups without
|> getting someone to commit them. :-\
|>
|> Thanks
|> R
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
| For additional commands, e-mail: ojb-dev-help@db.apache.org
|
|
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
| For additional commands, e-mail: ojb-dev-help@db.apache.org
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE/zyxt+cV9vuB27SARAu4sAJ99vAMPhyCfWzVFjceqpuV6nIdLwACg0R9y
dItHHPBNwKS8arw20Faac5I=
=IfJf
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Patches?
Posted by Thomas Mahler <th...@web.de>.
Hi Robert,
I had a look at your two patches.
The first regarding println and usage of Boolean.
And the second patch to DBUtility.
I'd like to apply your patches, but unfortunately the patch format
you've used does not work for me :-(
I've tried to apply the patch with eclipse, but eclipse tells that your
stuff is not a valid patch format.
Then I've tried to use the commanline tool "patch".
I get errors like:
patch: **** '>' expected at line 12 of patch
or
Hunk #1 FAILED at 128.
...
3 out of 3 hunks FAILED -- saving rejected to file ...
which tool did you use to generate the patches?
would you mind to use eclipse to regenerate the patch and to resubmit them?
to speed up thinngs you can also post the patches directly to my
thma@apache.org account.
cu,
thomas
Robert S. Sfeir wrote:
> Hi all,
>
> I haven't seen anything come across to tell me my suggested and
> submitted patches have been implemented. Kind of discouraging. I know
> it takes time, but I was hoping that someone would be able to implement
> some of them so I can feel like I am contributing. It would kind of
> suck to spend a lot of time implementing changes and cleanups without
> getting someone to commit them. :-\
>
> Thanks
> R
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Patches?
Posted by Thomas Mahler <th...@web.de>.
Hi Robert,
Of course we are interested in all patches. Normally patches will be
reviewed and worked on with high priority, as we want give patch
contributors a positive feed-back and encourage everybody to post more
of them.
Thus I'm very sorry that it did not work for you. We don't want to
discourage you to contribute more stuff of course. I think it simply was
a mishap...
I'll review your stuff ASAP!
thanks for your patience with us lazy guys,
Thomas
Robert S. Sfeir wrote:
> Hi all,
>
> I haven't seen anything come across to tell me my suggested and
> submitted patches have been implemented. Kind of discouraging. I know
> it takes time, but I was hoping that someone would be able to implement
> some of them so I can feel like I am contributing. It would kind of
> suck to spend a lot of time implementing changes and cleanups without
> getting someone to commit them. :-\
>
> Thanks
> R
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org