[PR] fix: handle stale TID in VLE path materialization after DETACH DELETE (#2549) [age]

["waterWang (via GitHub)" <gi...@apache.org>]

waterWang opened a new pull request, #2550:
URL: https://github.com/apache/age/pull/2550

   Fixes #2549
   
   When a VLE path is bound via MATCH p = ... and the bound vertices are
   subsequently DETACH DELETE'd, RETURN p raises an internal stale-TID
   error because the VLE path materializer (build_path) lazily fetches
   vertex/edge properties via heap_fetch after the underlying tuples have
   been deleted.
   
   This commit adds tolerant variants of get_vertex_entry_properties and
   get_edge_entry_properties that return an empty properties object ({})
   when the stored TID no longer resolves to a visible tuple, allowing
   the path to be projected with the vertex present but its properties
   empty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: handle stale TID in VLE path materialization after DETACH DELETE (#2549) [age]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #2550:
URL: https://github.com/apache/age/pull/2550#discussion_r3846053725


##########
regress/sql/cypher_vle.sql:
##########
@@ -487,6 +487,26 @@ $$) AS (person agtype, friend agtype);
 
 SELECT drop_graph('issue_2382', true);
 
+--
+-- Issue #2549: VLE path + DETACH DELETE + RETURN p should not raise
+-- stale TID error.  When the path's bound vertices are deleted before
+-- the path datum is materialized, build_path must tolerate the stale
+-- TID and return the path with empty properties ({}) for the deleted
+-- entities.

Review Comment:
   The new test comment says the deleted entities should return with empty properties ({}), but the expected output below shows some deleted vertices still have their original properties (e.g., {"id": 1}/{"id": 2}/{"id": 3}). Consider rewording the comment to match the actual behavior being asserted here: projection should not error, and any vertex/edge whose stored TID is no longer visible should materialize with empty properties ({}).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: handle stale TID in VLE path materialization after DETACH DELETE (#2549) [age]

["jrgemignani (via GitHub)" <gi...@apache.org>]

jrgemignani commented on PR #2550:
URL: https://github.com/apache/age/pull/2550#issuecomment-5401316327

   @waterWang While I appreciate the work, you need to make the results consistent with what they were before, otherwise this will only add confusion. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org