[GitHub] [spark] cloud-fan commented on a diff in pull request #37322: [SPARK-39905][SQL][TESTS] Remove `checkErrorClass()` and use `checkError()` instead

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37322:
URL: https://github.com/apache/spark/pull/37322#discussion_r932202674


##########
sql/core/src/test/scala/org/apache/spark/sql/DatasetUnpivotSuite.scala:
##########
@@ -305,14 +305,17 @@ class DatasetUnpivotSuite extends QueryTest
           valueColumnName = "val"
         )
     }
-    checkErrorClass(
+    checkError(
       exception = e,
       errorClass = "UNPIVOT_VALUE_DATA_TYPE_MISMATCH",
-      msg = "Unpivot value columns must share a least common type, some types do not: \\[" +
-        "\"STRING\" \\(`str1#\\d+`\\), " +
-        "\"INT\" \\(`int1#\\d+`, `int2#\\d+`, `int3#\\d+`, ...\\), " +
-        "\"BIGINT\" \\(`long1#\\d+L`, `long2#\\d+L`\\)\\];(\n.*)*",
-      matchMsg = true)
+      errorSubClass = None,
+      sqlState = None,

Review Comment:
   Does `checkError` provide default parameter value for `errorSubClass` and `sqlState`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org