You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/05/06 20:08:46 UTC
Review Request: (CLOUDSTACK-2322) update network.gateway to fix deployVm
error on SharedNetwork after ipv6 support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10955/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
The allocateDirectIp in NetworkManagerImpl.java changes after ipv6 support.
Two sentences were added before assignPublicIP.
(1) if (network.getGateway() != null)
(2) if (network.getIp6Gateway() != null) {
However, for Shared Network, both fields are null in table `cloud`.`networks`.
Some fields in table `cloud`.`networks` need to be updated.
This addresses bug CLOUDSTACK-2322.
Diffs
-----
setup/db/db/schema-40to410.sql fe53d36
Diff: https://reviews.apache.org/r/10955/diff/
Testing
-------
Testing ok.
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-2322) update network.gateway to fix deployVm
error on SharedNetwork after ipv6 support
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10955/#review20222
-----------------------------------------------------------
Ship it!
Ship It!
- Chip Childers
On May 6, 2013, 6:08 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10955/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> The allocateDirectIp in NetworkManagerImpl.java changes after ipv6 support.
> Two sentences were added before assignPublicIP.
> (1) if (network.getGateway() != null)
> (2) if (network.getIp6Gateway() != null) {
> However, for Shared Network, both fields are null in table `cloud`.`networks`.
> Some fields in table `cloud`.`networks` need to be updated.
>
>
> This addresses bug CLOUDSTACK-2322.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql fe53d36
>
> Diff: https://reviews.apache.org/r/10955/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2322) update network.gateway to fix deployVm
error on SharedNetwork after ipv6 support
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10955/#review20215
-----------------------------------------------------------
Commit 18f0f721d0b37be3dc20a0f757e36e4dd9050a03 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=18f0f72 ]
CLOUDSTACK-2322: update network.gateway to fix deployVm error on
SharedNetwork after ipv6 support
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On May 6, 2013, 6:08 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10955/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> The allocateDirectIp in NetworkManagerImpl.java changes after ipv6 support.
> Two sentences were added before assignPublicIP.
> (1) if (network.getGateway() != null)
> (2) if (network.getIp6Gateway() != null) {
> However, for Shared Network, both fields are null in table `cloud`.`networks`.
> Some fields in table `cloud`.`networks` need to be updated.
>
>
> This addresses bug CLOUDSTACK-2322.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql fe53d36
>
> Diff: https://reviews.apache.org/r/10955/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2322) update network.gateway to fix deployVm
error on SharedNetwork after ipv6 support
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10955/#review20217
-----------------------------------------------------------
Commit 599023b61b7c89a24d5d851499db05b9338ab922 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=599023b ]
CLOUDSTACK-2322: update network.gateway to fix deployVm error on
SharedNetwork after ipv6 support
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On May 6, 2013, 6:08 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10955/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> The allocateDirectIp in NetworkManagerImpl.java changes after ipv6 support.
> Two sentences were added before assignPublicIP.
> (1) if (network.getGateway() != null)
> (2) if (network.getIp6Gateway() != null) {
> However, for Shared Network, both fields are null in table `cloud`.`networks`.
> Some fields in table `cloud`.`networks` need to be updated.
>
>
> This addresses bug CLOUDSTACK-2322.
>
>
> Diffs
> -----
>
> setup/db/db/schema-40to410.sql fe53d36
>
> Diff: https://reviews.apache.org/r/10955/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>