You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2016/04/12 00:11:16 UTC
Review Request 46054: Enable Hive Interactive is turned ON by default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46054/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Yusaku Sako.
Bugs: AMBARI-15813
https://issues.apache.org/jira/browse/AMBARI-15813
Repository: ambari
Description
-------
This issue happens because recommendation API called by ambari-web on navigating to "Configure Services" page has Hive Interactive Server in the host component layout data sent with the API.
As a generic fix to this issue, any component hidden on Assign Master page (MySQL Server, Postgres and Hive Server Interactive) should not be saved as part of host component layout used as input for recommendation/validation calls.
Diffs
-----
ambari-web/app/controllers/wizard/step6_controller.js 1e1feb5
ambari-web/app/models/stack_service_component.js 26244f7
Diff: https://reviews.apache.org/r/46054/diff/
Testing
-------
#ambari-web unit tests passes with the patch:
Calling set on destroyed view
25640 tests complete (25 seconds)
154 tests pending
# Manually tested the patch to resolve the issue
Thanks,
Jaimin Jetly
Re: Review Request 46054: Enable Hive Interactive is turned ON by
default
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46054/#review128293
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On April 11, 2016, 10:11 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46054/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 10:11 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Yusaku Sako.
>
>
> Bugs: AMBARI-15813
> https://issues.apache.org/jira/browse/AMBARI-15813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This issue happens because recommendation API called by ambari-web on navigating to "Configure Services" page has Hive Interactive Server in the host component layout data sent with the API.
> As a generic fix to this issue, any component hidden on Assign Master page (MySQL Server, Postgres and Hive Server Interactive) should not be saved as part of host component layout used as input for recommendation/validation calls.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step6_controller.js 1e1feb5
> ambari-web/app/models/stack_service_component.js 26244f7
>
> Diff: https://reviews.apache.org/r/46054/diff/
>
>
> Testing
> -------
>
> #ambari-web unit tests passes with the patch:
> Calling set on destroyed view
>
> 25640 tests complete (25 seconds)
> 154 tests pending
>
> # Manually tested the patch to resolve the issue
>
>
> Thanks,
>
> Jaimin Jetly
>
>