[jira] [Commented] (CLOUDSTACK-9663) updateRole should return updated role as json

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325999#comment-16325999 ] 

ASF GitHub Bot commented on CLOUDSTACK-9663:
--------------------------------------------

dhlaluku opened a new pull request #2406: CLOUDSTACK-9663
URL: https://github.com/apache/cloudstack/pull/2406
 
 
   updateRole was only returning success but one would expect it returns the updated role as json like other update APIs. I have modified the command to return result as json format and tested using cloudmonkey. The command below is an example used for testing using cloudmonkey;
   
   updateRole id=8d06fc8b-b2b6-41cf-8551-39d31b8b9b49 name=User2 type=User description="Second user role" region=local
   
   Ran the 2 Marvin tests successfully: test_dynamicroles.py and test_staticroles.py
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> updateRole should return updated role as json
> ---------------------------------------------
>
>                 Key: CLOUDSTACK-9663
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9663
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.9.0
>            Reporter: René Moser
>            Priority: Trivial
>             Fix For: Future
>
>
> updateRole does currently only return success but one would expect it returns the updated role as json like other update APIs
> Acutal results:
> {code}
>  $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test --region=simulator
> {
>   "success": "true"
> }
> {code}
> expected resutls:
> {code}
>  $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test --region=simulator
> {
>   "role": {
>     "id": ...
>     "description": ...
>     "name": ...
>     "type": ...
>   }
> }
> {code}
> similar to other update api e.g. http://cloudstack.apache.org/api/apidocs-4.9/apis/updateUser.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)