[GitHub] [incubator-iceberg] cmathiesen commented on a change in pull request #935: [WIP] Internal relocated version of Guava

[GitBox <gi...@apache.org>]

cmathiesen commented on a change in pull request #935:
URL: https://github.com/apache/incubator-iceberg/pull/935#discussion_r417388382



##########
File path: build.gradle
##########
@@ -108,8 +104,42 @@ apply from: 'deploy.gradle'
 apply from: 'tasks.gradle'
 apply from: 'jmh.gradle'
 
+project(':iceberg-relocate-external-dependencies') {
+  apply plugin: 'com.github.johnrengelman.shadow'
+  
+  tasks.javadoc.enabled = false
+  tasks.javadocJar.enabled = false
+  tasks.assemble.dependsOn tasks.shadowJar
+  tasks.install.dependsOn tasks.shadowJar
+  
+  dependencies {    
+    compile('com.google.guava:guava:28.0-jre') {
+      exclude group: 'com.google.code.findbugs'
+      // may be LGPL - use ALv2 findbugs-annotations instead
+      exclude group: 'com.google.errorprone'
+      exclude group: 'com.google.j2objc'
+    }
+  }
+  
+  shadowJar {
+    configurations = [project.configurations.compile]
+    zip64 true
+
+    // include the LICENSE and NOTICE files for the shaded Jar
+    from(projectDir) {
+      include 'LICENSE'
+      include 'NOTICE'
+    }
+
+    relocate 'com.google.common', 'com.google.common.shaded'
+    
+    minimize()
+  }
+}
+
 project(':iceberg-api') {
   dependencies {
+    compile project(path: ':iceberg-relocate-external-dependencies', configuration: 'shadow')

Review comment:
       I've got it working with IntelliJ by building the `relocate-external-dependencies` first




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org