[GitHub] [nifi] ottobackwards commented on a diff in pull request #6151: NIFI-10154 ReplaceText AdminYielding on long line

[GitBox <gi...@apache.org>]

ottobackwards commented on code in PR #6151:
URL: https://github.com/apache/nifi/pull/6151#discussion_r927749963


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java:
##########
@@ -331,6 +332,10 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
             logger.info("Transferred {} to 'failure' due to {}", new Object[] { flowFile, e.toString() });

Review Comment:
   If we have multiple exception catches the do the same thing, maybe we shouldn't have separate catches.  It is just repeated code



##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java:
##########
@@ -331,6 +332,10 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
             logger.info("Transferred {} to 'failure' due to {}", new Object[] { flowFile, e.toString() });

Review Comment:
   but that is pre-existing to this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org