[GitHub] [flink] wuchong commented on a change in pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #14616:
URL: https://github.com/apache/flink/pull/14616#discussion_r556307216



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalSortMergeJoin.scala
##########
@@ -189,7 +189,7 @@ class BatchPhysicalSortMergeJoin(
       rightAllKey,
       filterNulls,
       condition,
-      estimateOutputSize(getLeft) < estimateOutputSize(getRight),
+     estimateOutputSize(getLeft) < estimateOutputSize(getRight),

Review comment:
       Please revert this. 

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -42,8 +42,8 @@
      *
      * <p>TODO: This method can be removed once FLINK-20879 is finished.
      */
-    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
-        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<MemorySize> option) {

Review comment:
       I think we don't need this utility method anymore. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org