You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/15 02:07:27 UTC
[GitHub] [apisix] jbampton opened a new pull request #3044: feat(CI): add a GitHub Action to lint the YAML files
jbampton opened a new pull request #3044:
URL: https://github.com/apache/apisix/pull/3044
Lint some YAML
Add a `.yamllint` config file
### What this PR does / why we need it:
Standardizes our YAML files
### Pre-submission checklist:
* [X] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on a change in pull request #3044: feat(CI): add a GitHub Action to lint the YAML files
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #3044:
URL: https://github.com/apache/apisix/pull/3044#discussion_r542991745
##########
File path: kubernetes/service-monitor-for-prometheus.yaml
##########
@@ -36,4 +36,3 @@ spec:
app: apisix-gw
namespaceSelector:
any: true
-
Review comment:
Last line is there seen here:
view-source:https://raw.githubusercontent.com/apache/apisix/9f771b29232929dc5e85b9c97c4d43ff86924ee5/kubernetes/service-monitor-for-prometheus.yaml
That file has 2 lines at the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3044: feat(CI): add a GitHub Action to lint the YAML files
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3044:
URL: https://github.com/apache/apisix/pull/3044#discussion_r542997341
##########
File path: conf/apisix.yaml
##########
@@ -19,7 +19,7 @@ routes:
-
uri: /hello
upstream:
- nodes:
- "127.0.0.1:1980": 1
- type: roundrobin
-#END
+ nodes:
+ "127.0.0.1:1980": 1
+ type: roundrobin
+# END
Review comment:
The `#END` is a special EOF token. Can we exclude it from the lint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3044: feat(CI): add a GitHub Action to lint the YAML files
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #3044:
URL: https://github.com/apache/apisix/pull/3044#discussion_r542989967
##########
File path: conf/apisix.yaml
##########
@@ -19,7 +19,7 @@ routes:
-
uri: /hello
upstream:
- nodes:
- "127.0.0.1:1980": 1
- type: roundrobin
-#END
+ nodes:
+ "127.0.0.1:1980": 1
+ type: roundrobin
+# END
Review comment:
Not sure, cc @spacewander
##########
File path: conf/debug.yaml
##########
@@ -28,4 +28,4 @@ hook_phase: # module and function list, name: hook_phase
- http_body_filter_phase
- http_log_phase
-#END
+# END
Review comment:
,
##########
File path: kubernetes/service-monitor-for-prometheus.yaml
##########
@@ -36,4 +36,3 @@ spec:
app: apisix-gw
namespaceSelector:
any: true
-
Review comment:
🤔 May need to keep the last line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3044: feat(CI): add a GitHub Action to lint the YAML files
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3044:
URL: https://github.com/apache/apisix/pull/3044#discussion_r544777287
##########
File path: conf/config-default.yaml
##########
@@ -205,8 +206,8 @@ plugins: # plugin list (sorted in alphabetical order)
- consumer-restriction
- cors
- echo
- #- error-log-logger
- #- example-plugin
+ # - error-log-logger
+ # - example-plugin
Review comment:
Need to update this line: https://github.com/apache/apisix/blob/f476d2c3dc68439406a9531fc8b4a2a2d50c1333/t/APISIX.pm#L75
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #3044: feat(CI): add a GitHub Action to lint the YAML files
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #3044:
URL: https://github.com/apache/apisix/pull/3044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org