[I] I don't understand why it's necessary to modify the dependency's hot plug during a minor version upgrade [shardingsphere]

["LLLJJJSSS (via GitHub)" <gi...@apache.org>]

LLLJJJSSS opened a new issue, #38399:
URL: https://github.com/apache/shardingsphere/issues/38399

   Most minor version upgrades involve modifying defects, and the content after upgrading from 5.5.2 to 5.5.3 directly leads to the need to reintroduce dependencies to ensure the normal operation of the project. Why not modify version 5.6. x?
   
   - Decouple feature modules as pluggable - https://github.com/apache/shardingsphere/pull/36086
   - Decouple database types as pluggable - https://github.com/apache/shardingsphere/pull/35346
   - Decouple registry center types as pluggable - https://github.com/apache/shardingsphere/pull/36087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] I don't understand why it's necessary to modify the dependency's hot plug during a minor version upgrade [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu closed issue #38399: I don't understand why it's necessary to modify the dependency's hot plug during a minor version upgrade
URL: https://github.com/apache/shardingsphere/issues/38399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] I don't understand why it's necessary to modify the dependency's hot plug during a minor version upgrade [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on issue #38399:
URL: https://github.com/apache/shardingsphere/issues/38399#issuecomment-4045811295

   Thanks for the feedback.
   
   This is not an accidental regression in 5.5.3, but an intentional dependency model adjustment introduced in 5.5.3.
   
   Starting from 5.5.3, some capabilities were decoupled into pluggable / optional modules, including feature modules, database type / dialect related modules, and registry / repository implementations. As a result, when upgrading from 5.5.2 to 5.5.3, some capabilities that were previously available through the core package by default now require the corresponding plugin dependencies to be added explicitly.
   
   This is also reflected in the 5.5.3 release notes and in the current JDBC / Proxy optional plugin documentation.
   
   So, more precisely:
   - 5.5.3 changed the default dependency assembly model;
   - some capabilities that previously worked through built-in or transitive dependencies now require explicit plugin dependencies;
   - this is expected behavior in 5.5.3 rather than a runtime bug.
   
   That said, your concern about requiring additional dependencies in a minor version upgrade is reasonable. We can further improve the upgrade notes to make the dependency changes from 5.5.2 to 5.5.3 clearer and easier for users to follow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org