You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/09/14 22:55:33 UTC
Review Request 38365: Updated Isolator::prepare to return list of
required namespaces.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/
-----------------------------------------------------------
Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
Bugs: MESOS-3387
https://issues.apache.org/jira/browse/MESOS-3387
Repository: mesos
Description
-------
This allows the Isolators to decide whether or not to provide resource isolation
on a per-container level.
Diffs
-----
include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02
include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
src/slave/containerizer/isolators/filesystem/linux.hpp ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94
src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9
src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899
src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630
src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68
src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
src/slave/containerizer/isolators/network/port_mapping.cpp 34ba2294b0bd7d57aa9de073692a2ea8ec62681d
src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03
src/tests/containerizer/isolator_tests.cpp d34c82a7f24da6f60cfb22790f516dc6065b1f6f
Diff: https://reviews.apache.org/r/38365/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 38365: Updated Isolator::prepare to return list of
required namespaces.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 6 p.m.)
Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
Changes
-------
rebased
Bugs: MESOS-3387
https://issues.apache.org/jira/browse/MESOS-3387
Repository: mesos
Description
-------
This allows the Isolators to decide whether or not to provide resource isolation
on a per-container level.
Diffs (updated)
-----
include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02
include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
src/slave/containerizer/isolators/filesystem/linux.hpp 6cfe9fa2971d50f545587b57721f75a981f6d5ed
src/slave/containerizer/isolators/filesystem/linux.cpp dbdbf8722d088ef671b705c0c42191d0f9e05be9
src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899
src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630
src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68
src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
src/slave/containerizer/isolators/network/port_mapping.cpp 34ba2294b0bd7d57aa9de073692a2ea8ec62681d
src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03
src/tests/containerizer/isolator_tests.cpp d34c82a7f24da6f60cfb22790f516dc6065b1f6f
Diff: https://reviews.apache.org/r/38365/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 38365: Updated Isolator::prepare to return list of
required namespaces.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 5:05 p.m.)
Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
Changes
-------
rebased
Bugs: MESOS-3387
https://issues.apache.org/jira/browse/MESOS-3387
Repository: mesos
Description
-------
This allows the Isolators to decide whether or not to provide resource isolation
on a per-container level.
Diffs (updated)
-----
include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02
include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
src/slave/containerizer/isolators/filesystem/linux.hpp ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94
src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9
src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899
src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630
src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68
src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
src/slave/containerizer/isolators/network/port_mapping.cpp 34ba2294b0bd7d57aa9de073692a2ea8ec62681d
src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03
src/tests/containerizer/isolator_tests.cpp d34c82a7f24da6f60cfb22790f516dc6065b1f6f
Diff: https://reviews.apache.org/r/38365/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 38365: Updated Isolator::prepare to return list of
required namespaces.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Sept. 14, 2015, 6:50 p.m., Niklas Nielsen wrote:
> > include/mesos/slave/isolator.proto, line 75
> > <https://reviews.apache.org/r/38365/diff/1/?file=1072932#file1072932line75>
> >
> > Taken we still wrap comments at 70, this needs to be wrapped :)
We don't :-). See https://github.com/apache/mesos/commit/f9c2604ea97b91f8a9ec3b2863317761679b1c86.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/#review98937
-----------------------------------------------------------
On Sept. 15, 2015, 5:05 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38365/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 5:05 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
>
>
> Bugs: MESOS-3387
> https://issues.apache.org/jira/browse/MESOS-3387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the Isolators to decide whether or not to provide resource isolation
> on a per-container level.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02
> include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
> src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
> src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
> src/slave/containerizer/isolators/filesystem/linux.hpp ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94
> src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9
> src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899
> src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
> src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630
> src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68
> src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
> src/slave/containerizer/isolators/network/port_mapping.cpp 34ba2294b0bd7d57aa9de073692a2ea8ec62681d
> src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03
> src/tests/containerizer/isolator_tests.cpp d34c82a7f24da6f60cfb22790f516dc6065b1f6f
>
> Diff: https://reviews.apache.org/r/38365/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 38365: Updated Isolator::prepare to return list of
required namespaces.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/#review98937
-----------------------------------------------------------
Ship it!
include/mesos/slave/isolator.proto (line 75)
<https://reviews.apache.org/r/38365/#comment155698>
Taken we still wrap comments at 70, this needs to be wrapped :)
- Niklas Nielsen
On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38365/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 1:55 p.m.)
>
>
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
>
>
> Bugs: MESOS-3387
> https://issues.apache.org/jira/browse/MESOS-3387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows the Isolators to decide whether or not to provide resource isolation
> on a per-container level.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02
> include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
> src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
> src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
> src/slave/containerizer/isolators/filesystem/linux.hpp ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94
> src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9
> src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899
> src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
> src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630
> src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68
> src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
> src/slave/containerizer/isolators/network/port_mapping.cpp 34ba2294b0bd7d57aa9de073692a2ea8ec62681d
> src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03
> src/tests/containerizer/isolator_tests.cpp d34c82a7f24da6f60cfb22790f516dc6065b1f6f
>
> Diff: https://reviews.apache.org/r/38365/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>