You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/11/30 21:17:48 UTC

[GitHub] [guacamole-client] benrubson commented on a change in pull request #554: GUACAMOLE-890: Security: Allow image to run as non-root user

benrubson commented on a change in pull request #554:
URL: https://github.com/apache/guacamole-client/pull/554#discussion_r532909132



##########
File path: guacamole-docker/bin/start.sh
##########
@@ -659,9 +659,15 @@ associate_header() {
 ##
 start_guacamole() {
 
+    # User-only writable CATALINA_BASE
+    export CATALINA_BASE=$GUACAMOLE_HOME/tomcat

Review comment:
       Thank you very much for your feedback @mike-jumper 👍
   You're right, I modified accordingly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org