You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2007/04/12 18:27:32 UTC
[jira] Created: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
CompressedPackageResource should have a switch to enable/disable
----------------------------------------------------------------
Key: WICKET-464
URL: https://issues.apache.org/jira/browse/WICKET-464
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3
Reporter: Peter Ertl
It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
Default should be 'on'.
It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-464.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.0-rc1)
1.3.0-beta2
Assignee: Alastair Maw (was: Matej Knopp)
You can now override this in your application init method with:
Application.getResourceSettings().setDisableGZipCompression(true);
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assignee: Alastair Maw
> Priority: Critical
> Fix For: 1.3.0-beta2
>
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) CompressedPackageResource should
have a switch to enable/disable
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499046 ]
Peter Ertl commented on WICKET-464:
-----------------------------------
I can't tell you how glad I am that somebody finds this issue as important as me. This issue is really giving me a serious headache :-(
Thank you so much!!!
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assigned To: Matej Knopp
> Priority: Critical
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-464:
--------------------------------
Fix Version/s: 1.3.0-rc1
Need to get this in before RC-1 so we can claim SAP support.
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assignee: Matej Knopp
> Priority: Critical
> Fix For: 1.3.0-rc1
>
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) CompressedPackageResource should
have a switch to enable/disable
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488849 ]
Peter Ertl commented on WICKET-464:
-----------------------------------
is that a question?
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Peter Ertl
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) Add global override to disable gzip
compression (SAP double-compresses).
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500948 ]
Peter Ertl commented on WICKET-464:
-----------------------------------
Just to justify the need for a switch (after martins previous post)...
Usually SAP J2EE server is used in a large company structure with with full-time administrators and lots of other web applications (often without wicket) are deployed on the same server. So disabling is not always an option.
> Add global override to disable gzip compression (SAP double-compresses).
> ------------------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-464) Add global override to disable gzip
compression (SAP double-compresses).
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-464:
--------------------------------
Priority: Major (was: Critical)
Summary: Add global override to disable gzip compression (SAP double-compresses). (was: CompressedPackageResource should have a switch to enable/disable)
> Add global override to disable gzip compression (SAP double-compresses).
> ------------------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) CompressedPackageResource should
have a switch to enable/disable
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497907 ]
Peter Ertl commented on WICKET-464:
-----------------------------------
I really don't want to bug you wicket guys but leaving the compression on will make wicket _ 100% unusable_ on SAP J2EE Server 6.40. The application won't even start as the initial loading of compressed package resources will fail. Having a little switch to enable/disable compression would hurt nobody but make wicket accessible on one more server platform.
I know the server is the problem, not wicket, however there's no fix available for the broken compression so having a switch would be the best solution.
Also, it would be nice to delegate compression to the server instead of doing it natively, as an option.
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0
> Reporter: Peter Ertl
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-464:
------------------------------
Attachment: compress_on_off.txt
This is my suggestion / contribution for solving the compression issue.
Usage of compression is a resource configuration setting which can be enabled / disabled e.g. in Application#init. Default is 'on' so current users won't be affected and users having problems with gzip (because the server already does it or it causes problems) can disable it.
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Peter Ertl
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-464:
------------------------------
Description:
It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
Default should be 'on'.
It's always good to have an option.
was:
It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
Default should be 'on'.
It's always good to have an option.
Issue Type: Bug (was: Improvement)
Not being able to disable compression makes wicket resources unreadable on a default installation of SAP J2EE Web Application Server. It will by default compress the compressed resource again (which is just stupid) which will result in resource being compressed two times. The browser only decompresses one time and will therfore fail to load the resource.
So, having compression on, will break your application on a default installation of SAP J2EE.
http://en.wikipedia.org/wiki/SAP_Web_Application_Server
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Peter Ertl
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) CompressedPackageResource should
have a switch to enable/disable
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488487 ]
Johan Compagner commented on WICKET-464:
----------------------------------------
isn't it possible then to switch between CompressedPackageResource and normal PackageResource?
because to have a boolean again that disabled compressing for the compressed package resource...
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Peter Ertl
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reassigned WICKET-464:
----------------------------------
Assignee: Matej Knopp
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assigned To: Matej Knopp
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-464) CompressedPackageResource should have
a switch to enable/disable
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp updated WICKET-464:
-------------------------------
Priority: Critical (was: Major)
Definitely needs attention before 1.3
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assigned To: Matej Knopp
> Priority: Critical
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) CompressedPackageResource should
have a switch to enable/disable
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488856 ]
Johan Compagner commented on WICKET-464:
----------------------------------------
comment and question... :)
for the one that will be looking into this. Because we already have a factory method for this:
ComponentPackageResource.get() maybe this one will fall back to the normal package resource when something is turned on or off
that would be the best fix i guess
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Peter Ertl
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) Add global override to disable gzip
compression (SAP double-compresses).
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500925 ]
Martin Grigorov commented on WICKET-464:
----------------------------------------
Just for the record. Here is the way how to disable compression in SAP AS:
Open ConfigTool (/usr/sap/SID/JCXX/j2ee/configtool/configtool.sh)
Browse the tree: cluster-data -> instance -> services -> http
Here you can change these properties: AlwaysCompressed, CompressedOthers, NeverCompressed, MinimumGZipLength
Regards
Martin
> Add global override to disable gzip compression (SAP double-compresses).
> ------------------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Peter Ertl
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
> Attachments: compress_on_off.txt
>
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-464) CompressedPackageResource should
have a switch to enable/disable
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489352 ]
Peter Ertl commented on WICKET-464:
-----------------------------------
I would put it in [boolean CompressedPackageResource#supportsCompression() ]...
> CompressedPackageResource should have a switch to enable/disable
> ----------------------------------------------------------------
>
> Key: WICKET-464
> URL: https://issues.apache.org/jira/browse/WICKET-464
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Peter Ertl
>
> It should be possible to deactivate gzip compression. Sometimes gzip is already handled by a proxy server or gzip raises problems (like I experienced on SAP J2EE Enterprise Server).
> Default should be 'on'.
> It's always good to have an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.