You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jonsyu1 (via GitHub)" <gi...@apache.org> on 2025/12/17 19:28:23 UTC
[I] Improvement: Allow callers to configure metrics reporter on ScanBuilder [iceberg]
jonsyu1 opened a new issue, #14875:
URL: https://github.com/apache/iceberg/issues/14875
### Feature Request / Improvement
The `ScanBuilder` class encapsulates the underlying `TableScan` created from the `Table`, preventing callers from configuring how metrics are reported for this specific scan. Here is a simple way I envision this new method being used:
```
MetricsReporter metricsReporter = new InMemoryMetricsReporter();
ScanBuilder scanBuilder = IcebergGenerics.read(table);
scanBuilder.metricsReporter(metricsReporter);
// finish building scan and read data
ScanReport scanReport = metricsReporter.scanReport();
// use scan report to wire telemetry and log details
```
See https://github.com/apache/iceberg/pull/14654 for my proposed implementation.
### Query engine
None
### Willingness to contribute
- [x] I can contribute this improvement/feature independently
- [ ] I would be willing to contribute this improvement/feature with guidance from the Iceberg community
- [ ] I cannot contribute this improvement/feature at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Improvement: Allow callers to configure metrics reporter on ScanBuilder [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary closed issue #14875: Improvement: Allow callers to configure metrics reporter on ScanBuilder
URL: https://github.com/apache/iceberg/issues/14875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Improvement: Allow callers to configure metrics reporter on ScanBuilder [iceberg]
Posted by "alexandrefimov (via GitHub)" <gi...@apache.org>.
alexandrefimov commented on issue #14875:
URL: https://github.com/apache/iceberg/issues/14875#issuecomment-4583337588
Hi, I am interested in picking this up if the direction is still welcome.
From a diagnostics/observability perspective, exposing `metricsReporter` on `IcebergGenerics.ScanBuilder` looks useful because the builder currently hides the underlying `TableScan`, while `TableScan` already supports scan metrics reporting. The change I have in mind is intentionally small: add a delegating `metricsReporter(MetricsReporter reporter)` method to `IcebergGenerics.ScanBuilder`, keep the existing `TableScan.metricsReporter` combine semantics, and cover it with a focused test that verifies a `ScanReport` is emitted for a generic read.
I noticed the earlier PR #14654 was closed as stale rather than rejected. If there are no objections to this API shape, I can send a minimal PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org