[jira] [Commented] (HTRACE-312) htraced: if GOMAXPROCS is left at 1, set it to the number of CPUs

["Masatake Iwasaki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034015#comment-15034015 ] 

Masatake Iwasaki commented on HTRACE-312:
-----------------------------------------

Thanks for working on this, [~cmccabe] .

The patch looks good. I got some performance gain on {{BenchmarkDatastoreWrites}} (to which I pasted the code in the patch) though I tested on VM with 2 vcpus..

Do you have positive benchmark result on bigger machine?

> htraced: if GOMAXPROCS is left at 1, set it to the number of CPUs
> -----------------------------------------------------------------
>
>                 Key: HTRACE-312
>                 URL: https://issues.apache.org/jira/browse/HTRACE-312
>             Project: HTrace
>          Issue Type: Improvement
>          Components: htraced
>    Affects Versions: 4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-312.001.patch
>
>
> htraced: if GOMAXPROCS is left at 1, set it to the number of CPUs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)