[GitHub] [iceberg] rubenvdg commented on a diff in pull request #6462: Python: Check for nans when creating literal

[GitBox <gi...@apache.org>]

rubenvdg commented on code in PR #6462:
URL: https://github.com/apache/iceberg/pull/6462#discussion_r1053648911


##########
python/pyiceberg/expressions/literals.py:
##########
@@ -65,6 +66,9 @@ class Literal(Generic[L], ABC):
     def __init__(self, value: L, value_type: Type[L]):
         if value is None or not isinstance(value, value_type):
             raise TypeError(f"Invalid literal value: {value!r} (not a {value_type})")
+        if isinstance(value, float):

Review Comment:
   Fixed! I never realized that -- good to know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org