You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/15 11:40:24 UTC
[GitHub] [openwhisk-runtime-python] sciabarra opened a new pull request #80:
Updated actionloop python
sciabarra opened a new pull request #80: Updated actionloop python
URL: https://github.com/apache/openwhisk-runtime-python/pull/80
This PR updates the actionloop Python to support precompilation. Also fixes Python2 that is disabled but still available in source for those who may need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-python] rabbah commented on issue #80: Updated
actionloop python
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #80: Updated actionloop python
URL: https://github.com/apache/openwhisk-runtime-python/pull/80#issuecomment-578873836
This needs a rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull
request #80: Updated actionloop python
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #80: Updated actionloop python
URL: https://github.com/apache/openwhisk-runtime-python/pull/80#discussion_r366874942
##########
File path: core/python2ActionLoop/Dockerfile
##########
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#FROM golang:1.11 as builder
+#ENV PROXY_SOURCE=https://github.com/apache/incubator-openwhisk-runtime-go/archive/golang1.11@1.13.0-incubating.tar.gz
+#RUN curl -sL "$PROXY_SOURCE" | tar xzf - \
+# && mkdir -p src/github.com/apache \
+# && mv incubator-openwhisk-runtime-go-golang1.11-1.13.0-incubating \
+# src/github.com/apache/incubator-openwhisk-runtime-go \
+# && cd src/github.com/apache/incubator-openwhisk-runtime-go/main \
+# && CGO_ENABLED=0 go build -o /bin/proxy
+FROM golang:1.12 as builder
+RUN env CGO_ENABLED=0 go get github.com/apache/openwhisk-runtime-go/main && mv /go/bin/main /bin/proxy
+FROM python:2.7-alpine
Review comment:
can you adapt this to use the same approach used in the swift runtime https://github.com/apache/openwhisk-runtime-swift/commit/418ced76f56f71ad367b0c36e0fdf895cec51ead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-python] sciabarra closed pull request #80:
Updated actionloop python [work in progress]
Posted by GitBox <gi...@apache.org>.
sciabarra closed pull request #80: Updated actionloop python [work in progress]
URL: https://github.com/apache/openwhisk-runtime-python/pull/80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull
request #80: Updated actionloop python
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #80: Updated actionloop python
URL: https://github.com/apache/openwhisk-runtime-python/pull/80#discussion_r371394132
##########
File path: core/python2ActionLoop/Dockerfile
##########
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#FROM golang:1.11 as builder
+#ENV PROXY_SOURCE=https://github.com/apache/incubator-openwhisk-runtime-go/archive/golang1.11@1.13.0-incubating.tar.gz
+#RUN curl -sL "$PROXY_SOURCE" | tar xzf - \
+# && mkdir -p src/github.com/apache \
+# && mv incubator-openwhisk-runtime-go-golang1.11-1.13.0-incubating \
+# src/github.com/apache/incubator-openwhisk-runtime-go \
+# && cd src/github.com/apache/incubator-openwhisk-runtime-go/main \
+# && CGO_ENABLED=0 go build -o /bin/proxy
+FROM golang:1.12 as builder
+RUN env CGO_ENABLED=0 go get github.com/apache/openwhisk-runtime-go/main && mv /go/bin/main /bin/proxy
+FROM python:2.7-alpine
Review comment:
this is already done by #81 which was merged and a rebase will pick it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services